Patch Detail
Show a patch.
GET /api/1.1/patches/3842/?format=api
{ "id": 3842, "url": "https://patchwork.libcamera.org/api/1.1/patches/3842/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3842/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200522145459.16836-4-laurent.pinchart@ideasonboard.com>", "date": "2020-05-22T14:54:50", "name": "[libcamera-devel,PATCH/RFC,02/11] libcamera: Replace C++ comments with C comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4afd96204c3758a106e7d6eaa754302c816fa289", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3842/mbox/", "series": [ { "id": 923, "url": "https://patchwork.libcamera.org/api/1.1/series/923/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=923", "date": "2020-05-22T14:54:47", "name": "Introduce formats:: namespace for libcamera pixel formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/923/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3842/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3842/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 181F0603D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 May 2020 16:55:20 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5D6A528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 May 2020 16:55:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RUjK6uHx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590159319;\n\tbh=f+YmrMKowvOk1M8CL2X9bwKcz3Iv3UB4ZvLqdEcBtKc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RUjK6uHx5mLioDbv/LpbowJXm1p3jvkbnH3tr4Tb1FJxoMaCRIwP4/ekoUtRHN/zf\n\tGgavfAcb/nwRkaOCdgI4kLgWM3M9+phAf6Vqm7Gj0yG1RhwRFtlnpVPs/4zBCfCSA3\n\toXwYRcKMIRBTvSk1mppb7j4NNr63mR0LW7aLZT+M=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 May 2020 17:54:50 +0300", "Message-Id": "<20200522145459.16836-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>", "References": "<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH/RFC 02/11] libcamera: Replace C++ comments\n\twith C comments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 22 May 2020 14:55:20 -0000" }, "content": "The control_ids.h.in and property_ids.h.in headers use C++-style\ncomments, when the coding style mandates C-style comments. Fix them.\n\nWhile at it, adjust three minor typos in comments.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/control_ids.h.in | 4 ++--\n include/libcamera/property_ids.h.in | 6 +++---\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\nindex 6ff0e4186983..95a7a7f1e260 100644\n--- a/include/libcamera/control_ids.h.in\n+++ b/include/libcamera/control_ids.h.in\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * control_ids.h : Control ID list\n+ * control_ids.h - Control ID list\n *\n * This file is auto-generated. Do not edit.\n */\n@@ -30,4 +30,4 @@ extern const ControlIdMap controls;\n \n } /* namespace libcamera */\n \n-#endif // __LIBCAMERA_CONTROL_IDS_H__\n+#endif /* __LIBCAMERA_CONTROL_IDS_H__ */\ndiff --git a/include/libcamera/property_ids.h.in b/include/libcamera/property_ids.h.in\nindex 62799b3e8c54..e4dea335cd3b 100644\n--- a/include/libcamera/property_ids.h.in\n+++ b/include/libcamera/property_ids.h.in\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * property_ids.h : Property ID list\n+ * property_ids.h - Property ID list\n *\n * This file is auto-generated. Do not edit.\n */\n@@ -26,8 +26,8 @@ ${controls}\n \n extern const ControlIdMap properties;\n \n-} /* namespace propertiess */\n+} /* namespace properties */\n \n } /* namespace libcamera */\n \n-#endif // __LIBCAMERA_PROPERTY_IDS_H__\n+#endif /* __LIBCAMERA_PROPERTY_IDS_H__ */\n", "prefixes": [ "libcamera-devel", "PATCH/RFC", "02/11" ] }