| Message ID | 20200522145459.16836-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 22/05/2020 15:54, Laurent Pinchart wrote: > The control_ids.h.in and property_ids.h.in headers use C++-style > comments, when the coding style mandates C-style comments. Fix them. > > While at it, adjust three minor typos in comments. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/control_ids.h.in | 4 ++-- > include/libcamera/property_ids.h.in | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in > index 6ff0e4186983..95a7a7f1e260 100644 > --- a/include/libcamera/control_ids.h.in > +++ b/include/libcamera/control_ids.h.in > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2019, Google Inc. > * > - * control_ids.h : Control ID list > + * control_ids.h - Control ID list > * > * This file is auto-generated. Do not edit. > */ > @@ -30,4 +30,4 @@ extern const ControlIdMap controls; > > } /* namespace libcamera */ > > -#endif // __LIBCAMERA_CONTROL_IDS_H__ > +#endif /* __LIBCAMERA_CONTROL_IDS_H__ */ > diff --git a/include/libcamera/property_ids.h.in b/include/libcamera/property_ids.h.in > index 62799b3e8c54..e4dea335cd3b 100644 > --- a/include/libcamera/property_ids.h.in > +++ b/include/libcamera/property_ids.h.in > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2019, Google Inc. > * > - * property_ids.h : Property ID list > + * property_ids.h - Property ID list > * > * This file is auto-generated. Do not edit. > */ > @@ -26,8 +26,8 @@ ${controls} > > extern const ControlIdMap properties; > > -} /* namespace propertiess */ > +} /* namespace properties */ > > } /* namespace libcamera */ > > -#endif // __LIBCAMERA_PROPERTY_IDS_H__ > +#endif /* __LIBCAMERA_PROPERTY_IDS_H__ */ >
Hi Laurent, Thanks for your work. On 2020-05-22 17:54:50 +0300, Laurent Pinchart wrote: > The control_ids.h.in and property_ids.h.in headers use C++-style > comments, when the coding style mandates C-style comments. Fix them. > > While at it, adjust three minor typos in comments. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > include/libcamera/control_ids.h.in | 4 ++-- > include/libcamera/property_ids.h.in | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in > index 6ff0e4186983..95a7a7f1e260 100644 > --- a/include/libcamera/control_ids.h.in > +++ b/include/libcamera/control_ids.h.in > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2019, Google Inc. > * > - * control_ids.h : Control ID list > + * control_ids.h - Control ID list > * > * This file is auto-generated. Do not edit. > */ > @@ -30,4 +30,4 @@ extern const ControlIdMap controls; > > } /* namespace libcamera */ > > -#endif // __LIBCAMERA_CONTROL_IDS_H__ > +#endif /* __LIBCAMERA_CONTROL_IDS_H__ */ > diff --git a/include/libcamera/property_ids.h.in b/include/libcamera/property_ids.h.in > index 62799b3e8c54..e4dea335cd3b 100644 > --- a/include/libcamera/property_ids.h.in > +++ b/include/libcamera/property_ids.h.in > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2019, Google Inc. > * > - * property_ids.h : Property ID list > + * property_ids.h - Property ID list > * > * This file is auto-generated. Do not edit. > */ > @@ -26,8 +26,8 @@ ${controls} > > extern const ControlIdMap properties; > > -} /* namespace propertiess */ > +} /* namespace properties */ > > } /* namespace libcamera */ > > -#endif // __LIBCAMERA_PROPERTY_IDS_H__ > +#endif /* __LIBCAMERA_PROPERTY_IDS_H__ */ > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in index 6ff0e4186983..95a7a7f1e260 100644 --- a/include/libcamera/control_ids.h.in +++ b/include/libcamera/control_ids.h.in @@ -2,7 +2,7 @@ /* * Copyright (C) 2019, Google Inc. * - * control_ids.h : Control ID list + * control_ids.h - Control ID list * * This file is auto-generated. Do not edit. */ @@ -30,4 +30,4 @@ extern const ControlIdMap controls; } /* namespace libcamera */ -#endif // __LIBCAMERA_CONTROL_IDS_H__ +#endif /* __LIBCAMERA_CONTROL_IDS_H__ */ diff --git a/include/libcamera/property_ids.h.in b/include/libcamera/property_ids.h.in index 62799b3e8c54..e4dea335cd3b 100644 --- a/include/libcamera/property_ids.h.in +++ b/include/libcamera/property_ids.h.in @@ -2,7 +2,7 @@ /* * Copyright (C) 2019, Google Inc. * - * property_ids.h : Property ID list + * property_ids.h - Property ID list * * This file is auto-generated. Do not edit. */ @@ -26,8 +26,8 @@ ${controls} extern const ControlIdMap properties; -} /* namespace propertiess */ +} /* namespace properties */ } /* namespace libcamera */ -#endif // __LIBCAMERA_PROPERTY_IDS_H__ +#endif /* __LIBCAMERA_PROPERTY_IDS_H__ */
The control_ids.h.in and property_ids.h.in headers use C++-style comments, when the coding style mandates C-style comments. Fix them. While at it, adjust three minor typos in comments. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/control_ids.h.in | 4 ++-- include/libcamera/property_ids.h.in | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)