Patch Detail
Show a patch.
GET /api/1.1/patches/3666/?format=api
{ "id": 3666, "url": "https://patchwork.libcamera.org/api/1.1/patches/3666/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3666/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200502135355.22757-2-laurent.pinchart@ideasonboard.com>", "date": "2020-05-02T13:53:53", "name": "[libcamera-devel,1/3] libcamera: camera_sensor: Access entity directly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a7ebe36b7e18232c381fce48f66ccdca5a59c624", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3666/mbox/", "series": [ { "id": 871, "url": "https://patchwork.libcamera.org/api/1.1/series/871/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=871", "date": "2020-05-02T13:53:52", "name": "libcamera: Prepare to support more complex sensors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/871/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3666/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3666/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0045603FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 2 May 2020 15:54:02 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5344572C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 2 May 2020 15:54:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hBE/v70p\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588427642;\n\tbh=OKFX7xSr0bMo3PigJy5KE87+0TYmKQR173fRRvRb1vI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hBE/v70pDuHtajtbN2+3Hc98A1d2ttHWzHL9aaTKOHFKrzz56geDvttxSgE4FoO7f\n\t2eTYpvB2punFXEMcW/Si6jODClJsRyRLPGzBrUZFd85L/5jn/Rfny55+uD+6vSefTQ\n\tgnuMlHR/YZzS2xbk4TC7w+wF1MKKhkl3WwEEvSSY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 2 May 2020 16:53:53 +0300", "Message-Id": "<20200502135355.22757-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "In-Reply-To": "<20200502135355.22757-1-laurent.pinchart@ideasonboard.com>", "References": "<20200502135355.22757-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Access\n\tentity directly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 02 May 2020 13:54:03 -0000" }, "content": "The CameraSensor::logPrefix() function accesses the entity from the\nsubdev. Remove the level of indirection as we stored a pointer to the\nentity internally.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_sensor.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex d7e11cdae7f0..ab2bed561cc6 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -539,7 +539,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n \n std::string CameraSensor::logPrefix() const\n {\n-\treturn \"'\" + subdev_->entity()->name() + \"'\";\n+\treturn \"'\" + entity_->name() + \"'\";\n }\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "1/3" ] }