| Message ID | 20200502135355.22757-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for your patch. On 2020-05-02 16:53:53 +0300, Laurent Pinchart wrote: > The CameraSensor::logPrefix() function accesses the entity from the > subdev. Remove the level of indirection as we stored a pointer to the > entity internally. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/camera_sensor.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp > index d7e11cdae7f0..ab2bed561cc6 100644 > --- a/src/libcamera/camera_sensor.cpp > +++ b/src/libcamera/camera_sensor.cpp > @@ -539,7 +539,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const > > std::string CameraSensor::logPrefix() const > { > - return "'" + subdev_->entity()->name() + "'"; > + return "'" + entity_->name() + "'"; > } > > } /* namespace libcamera */ > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index d7e11cdae7f0..ab2bed561cc6 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -539,7 +539,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const std::string CameraSensor::logPrefix() const { - return "'" + subdev_->entity()->name() + "'"; + return "'" + entity_->name() + "'"; } } /* namespace libcamera */
The CameraSensor::logPrefix() function accesses the entity from the subdev. Remove the level of indirection as we stored a pointer to the entity internally. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/camera_sensor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)