Patch Detail
Show a patch.
GET /api/1.1/patches/3610/?format=api
{ "id": 3610, "url": "https://patchwork.libcamera.org/api/1.1/patches/3610/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3610/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>", "date": "2020-04-29T15:19:10", "name": "[libcamera-devel] libcamera: ipa_manager: Fix build path comments", "commit_ref": "389c19c267cb20312a0fd895c2418da73c91283d", "pull_url": null, "state": "accepted", "archived": false, "hash": "0a0fc89c8d93da7d6fc47fbcbb3ba81b8a24a0c1", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3610/mbox/", "series": [ { "id": 851, "url": "https://patchwork.libcamera.org/api/1.1/series/851/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=851", "date": "2020-04-29T15:19:10", "name": "[libcamera-devel] libcamera: ipa_manager: Fix build path comments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/851/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3610/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3610/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A04C1609D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Apr 2020 17:19:14 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1819C521;\n\tWed, 29 Apr 2020 17:19:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kVAvkomp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588173554;\n\tbh=ZlR0itfzPUIqBRFcz5nrcbxfS78VpHaR8pTVmxXiSb0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=kVAvkomp/GJ2QsqandTdiZ9IvjuEY56BcbD258hGwPqUcoMLNdU5RIQCBHuMnJtZJ\n\tjuJpzfHbPTm0jEkQNDctRUgRQtczhdg2UWwgkNun0XA/g0ayNUiUy8RnlPvdPro/t+\n\t8dj6Hp98TBUTpBHDDx3I5/0ksHKQI6TT4fit/idc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 29 Apr 2020 16:19:10 +0100", "Message-Id": "<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build path\n\tcomments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 29 Apr 2020 15:19:14 -0000" }, "content": "The comments describe functionality before libcameraBuildPath() was\nadapted from libcameraPath() to return the root of the build, and\ndescribed having to take a relative path.\n\nThis is no longer the case, and the comment is inaccurate. Fix it.\n\nFixes: 1b8ac8473c94 (\"libcamera: utils: Adapt libcameraPath to match use cases\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/ipa_manager.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex df3786797010..1faa3dd38188 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -114,10 +114,7 @@ IPAManager::IPAManager()\n \n \t/*\n \t * When libcamera is used before it is installed, load IPAs from the\n-\t * same build directory as the libcamera library itself. This requires\n-\t * identifying the path of the libcamera.so, and referencing a relative\n-\t * path for the IPA from that point. We need to recurse one level of\n-\t * sub-directories to match the build tree.\n+\t * same build directory as the libcamera library itself.\n \t */\n \tstd::string root = utils::libcameraBuildPath();\n \tif (!root.empty()) {\n", "prefixes": [ "libcamera-devel" ] }