From patchwork Wed Apr 29 15:19:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 3610 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A04C1609D6 for ; Wed, 29 Apr 2020 17:19:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kVAvkomp"; dkim-atps=neutral Received: from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1819C521; Wed, 29 Apr 2020 17:19:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1588173554; bh=ZlR0itfzPUIqBRFcz5nrcbxfS78VpHaR8pTVmxXiSb0=; h=From:To:Cc:Subject:Date:From; b=kVAvkomp/GJ2QsqandTdiZ9IvjuEY56BcbD258hGwPqUcoMLNdU5RIQCBHuMnJtZJ juJpzfHbPTm0jEkQNDctRUgRQtczhdg2UWwgkNun0XA/g0ayNUiUy8RnlPvdPro/t+ 8dj6Hp98TBUTpBHDDx3I5/0ksHKQI6TT4fit/idc= From: Kieran Bingham To: libcamera devel Date: Wed, 29 Apr 2020 16:19:10 +0100 Message-Id: <20200429151910.2341468-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build path comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:19:14 -0000 The comments describe functionality before libcameraBuildPath() was adapted from libcameraPath() to return the root of the build, and described having to take a relative path. This is no longer the case, and the comment is inaccurate. Fix it. Fixes: 1b8ac8473c94 ("libcamera: utils: Adapt libcameraPath to match use cases") Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/ipa_manager.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp index df3786797010..1faa3dd38188 100644 --- a/src/libcamera/ipa_manager.cpp +++ b/src/libcamera/ipa_manager.cpp @@ -114,10 +114,7 @@ IPAManager::IPAManager() /* * When libcamera is used before it is installed, load IPAs from the - * same build directory as the libcamera library itself. This requires - * identifying the path of the libcamera.so, and referencing a relative - * path for the IPA from that point. We need to recurse one level of - * sub-directories to match the build tree. + * same build directory as the libcamera library itself. */ std::string root = utils::libcameraBuildPath(); if (!root.empty()) {