Patch Detail
Show a patch.
GET /api/1.1/patches/3598/?format=api
{ "id": 3598, "url": "https://patchwork.libcamera.org/api/1.1/patches/3598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200428181650.5071-3-laurent.pinchart@ideasonboard.com>", "date": "2020-04-28T18:16:50", "name": "[libcamera-devel,v2,3/3] libcamera: pipeline: vimc: Name camera based on sensor model", "commit_ref": "6ed463911defa512725a521f827e63517c6a6419", "pull_url": null, "state": "accepted", "archived": false, "hash": "0fdcb2139928f9d91211adec833451d12b69b0b3", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3598/mbox/", "series": [ { "id": 845, "url": "https://patchwork.libcamera.org/api/1.1/series/845/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=845", "date": "2020-04-28T18:16:48", "name": "[libcamera-devel,v2,1/3] libcamera: camera_sensor: Add model() function", "version": 2, "mbox": "https://patchwork.libcamera.org/series/845/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3598/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44B1561AD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2020 20:16:55 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0A8D72C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2020 20:16:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oBQs1PVl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588097815;\n\tbh=R6XxqSQ/B86Zp9AbokCmgZ3DWFpwKDroRTx4E9C1PiY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=oBQs1PVl02ecZST1rjwMlU3r4Lz2Gs4FbMjQjoG3YHX4vCzJCRPAodU2x8R30FIU3\n\tHcAvkGyXlYBl220LQkiQKalVXz9fuOTthboOQJVLXueAJRpw+0UvrEaeBe9BP3Vk2k\n\tsEJQHL2i3kJjLQRb3AfCWn6O3m4x4N1xpb9+86og=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 28 Apr 2020 21:16:50 +0300", "Message-Id": "<20200428181650.5071-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "In-Reply-To": "<20200428181650.5071-1-laurent.pinchart@ideasonboard.com>", "References": "<20200428181650.5071-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: vimc: Name\n\tcamera based on sensor model", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 28 Apr 2020 18:16:56 -0000" }, "content": "Use the sensor model to create the camera name. The resulting name\nshould still be \"VIMC Sensor B\", but prepares for support of Sensor A.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 6707c5a07ae6..ccfd7f86d158 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -394,9 +394,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \t\treturn false;\n \n \t/* Create and register the camera. */\n+\tstd::string name{ \"VIMC \" + data->sensor_->model() };\n \tstd::set<Stream *> streams{ &data->stream_ };\n-\tstd::shared_ptr<Camera> camera = Camera::create(this, \"VIMC Sensor B\",\n-\t\t\t\t\t\t\tstreams);\n+\tstd::shared_ptr<Camera> camera = Camera::create(this, name, streams);\n \tregisterCamera(std::move(camera), std::move(data));\n \n \treturn true;\n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }