| Message ID | 20200428181650.5071-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 6ed463911defa512725a521f827e63517c6a6419 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Tue, Apr 28, 2020 at 09:16:50PM +0300, Laurent Pinchart wrote: > Use the sensor model to create the camera name. The resulting name > should still be "VIMC Sensor B", but prepares for support of Sensor A. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/pipeline/vimc/vimc.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp > index 6707c5a07ae6..ccfd7f86d158 100644 > --- a/src/libcamera/pipeline/vimc/vimc.cpp > +++ b/src/libcamera/pipeline/vimc/vimc.cpp > @@ -394,9 +394,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator) > return false; > > /* Create and register the camera. */ > + std::string name{ "VIMC " + data->sensor_->model() }; > std::set<Stream *> streams{ &data->stream_ }; > - std::shared_ptr<Camera> camera = Camera::create(this, "VIMC Sensor B", > - streams); > + std::shared_ptr<Camera> camera = Camera::create(this, name, streams); > registerCamera(std::move(camera), std::move(data)); > > return true; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 6707c5a07ae6..ccfd7f86d158 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -394,9 +394,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator) return false; /* Create and register the camera. */ + std::string name{ "VIMC " + data->sensor_->model() }; std::set<Stream *> streams{ &data->stream_ }; - std::shared_ptr<Camera> camera = Camera::create(this, "VIMC Sensor B", - streams); + std::shared_ptr<Camera> camera = Camera::create(this, name, streams); registerCamera(std::move(camera), std::move(data)); return true;
Use the sensor model to create the camera name. The resulting name should still be "VIMC Sensor B", but prepares for support of Sensor A. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/pipeline/vimc/vimc.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)