Patch Detail
Show a patch.
GET /api/1.1/patches/2842/?format=api
{ "id": 2842, "url": "https://patchwork.libcamera.org/api/1.1/patches/2842/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2842/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200217142609.22837-3-naush@raspberrypi.com>", "date": "2020-02-17T14:26:08", "name": "[libcamera-devel,2/3] libcamera: controls: Specify manual gain units and change exposure units", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "61a55e966a79b23f5efaf6c999b3b6ba4983409b", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2842/mbox/", "series": [ { "id": 679, "url": "https://patchwork.libcamera.org/api/1.1/series/679/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=679", "date": "2020-02-17T14:26:06", "name": "Patchset for libcamera controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/679/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2842/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2842/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n\t[IPv6:2a00:1450:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4B3C617B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2020 15:28:22 +0100 (CET)", "by mail-wr1-x444.google.com with SMTP id r11so19932087wrq.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2020 06:28:22 -0800 (PST)", "from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tp15sm760960wma.40.2020.02.17.06.28.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 06:28:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=A/4b+JCQNP8NQmqirhXCx7H1RDp7oKCdXS8ALhz71PA=;\n\tb=MtT2yP3dSuPPJRNNBM6A29P9p27danVj5cISd05GEX23Za7Ea0urvGwkTxMl9Zx+BZ\n\tNfUk5TzGi/iw37Ol+onBtqObcY5loci/FMTLnf148SKPqvqRI2tZMVPHBKVbbXmONj1L\n\t5uhzuoJwrwz+/GtI+3Vuobvz66uPyrBv9NpcKXxlNJTzD+/PHpN7InqhNFkn3bCRGQSy\n\tbKAkzoyICG1A/OGDONQPrQST3jqkdet8B9Tn0EZDZ1CMvTDLwCFNqNdRhmxOPupfMTOT\n\tvD5I4l/87zh//WjoFe7Qx4o7z1Rzg99sFCN1TFVVTkxPMnG+fWZKnKCSAhzyGJ4zADX6\n\tvxOA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=A/4b+JCQNP8NQmqirhXCx7H1RDp7oKCdXS8ALhz71PA=;\n\tb=hWxnzXu9ubofFb6AckQF84cVzScUMkbe/GpfLB1zVy075+nZKOW1FsxwELwflZ+kwL\n\tDm5nJYOCBOYrc3LeJC7pAhqUOmJRyq5pnW5hdUsF1w6LypqimEyDc1CPOVhFUIqdYjzq\n\trviYe+QFLlHo4LWEN4Nc2i6Uu8jAMeX6rFC8SIEmzmNsEzxI9aMlXraSBjI1YpB8C9OE\n\tulCM3z2VbROL/lTMAjZ1juWIFWZuxalh16TBp4HOG9GRRmeHPDRA5+mWDDNCT+0O/XFZ\n\tVgZOZ66gsR8Af/ujkQwtIyj3ZQxcnpEKX14rfd/n6uGGKLpt4p7I+1yZIPIGgtlhSkP4\n\tKRDg==", "X-Gm-Message-State": "APjAAAVkj7T9pnQ+Ce1Vj1Z6twKNQfmZrxHACHgUc3gLhEDihcxB8UTp\n\tMoPJDf6lxrov+slzAhVYuEvpd43Oei/c4g==", "X-Google-Smtp-Source": "APXvYqw4g4rzPt92O10ZYaOWQO0J+H0uyy7x/Cdfn7bkf4Z1Y7oDtpTZ/yDRpvUiAdcP9Nfhsi23FQ==", "X-Received": "by 2002:a5d:484d:: with SMTP id\n\tn13mr22232422wrs.420.1581949702471; \n\tMon, 17 Feb 2020 06:28:22 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 17 Feb 2020 14:26:08 +0000", "Message-Id": "<20200217142609.22837-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200217142609.22837-1-naush@raspberrypi.com>", "References": "<20200217142609.22837-1-naush@raspberrypi.com>", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: controls: Specify manual\n\tgain units and change exposure units", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 17 Feb 2020 14:28:23 -0000" }, "content": "Use micro-seconds for ManualExposure. This is changed from milli-\nseconds. The latter would not allow very low exposure times.\n\nUse double for ManualGain to allow fractional gain adjustments.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4befec7..33062d6 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -44,10 +44,10 @@ controls:\n \n - ManualExposure:\n type: int32_t\n- description: Specify a fixed exposure time in milli-seconds\n+ description: Specify a fixed exposure time in micro-seconds\n \n - ManualGain:\n- type: int32_t\n- description: Specify a fixed gain parameter\n+ type: double\n+ description: Specify a fixed gain parameter.\n \n ...\n", "prefixes": [ "libcamera-devel", "2/3" ] }