From patchwork Mon Feb 17 14:26:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 2842 Return-Path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D4B3C617B6 for ; Mon, 17 Feb 2020 15:28:22 +0100 (CET) Received: by mail-wr1-x444.google.com with SMTP id r11so19932087wrq.10 for ; Mon, 17 Feb 2020 06:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A/4b+JCQNP8NQmqirhXCx7H1RDp7oKCdXS8ALhz71PA=; b=MtT2yP3dSuPPJRNNBM6A29P9p27danVj5cISd05GEX23Za7Ea0urvGwkTxMl9Zx+BZ NfUk5TzGi/iw37Ol+onBtqObcY5loci/FMTLnf148SKPqvqRI2tZMVPHBKVbbXmONj1L 5uhzuoJwrwz+/GtI+3Vuobvz66uPyrBv9NpcKXxlNJTzD+/PHpN7InqhNFkn3bCRGQSy bKAkzoyICG1A/OGDONQPrQST3jqkdet8B9Tn0EZDZ1CMvTDLwCFNqNdRhmxOPupfMTOT vD5I4l/87zh//WjoFe7Qx4o7z1Rzg99sFCN1TFVVTkxPMnG+fWZKnKCSAhzyGJ4zADX6 vxOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A/4b+JCQNP8NQmqirhXCx7H1RDp7oKCdXS8ALhz71PA=; b=hWxnzXu9ubofFb6AckQF84cVzScUMkbe/GpfLB1zVy075+nZKOW1FsxwELwflZ+kwL Dm5nJYOCBOYrc3LeJC7pAhqUOmJRyq5pnW5hdUsF1w6LypqimEyDc1CPOVhFUIqdYjzq rviYe+QFLlHo4LWEN4Nc2i6Uu8jAMeX6rFC8SIEmzmNsEzxI9aMlXraSBjI1YpB8C9OE ulCM3z2VbROL/lTMAjZ1juWIFWZuxalh16TBp4HOG9GRRmeHPDRA5+mWDDNCT+0O/XFZ VgZOZ66gsR8Af/ujkQwtIyj3ZQxcnpEKX14rfd/n6uGGKLpt4p7I+1yZIPIGgtlhSkP4 KRDg== X-Gm-Message-State: APjAAAVkj7T9pnQ+Ce1Vj1Z6twKNQfmZrxHACHgUc3gLhEDihcxB8UTp MoPJDf6lxrov+slzAhVYuEvpd43Oei/c4g== X-Google-Smtp-Source: APXvYqw4g4rzPt92O10ZYaOWQO0J+H0uyy7x/Cdfn7bkf4Z1Y7oDtpTZ/yDRpvUiAdcP9Nfhsi23FQ== X-Received: by 2002:a5d:484d:: with SMTP id n13mr22232422wrs.420.1581949702471; Mon, 17 Feb 2020 06:28:22 -0800 (PST) Received: from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id p15sm760960wma.40.2020.02.17.06.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 06:28:22 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 17 Feb 2020 14:26:08 +0000 Message-Id: <20200217142609.22837-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200217142609.22837-1-naush@raspberrypi.com> References: <20200217142609.22837-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify manual gain units and change exposure units X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Feb 2020 14:28:23 -0000 Use micro-seconds for ManualExposure. This is changed from milli- seconds. The latter would not allow very low exposure times. Use double for ManualGain to allow fractional gain adjustments. Signed-off-by: Naushir Patuck --- src/libcamera/control_ids.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 4befec7..33062d6 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -44,10 +44,10 @@ controls: - ManualExposure: type: int32_t - description: Specify a fixed exposure time in milli-seconds + description: Specify a fixed exposure time in micro-seconds - ManualGain: - type: int32_t - description: Specify a fixed gain parameter + type: double + description: Specify a fixed gain parameter. ...