Patch Detail
Show a patch.
GET /api/1.1/patches/2763/?format=api
{ "id": 2763, "url": "https://patchwork.libcamera.org/api/1.1/patches/2763/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2763/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200131160846.13084-1-kieran.bingham@ideasonboard.com>", "date": "2020-01-31T16:08:46", "name": "[libcamera-devel,v2] pipeline_handler: Include system header for dev_t", "commit_ref": "b448bfb426067a05d92a51f3ff123898a91ea643", "pull_url": null, "state": "accepted", "archived": false, "hash": "daf788457de666d9d33776af4efb5350c0aa66a3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2763/mbox/", "series": [ { "id": 654, "url": "https://patchwork.libcamera.org/api/1.1/series/654/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=654", "date": "2020-01-31T16:08:46", "name": "[libcamera-devel,v2] pipeline_handler: Include system header for dev_t", "version": 2, "mbox": "https://patchwork.libcamera.org/series/654/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2763/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2763/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE977606E5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jan 2020 17:08:52 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4107A71D;\n\tFri, 31 Jan 2020 17:08:52 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580486932;\n\tbh=VwE3dDNIyBV+lq1ijFymAryrwPVoudK5LtEr8aQ1LiM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=f3/MdxcyyloZ1hMccfgxAnmy4roYqrSS/Nte00bR086yiDFuPEXLU3R68paypOBFN\n\tpya59Idaj1QAXBF/K+4AU+0IBZ+1VQK9CtmvmoTO0epsFnXzgLxuh0+r+0XAAQGHO6\n\t6td6opjsG9lsuTR0Sy5+3Vd2fhz5HZZMyU/ybnd0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMadhavan Krishnan <madhavan.krishnan@linaro.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 31 Jan 2020 16:08:46 +0000", "Message-Id": "<20200131160846.13084-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] pipeline_handler: Include system\n\theader for dev_t", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 31 Jan 2020 16:08:53 -0000" }, "content": "Compiling with gcc 9.2.0-r5 identifies the following compile time\nfailure:\n\nFAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o\nc++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp\nIn file included from ../src/libcamera/camera.cpp:17:\n../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared\n 91 | std::unique_ptr<CameraData> data, dev_t devnum = 0);\n | ^~~~~\n\nChange the sys/sysmacros.h header for the more appropriate sys/types.h.\n\nFixes: effe4d6ced88 (\"libcamera: camera_manager, pipeline_handler: allow retrieving cameras by device numbers\")\n\nReported-by: Madhavan Krishnan <madhavan.krishnan@linaro.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nv2:\n - Added reported-by tag, and reviewed-by tags\n - Removed #include <sys/sysmacros.h>\n\n\n src/libcamera/include/pipeline_handler.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex a6c1e1fbae38..97157dd75c8a 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -12,7 +12,7 @@\n #include <memory>\n #include <set>\n #include <string>\n-#include <sys/sysmacros.h>\n+#include <sys/types.h>\n #include <vector>\n \n #include <ipa/ipa_interface.h>\n", "prefixes": [ "libcamera-devel", "v2" ] }