Patch Detail
Show a patch.
GET /api/1.1/patches/27338/?format=api
{ "id": 27338, "url": "https://patchwork.libcamera.org/api/1.1/patches/27338/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27338/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260708-libipa-algorithms-v5-28-0759d0359f52@ideasonboard.com>", "date": "2026-07-08T15:51:10", "name": "[v5,28/36] ipa: libipa: lsc_polynomial: Remove sensorSize_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dde145bcfa9c356e6da60fedba2fd63929dd809c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27338/mbox/", "series": [ { "id": 6048, "url": "https://patchwork.libcamera.org/api/1.1/series/6048/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6048", "date": "2026-07-08T15:50:42", "name": "ipa: libipa: Introduce libipa algorithms", "version": 5, "mbox": "https://patchwork.libcamera.org/series/6048/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27338/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27338/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B45FFC3336\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2026 15:51:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57ADA66113;\n\tWed, 8 Jul 2026 17:51:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04942660B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2026 17:51:22 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E3C43FE8;\n\tWed, 8 Jul 2026 17:50:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cDqjP+aE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525831;\n\tbh=ZE/FEhl1zjyzhA9H3UC3EUUq0qVCJRaGsJin9VMqjpU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=cDqjP+aEP5h+wrPDDffg5zqs7xo/H6CYbzH6bpbySYLlPxPGFEeiBxGaT1InTtP8r\n\t/5BXl+rkzGcuKskbIpdVQ7BL11ASi0FbefK6j7tkz1fAoqEHaW1JJrBRHnM2qlzHyi\n\tHen0X3r+gRnHMWna9ISzYFy+RZrHB4ffsGYmOfDk=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 08 Jul 2026 17:51:10 +0200", "Subject": "[PATCH v5 28/36] ipa: libipa: lsc_polynomial: Remove sensorSize_", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260708-libipa-algorithms-v5-28-0759d0359f52@ideasonboard.com>", "References": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "In-Reply-To": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3254;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=ZE/FEhl1zjyzhA9H3UC3EUUq0qVCJRaGsJin9VMqjpU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHr3lrEDdOTGwpeHVw6LHcO+sg8GbCdb7icf\n\t1SZPuMxP3SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x6wAKCRByNAaPFqFW\n\tPB/1D/9hv/86Ay5Ex1w31EZeItbXw+oVJ+diVKAGmkONPOmB7GfDZD21beKcXUYQSDqoK7DUXsN\n\toYEcavcHppbWbpEwWzbkeAFOut+j2e36VIBZ8d8aeFLJHnOufYS1EQnpoUyLP8rSsTNF8ovhpQf\n\tQ9W8WHfkCst/jKukXeg2v29SDPem9pEZvF6KAEDVrqMZPOxpWwNq8HyigBi/sSoKS7H2lECga4R\n\tNPnG8dIKtVJSB/wed0e8UkOLY6sdenVEoDO7AgAG+/02o8FP0Zo6VDXy28Jh+wX78bGjGVRKa8R\n\tpDWRZtyQZfYzdulXm77YDZqt67cPGseN9PNYtaOe4zvFs4igoQiVogjCHlzCm/+ximjJKm+DaaW\n\tVZ7tTzXKqpXqryM5lQ+f4hBG0l7M5usIyKhB5usUsLbbwgidQmAFguTqpIJ89CAER7CMrLO4RhO\n\tVssWFGxWVOJE+XBxL15uGY7pgyNKsFIvtk7ZiVX+J7UtwRXu/+Z60bw18IIRMqoM2cbolQRgFui\n\tFgDGxxKhhsTboPMsJX6YoSemFfOe6Q9A7qSVaUQhUglENnPPSLRaHHr2LuaC3TfYTulkyZ4xTIG\n\tAo7ISxIJQmSWP0H15DpPlM9AjzVbp5ayZNEmINUqCQ+A1JJX1oZelWvhCDRT/JPOZkFYxVCDDqE\n\t6AD3U+7+OOWDHXw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensorSize_ field is only used during the init() function and is\nprovided to LscPolynomial using the LscDescriptor type.\n\nThere is no need to store it as a class member and to pass it in\nat class construction time.\n\nRemove it and move the \\todo comment in the LscDescriptor type\ndocumentation.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 6 +-----\n src/ipa/libipa/lsc_base.cpp | 3 +++\n src/ipa/libipa/lsc_polynomial.cpp | 7 -------\n src/ipa/libipa/lsc_polynomial.h | 6 ------\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 26c3e9968072..1d2f8eb1b41b 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control\n \t\timpl_ = std::make_unique<LscTable>();\n \t\tLOG(Lsc, Debug) << \"Using table-based Lsc\";\n \t} else if (type == \"polynomial\") {\n-\t\t/*\n-\t\t * \\todo: Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\timpl_ = std::make_unique<LscPolynomial>(descriptor.sensorSize);\n+\t\timpl_ = std::make_unique<LscPolynomial>();\n \t\tpolynomial_ = true;\n \t\tLOG(Lsc, Debug) << \"Using polynomial Lsc\";\n \t} else {\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 919622c6b951..adc09c15752a 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -78,6 +78,9 @@ void Interpolator<lsc::Components>::\n * \\var LscDescriptor::sensorSize\n * \\brief The physical sensor size. This is the largest frame size used to\n * generate the LSC table. Only used by the polynomial LSC algorithm\n+ *\n+ * \\todo: Most likely the reference frame should be native_size.\n+ * Let's wait how the internal discussions progress.\n */\n \n /**\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex e17ba85448be..c61c85fbf2b2 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)\n * \\sa LscImplementation\n */\n \n-/**\n- * \\fn LscPolynomial::LscPolynomial\n- * \\param[in] sensorSize The physical sensor size\n- *\n- * Construct an LscPolynomial\n- */\n-\n /**\n * \\brief Parse polynomial LSC data\n * \\param[in] sets The tuning file content\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex 2a26db499d68..6d19e46a50b7 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -57,11 +57,6 @@ private:\n \tusing PolynomialComponentsMap = std::map<unsigned int, PolynomialComponents>;\n \n public:\n-\tLscPolynomial(const Size &sensorSize)\n-\t\t: sensorSize_(sensorSize)\n-\t{\n-\t}\n-\n \tint parseLscData(const ValueNode &sets,\n \t\t\t const LscDescriptor &descriptor) override;\n \n@@ -75,7 +70,6 @@ private:\n \t\t\t\t\t Span<const double> yPositions,\n \t\t\t\t\t const Rectangle &cropRectangle);\n \tPolynomialComponentsMap lscData_;\n-\tSize sensorSize_;\n };\n \n } /* namespace ipa */\n", "prefixes": [ "v5", "28/36" ] }