From patchwork Wed Jul 8 15:51:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27338 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B45FFC3336 for ; Wed, 8 Jul 2026 15:51:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 57ADA66113; Wed, 8 Jul 2026 17:51:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cDqjP+aE"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 04942660B3 for ; Wed, 8 Jul 2026 17:51:22 +0200 (CEST) Received: from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E3C43FE8; Wed, 8 Jul 2026 17:50:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783525831; bh=ZE/FEhl1zjyzhA9H3UC3EUUq0qVCJRaGsJin9VMqjpU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cDqjP+aEP5h+wrPDDffg5zqs7xo/H6CYbzH6bpbySYLlPxPGFEeiBxGaT1InTtP8r /5BXl+rkzGcuKskbIpdVQ7BL11ASi0FbefK6j7tkz1fAoqEHaW1JJrBRHnM2qlzHyi Hen0X3r+gRnHMWna9ISzYFy+RZrHB4ffsGYmOfDk= From: Jacopo Mondi Date: Wed, 08 Jul 2026 17:51:10 +0200 Subject: [PATCH v5 28/36] ipa: libipa: lsc_polynomial: Remove sensorSize_ MIME-Version: 1.0 Message-Id: <20260708-libipa-algorithms-v5-28-0759d0359f52@ideasonboard.com> References: <20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com> In-Reply-To: <20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3254; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=ZE/FEhl1zjyzhA9H3UC3EUUq0qVCJRaGsJin9VMqjpU=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHr3lrEDdOTGwpeHVw6LHcO+sg8GbCdb7icf 1SZPuMxP3SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x6wAKCRByNAaPFqFW PB/1D/9hv/86Ay5Ex1w31EZeItbXw+oVJ+diVKAGmkONPOmB7GfDZD21beKcXUYQSDqoK7DUXsN oYEcavcHppbWbpEwWzbkeAFOut+j2e36VIBZ8d8aeFLJHnOufYS1EQnpoUyLP8rSsTNF8ovhpQf Q9W8WHfkCst/jKukXeg2v29SDPem9pEZvF6KAEDVrqMZPOxpWwNq8HyigBi/sSoKS7H2lECga4R NPnG8dIKtVJSB/wed0e8UkOLY6sdenVEoDO7AgAG+/02o8FP0Zo6VDXy28Jh+wX78bGjGVRKa8R pDWRZtyQZfYzdulXm77YDZqt67cPGseN9PNYtaOe4zvFs4igoQiVogjCHlzCm/+ximjJKm+DaaW VZ7tTzXKqpXqryM5lQ+f4hBG0l7M5usIyKhB5usUsLbbwgidQmAFguTqpIJ89CAER7CMrLO4RhO VssWFGxWVOJE+XBxL15uGY7pgyNKsFIvtk7ZiVX+J7UtwRXu/+Z60bw18IIRMqoM2cbolQRgFui FgDGxxKhhsTboPMsJX6YoSemFfOe6Q9A7qSVaUQhUglENnPPSLRaHHr2LuaC3TfYTulkyZ4xTIG Ao7ISxIJQmSWP0H15DpPlM9AjzVbp5ayZNEmINUqCQ+A1JJX1oZelWvhCDRT/JPOZkFYxVCDDqE 6AD3U+7+OOWDHXw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensorSize_ field is only used during the init() function and is provided to LscPolynomial using the LscDescriptor type. There is no need to store it as a class member and to pass it in at class construction time. Remove it and move the \todo comment in the LscDescriptor type documentation. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/ipa/libipa/lsc.cpp | 6 +----- src/ipa/libipa/lsc_base.cpp | 3 +++ src/ipa/libipa/lsc_polynomial.cpp | 7 ------- src/ipa/libipa/lsc_polynomial.h | 6 ------ 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 26c3e9968072..1d2f8eb1b41b 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control impl_ = std::make_unique(); LOG(Lsc, Debug) << "Using table-based Lsc"; } else if (type == "polynomial") { - /* - * \todo: Most likely the reference frame should be native_size. - * Let's wait how the internal discussions progress. - */ - impl_ = std::make_unique(descriptor.sensorSize); + impl_ = std::make_unique(); polynomial_ = true; LOG(Lsc, Debug) << "Using polynomial Lsc"; } else { diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 919622c6b951..adc09c15752a 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -78,6 +78,9 @@ void Interpolator:: * \var LscDescriptor::sensorSize * \brief The physical sensor size. This is the largest frame size used to * generate the LSC table. Only used by the polynomial LSC algorithm + * + * \todo: Most likely the reference frame should be native_size. + * Let's wait how the internal discussions progress. */ /** diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index e17ba85448be..c61c85fbf2b2 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size) * \sa LscImplementation */ -/** - * \fn LscPolynomial::LscPolynomial - * \param[in] sensorSize The physical sensor size - * - * Construct an LscPolynomial - */ - /** * \brief Parse polynomial LSC data * \param[in] sets The tuning file content diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index 2a26db499d68..6d19e46a50b7 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -57,11 +57,6 @@ private: using PolynomialComponentsMap = std::map; public: - LscPolynomial(const Size &sensorSize) - : sensorSize_(sensorSize) - { - } - int parseLscData(const ValueNode &sets, const LscDescriptor &descriptor) override; @@ -75,7 +70,6 @@ private: Span yPositions, const Rectangle &cropRectangle); PolynomialComponentsMap lscData_; - Size sensorSize_; }; } /* namespace ipa */