Patch Detail
Show a patch.
GET /api/1.1/patches/27211/?format=api
{ "id": 27211, "url": "https://patchwork.libcamera.org/api/1.1/patches/27211/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27211/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706-libipa-algorithms-v3-11-968757b038bb@ideasonboard.com>", "date": "2026-07-06T08:01:31", "name": "[v3,11/35] ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "745b1fd64b786ed128fbe450896827271e980848", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27211/mbox/", "series": [ { "id": 6038, "url": "https://patchwork.libcamera.org/api/1.1/series/6038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6038", "date": "2026-07-06T08:01:20", "name": "ipa: libipa: Introduce libipa algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27211/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27211/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA95EC330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 08:02:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 569F066034;\n\tMon, 6 Jul 2026 10:02:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6C966601E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 10:02:04 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62678217B;\n\tMon, 6 Jul 2026 10:01:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ger7K6Cw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324876;\n\tbh=rYGOyJqlg6KGcH57Gl0nXxGuPBsSavnxemzwwosWMBY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=ger7K6CwVDHOE0/wYDJr+4rad9DQcF7YK0MzaByS2du7Q9J2elJLG2zoi1VRXCTW4\n\t3iUQuqxHliecUz2a6bFxs4g7/PWvMQQxvKNrawueWnjFNZdC1tY8g9vBwHaaY4KyOA\n\tqRfXU5HVCbTIJVf0KU3X1iKxUgxY372n4sb8qEl0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 06 Jul 2026 10:01:31 +0200", "Subject": "[PATCH v3 11/35] ipa: libipa: lsc_polynomial: Don't inline\n\tValueNode accessor", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260706-libipa-algorithms-v3-11-968757b038bb@ideasonboard.com>", "References": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "In-Reply-To": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2952;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=BEf1W1AyI5E5rj0wvDTXSlHFS7EeY8EQyX6MdqC3noI=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DwutBe6W0mIArx5GH3l9vgSqG/INojUX+be\n\thlC8nfFp5SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8AAKCRByNAaPFqFW\n\tPOL6EAC0QzdIiqEzbmZYGhxVDGZZnbLby8mSrHJB2u7V8LgGUTcSpfI/lFpiXUPCOdavWJo+gcF\n\toWRCko8MCc5XHrRrhVhgmZIgopYuAGFy4Fgkx5ytHIO/5n2hJeJ0Of3fx95LE79PYUSATdFGjMj\n\tB1zhh9Ce34x3Tqqg7mO4Q7E+qOmLhjEozGt2TB0hqqOXlMlIrSaAbggkvQ3+OK7hR9h6WwwsNqs\n\tPYjsQ5MSD+JHumVlF7HHEJRulT+ve/CDFzf+CY4BV1Qh1wWtwS9aU7wEFxn0CzwC0fbmHGocb6L\n\tPY/6WcazZfeGqYOjjsgyTXTCOyYwnqqI7+ukaCLwCaCqL1q/0WRlNib9s/PASp3lZY4LY8X+rMc\n\tFVomT5jnPt3DdOlWaunF9d89iEpCWUOHQDrYvE+quVUkl0D+HtkW9rhlbkQPc4C7SlZkokc9tHb\n\tmruh7z60rfPbG0EplEGb90bpDQh8NSiPtOwtTo5nXU4NgQqpKAxGrhUOdJ/LUltR6Uql1XiHYbA\n\tK8Q7jowmo862dMQ0ZsUqvFnxbEWxpK2RhyXesi1eMuu7GgWPUX6keFm7jXK0TzgiouE3/++9PWJ\n\tCRuylWVrgkDWkZOHei7mpQ/aRJ01dJm7xY16/0dZgSClRLo7rYKFN7hVarkI8X2ymT4gKN40LRd\n\t9cnE6IMIxGfWYVA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThere's no need to inline the ValueNode::Accessor::get() function for\nLscPolynomial. Move it to from lsc_polynomial.h to lsc_polynomial.cpp.\n\nWhile at it, replace C++-style comments with C-style comments according\nto the libcamera coding style.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_polynomial.cpp | 26 ++++++++++++++++++++++++--\n src/ipa/libipa/lsc_polynomial.h | 24 ------------------------\n 2 files changed, 24 insertions(+), 26 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex f607d86c54c3..00569c2fd160 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -77,5 +77,27 @@ namespace ipa {\n * \\param size The size of the reference image\n */\n \n-} // namespace ipa\n-} // namespace libcamera\n+} /* namespace ipa */\n+\n+#ifndef __DOXYGEN__\n+template<>\n+std::optional<ipa::LscPolynomial>\n+ValueNode::Accessor<ipa::LscPolynomial>::get(const ValueNode &obj) const\n+{\n+\tstd::optional<double> cx = obj[\"cx\"].get<double>();\n+\tstd::optional<double> cy = obj[\"cy\"].get<double>();\n+\tstd::optional<double> k0 = obj[\"k0\"].get<double>();\n+\tstd::optional<double> k1 = obj[\"k1\"].get<double>();\n+\tstd::optional<double> k2 = obj[\"k2\"].get<double>();\n+\tstd::optional<double> k3 = obj[\"k3\"].get<double>();\n+\tstd::optional<double> k4 = obj[\"k4\"].get<double>();\n+\n+\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n+\t\tLOG(LscPolynomial, Error)\n+\t\t\t<< \"Polynomial is missing a parameter\";\n+\n+\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n+}\n+#endif /* __DOXYGEN__ */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex d7d9ae42e360..d52ec86946b1 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -80,28 +80,4 @@ private:\n \n } /* namespace ipa */\n \n-#ifndef __DOXYGEN__\n-\n-template<>\n-struct ValueNode::Accessor<ipa::LscPolynomial> {\n-\tstd::optional<ipa::LscPolynomial> get(const ValueNode &obj) const\n-\t{\n-\t\tstd::optional<double> cx = obj[\"cx\"].get<double>();\n-\t\tstd::optional<double> cy = obj[\"cy\"].get<double>();\n-\t\tstd::optional<double> k0 = obj[\"k0\"].get<double>();\n-\t\tstd::optional<double> k1 = obj[\"k1\"].get<double>();\n-\t\tstd::optional<double> k2 = obj[\"k2\"].get<double>();\n-\t\tstd::optional<double> k3 = obj[\"k3\"].get<double>();\n-\t\tstd::optional<double> k4 = obj[\"k4\"].get<double>();\n-\n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n-\t\t\tLOG(LscPolynomial, Error)\n-\t\t\t\t<< \"Polynomial is missing a parameter\";\n-\n-\t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n-\t}\n-};\n-\n-#endif\n-\n } /* namespace libcamera */\n", "prefixes": [ "v3", "11/35" ] }