From patchwork Mon Jul 6 08:01:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27211 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA95EC330F for ; Mon, 6 Jul 2026 08:02:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 569F066034; Mon, 6 Jul 2026 10:02:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ger7K6Cw"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D6C966601E for ; Mon, 6 Jul 2026 10:02:04 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it [109.113.60.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 62678217B; Mon, 6 Jul 2026 10:01:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783324876; bh=rYGOyJqlg6KGcH57Gl0nXxGuPBsSavnxemzwwosWMBY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ger7K6CwVDHOE0/wYDJr+4rad9DQcF7YK0MzaByS2du7Q9J2elJLG2zoi1VRXCTW4 3iUQuqxHliecUz2a6bFxs4g7/PWvMQQxvKNrawueWnjFNZdC1tY8g9vBwHaaY4KyOA qRfXU5HVCbTIJVf0KU3X1iKxUgxY372n4sb8qEl0= From: Jacopo Mondi Date: Mon, 06 Jul 2026 10:01:31 +0200 Subject: [PATCH v3 11/35] ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor MIME-Version: 1.0 Message-Id: <20260706-libipa-algorithms-v3-11-968757b038bb@ideasonboard.com> References: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> In-Reply-To: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2952; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=BEf1W1AyI5E5rj0wvDTXSlHFS7EeY8EQyX6MdqC3noI=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DwutBe6W0mIArx5GH3l9vgSqG/INojUX+be hlC8nfFp5SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8AAKCRByNAaPFqFW POL6EAC0QzdIiqEzbmZYGhxVDGZZnbLby8mSrHJB2u7V8LgGUTcSpfI/lFpiXUPCOdavWJo+gcF oWRCko8MCc5XHrRrhVhgmZIgopYuAGFy4Fgkx5ytHIO/5n2hJeJ0Of3fx95LE79PYUSATdFGjMj B1zhh9Ce34x3Tqqg7mO4Q7E+qOmLhjEozGt2TB0hqqOXlMlIrSaAbggkvQ3+OK7hR9h6WwwsNqs PYjsQ5MSD+JHumVlF7HHEJRulT+ve/CDFzf+CY4BV1Qh1wWtwS9aU7wEFxn0CzwC0fbmHGocb6L PY/6WcazZfeGqYOjjsgyTXTCOyYwnqqI7+ukaCLwCaCqL1q/0WRlNib9s/PASp3lZY4LY8X+rMc FVomT5jnPt3DdOlWaunF9d89iEpCWUOHQDrYvE+quVUkl0D+HtkW9rhlbkQPc4C7SlZkokc9tHb mruh7z60rfPbG0EplEGb90bpDQh8NSiPtOwtTo5nXU4NgQqpKAxGrhUOdJ/LUltR6Uql1XiHYbA K8Q7jowmo862dMQ0ZsUqvFnxbEWxpK2RhyXesi1eMuu7GgWPUX6keFm7jXK0TzgiouE3/++9PWJ CRuylWVrgkDWkZOHei7mpQ/aRJ01dJm7xY16/0dZgSClRLo7rYKFN7hVarkI8X2ymT4gKN40LRd 9cnE6IMIxGfWYVA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Laurent Pinchart There's no need to inline the ValueNode::Accessor::get() function for LscPolynomial. Move it to from lsc_polynomial.h to lsc_polynomial.cpp. While at it, replace C++-style comments with C-style comments according to the libcamera coding style. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc_polynomial.cpp | 26 ++++++++++++++++++++++++-- src/ipa/libipa/lsc_polynomial.h | 24 ------------------------ 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index f607d86c54c3..00569c2fd160 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -77,5 +77,27 @@ namespace ipa { * \param size The size of the reference image */ -} // namespace ipa -} // namespace libcamera +} /* namespace ipa */ + +#ifndef __DOXYGEN__ +template<> +std::optional +ValueNode::Accessor::get(const ValueNode &obj) const +{ + std::optional cx = obj["cx"].get(); + std::optional cy = obj["cy"].get(); + std::optional k0 = obj["k0"].get(); + std::optional k1 = obj["k1"].get(); + std::optional k2 = obj["k2"].get(); + std::optional k3 = obj["k3"].get(); + std::optional k4 = obj["k4"].get(); + + if (!(cx && cy && k0 && k1 && k2 && k3 && k4)) + LOG(LscPolynomial, Error) + << "Polynomial is missing a parameter"; + + return ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4); +} +#endif /* __DOXYGEN__ */ + +} /* namespace libcamera */ diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index d7d9ae42e360..d52ec86946b1 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -80,28 +80,4 @@ private: } /* namespace ipa */ -#ifndef __DOXYGEN__ - -template<> -struct ValueNode::Accessor { - std::optional get(const ValueNode &obj) const - { - std::optional cx = obj["cx"].get(); - std::optional cy = obj["cy"].get(); - std::optional k0 = obj["k0"].get(); - std::optional k1 = obj["k1"].get(); - std::optional k2 = obj["k2"].get(); - std::optional k3 = obj["k3"].get(); - std::optional k4 = obj["k4"].get(); - - if (!(cx && cy && k0 && k1 && k2 && k3 && k4)) - LOG(LscPolynomial, Error) - << "Polynomial is missing a parameter"; - - return ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4); - } -}; - -#endif - } /* namespace libcamera */