Patch Detail
Show a patch.
GET /api/1.1/patches/27102/?format=api
{ "id": 27102, "url": "https://patchwork.libcamera.org/api/1.1/patches/27102/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27102/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-24-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:46", "name": "[RFC,v1,23/54] libcamera: request: addBuffer(): Remove impl", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2df766226505426c35ec2080346003e77dc935c", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27102/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/1.1/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27102/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27102/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42E76C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D9DC65F5A;\n\tMon, 29 Jun 2026 18:31:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E4CE65F48\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:26 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16F0AE91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZLF6hAKB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750583;\n\tbh=PfZX+7AwvmbjHQf/FCMDuEMyKABil9jpmI84bEgektk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZLF6hAKBM1Zy2yViEkJapMWTjSuMdXysd4zkwI7qijrDyjQ6GIVHeIpFKA8dgQHsb\n\tLRj4veJ38Jc4cjaDlVlY+Vq6lgQvAvq0LRhE0lrZurYC0EBwtkN7POQpXBNYAKmIgr\n\t8+EQ3jI0H9pGqckomNFiS4CPpTSEeT1do1uh9PDM=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 23/54] libcamera: request: addBuffer(): Remove impl", "Date": "Mon, 29 Jun 2026 18:29:46 +0200", "Message-ID": "<20260629163017.863145-24-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the separation of requests and buffers, this function will be removed.\nFor now only the implementation is removed because:\n * there are many external users, and\n * not to hinder changing implementation details.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/request.cpp | 62 +++------------------------------------\n 1 file changed, 4 insertions(+), 58 deletions(-)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 278d993445..8a3934add3 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -446,66 +446,12 @@ const ControlList &Request::metadata() const\n * \\param[in] stream The stream the buffer belongs to\n * \\param[in] buffer The FrameBuffer to add to the request\n * \\param[in] fence The optional fence\n- *\n- * A reference to the buffer is stored in the request. The caller is responsible\n- * for ensuring that the buffer will remain valid until the request complete\n- * callback is called.\n- *\n- * A request can only contain one buffer per stream. If a buffer has already\n- * been added to the request for the same stream, this function returns -EEXIST.\n- *\n- * A Fence can be optionally associated with the \\a buffer.\n- *\n- * When a valid Fence is provided to this function, \\a fence is moved to \\a\n- * buffer and this Request will only be queued to the device once the\n- * fences of all its buffers have been correctly signalled. Ownership of the\n- * fence will only be taken in case of success, otherwise the fence will\n- * be left unmodified.\n- *\n- * If the \\a fence associated with \\a buffer isn't signalled, the request will\n- * fail after a timeout. The buffer will still contain the fence, which\n- * applications must retrieve with FrameBuffer::releaseFence() before the buffer\n- * can be reused in another request. Attempting to add a buffer that still\n- * contains a fence to a request will result in this function returning -EEXIST.\n- *\n- * \\sa FrameBuffer::releaseFence()\n- *\n- * \\return 0 on success or a negative error code otherwise\n- * \\retval -EEXIST The request already contains a buffer for the stream\n- * or the buffer still references a fence\n- * \\retval -EINVAL The buffer does not reference a valid Stream\n */\n-int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,\n-\t\t std::unique_ptr<Fence> &&fence)\n+int Request::addBuffer(const Stream *, FrameBuffer *,\n+\t\t std::unique_ptr<Fence> &&)\n {\n-\tif (!stream) {\n-\t\tLOG(Request, Error) << \"Invalid stream reference\";\n-\t\treturn -EINVAL;\n-\t}\n-\n-\t/*\n-\t * Make sure the fence has been extracted from the buffer\n-\t * to avoid waiting on a stale fence.\n-\t */\n-\tif (buffer->_d()->fence()) {\n-\t\tLOG(Request, Error) << \"Can't add buffer that still references a fence\";\n-\t\treturn -EEXIST;\n-\t}\n-\n-\tauto [it, inserted] = bufferMap_.try_emplace(stream, buffer);\n-\tif (!inserted) {\n-\t\tLOG(Request, Error) << \"FrameBuffer already set for stream\";\n-\t\treturn -EEXIST;\n-\t}\n-\n-\tbuffer->_d()->setRequest(this);\n-\tbuffer->_d()->stream_ = stream;\n-\t_d()->pending_.insert(buffer);\n-\n-\tif (fence && fence->isValid())\n-\t\tbuffer->_d()->setFence(std::move(fence));\n-\n-\treturn 0;\n+\tLOG(Request, Fatal) << \"REMOVED\";\n+\treturn -ENOTSUP;\n }\n \n /**\n", "prefixes": [ "RFC", "v1", "23/54" ] }