Patch Detail
Show a patch.
GET /api/1.1/patches/27080/?format=api
{ "id": 27080, "url": "https://patchwork.libcamera.org/api/1.1/patches/27080/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27080/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-2-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:24", "name": "[RFC,v1,01/54] apps: cam: Simplify buffer reuse", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "abedb4c923c00a130ae19338171903a8bd1f996b", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27080/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/1.1/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27080/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27080/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21CB0C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:30:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E42F65F43;\n\tMon, 29 Jun 2026 18:30:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E14B565F20\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:20 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1815E91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"of/RI3n6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750577;\n\tbh=JF27yKLGb4qUAtPnnKr3EpVMpRXy00p1y6HlStO3Rf0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=of/RI3n6LkyOhrWnPILqP687KyUPyP0wi9cRAo1D3fq3pqGLErtcElj3+PlKkXXT9\n\tG7lFToOg9gSZ6Dm0/IAbU5iB4ugxs/EOdAMO/DSyChnp0W82hjCXIdq57W1JbxQdrA\n\tgwieJLBpE02qvb0UlJdT2LdC3QPMKEaOlM0EXDVM=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 01/54] apps: cam: Simplify buffer reuse", "Date": "Mon, 29 Jun 2026 18:29:24 +0200", "Message-ID": "<20260629163017.863145-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename `CameraSession::sinkRelease()` to `requeueRequest()` and\nremove code duplication by calling it from `processRequest()`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 11 ++++-------\n src/apps/cam/camera_session.h | 2 +-\n 2 files changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 17444a217b..f90800caf8 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -326,7 +326,7 @@ int CameraSession::start()\n \t\t\treturn ret;\n \t\t}\n \n-\t\tsink_->requestProcessed.connect(this, &CameraSession::sinkRelease);\n+\t\tsink_->requestProcessed.connect(this, &CameraSession::requeueRequest);\n \t}\n \n \tallocator_ = std::make_unique<FrameBufferAllocator>(camera_);\n@@ -542,14 +542,11 @@ void CameraSession::processRequest(Request *request)\n \t * If the frame sink holds on the request, we'll requeue it later in the\n \t * complete handler.\n \t */\n-\tif (!requeue)\n-\t\treturn;\n-\n-\trequest->reuse(Request::ReuseBuffers);\n-\tqueueRequest(request);\n+\tif (requeue)\n+\t\trequeueRequest(request);\n }\n \n-void CameraSession::sinkRelease(Request *request)\n+void CameraSession::requeueRequest(Request *request)\n {\n \trequest->reuse(Request::ReuseBuffers);\n \tqueueRequest(request);\ndiff --git a/src/apps/cam/camera_session.h b/src/apps/cam/camera_session.h\nindex 4442fd9b1a..7ad1b77d62 100644\n--- a/src/apps/cam/camera_session.h\n+++ b/src/apps/cam/camera_session.h\n@@ -55,7 +55,7 @@ private:\n \tint queueRequest(libcamera::Request *request);\n \tvoid requestComplete(libcamera::Request *request);\n \tvoid processRequest(libcamera::Request *request);\n-\tvoid sinkRelease(libcamera::Request *request);\n+\tvoid requeueRequest(libcamera::Request *request);\n \n \tconst OptionsParser::Options &options_;\n \tstd::shared_ptr<libcamera::Camera> camera_;\n", "prefixes": [ "RFC", "v1", "01/54" ] }