From patchwork Mon Jun 29 16:29:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27080 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 21CB0C3261 for ; Mon, 29 Jun 2026 16:30:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7E42F65F43; Mon, 29 Jun 2026 18:30:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="of/RI3n6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E14B565F20 for ; Mon, 29 Jun 2026 18:30:20 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A1815E91 for ; Mon, 29 Jun 2026 18:29:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750577; bh=JF27yKLGb4qUAtPnnKr3EpVMpRXy00p1y6HlStO3Rf0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=of/RI3n6LkyOhrWnPILqP687KyUPyP0wi9cRAo1D3fq3pqGLErtcElj3+PlKkXXT9 G7lFToOg9gSZ6Dm0/IAbU5iB4ugxs/EOdAMO/DSyChnp0W82hjCXIdq57W1JbxQdrA gwieJLBpE02qvb0UlJdT2LdC3QPMKEaOlM0EXDVM= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 01/54] apps: cam: Simplify buffer reuse Date: Mon, 29 Jun 2026 18:29:24 +0200 Message-ID: <20260629163017.863145-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename `CameraSession::sinkRelease()` to `requeueRequest()` and remove code duplication by calling it from `processRequest()`. Signed-off-by: Barnabás Pőcze --- src/apps/cam/camera_session.cpp | 11 ++++------- src/apps/cam/camera_session.h | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp index 17444a217b..f90800caf8 100644 --- a/src/apps/cam/camera_session.cpp +++ b/src/apps/cam/camera_session.cpp @@ -326,7 +326,7 @@ int CameraSession::start() return ret; } - sink_->requestProcessed.connect(this, &CameraSession::sinkRelease); + sink_->requestProcessed.connect(this, &CameraSession::requeueRequest); } allocator_ = std::make_unique(camera_); @@ -542,14 +542,11 @@ void CameraSession::processRequest(Request *request) * If the frame sink holds on the request, we'll requeue it later in the * complete handler. */ - if (!requeue) - return; - - request->reuse(Request::ReuseBuffers); - queueRequest(request); + if (requeue) + requeueRequest(request); } -void CameraSession::sinkRelease(Request *request) +void CameraSession::requeueRequest(Request *request) { request->reuse(Request::ReuseBuffers); queueRequest(request); diff --git a/src/apps/cam/camera_session.h b/src/apps/cam/camera_session.h index 4442fd9b1a..7ad1b77d62 100644 --- a/src/apps/cam/camera_session.h +++ b/src/apps/cam/camera_session.h @@ -55,7 +55,7 @@ private: int queueRequest(libcamera::Request *request); void requestComplete(libcamera::Request *request); void processRequest(libcamera::Request *request); - void sinkRelease(libcamera::Request *request); + void requeueRequest(libcamera::Request *request); const OptionsParser::Options &options_; std::shared_ptr camera_;