Patch Detail
Show a patch.
GET /api/1.1/patches/27005/?format=api
{ "id": 27005, "url": "https://patchwork.libcamera.org/api/1.1/patches/27005/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27005/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>", "date": "2026-06-21T00:23:02", "name": "[1/4] libcamera: vector: Replace class with typename", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7cb2a75907e8b24e9a37f2fb425b25d814450c37", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27005/mbox/", "series": [ { "id": 6010, "url": "https://patchwork.libcamera.org/api/1.1/series/6010/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6010", "date": "2026-06-21T00:23:01", "name": "libcamera: vector: Add clamp() function", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6010/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27005/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27005/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7E95C3302\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 21 Jun 2026 00:23:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9219656F7;\n\tSun, 21 Jun 2026 02:23:10 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FB12656DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 21 Jun 2026 02:23:08 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AFDA268;\n\tSun, 21 Jun 2026 02:22:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sxX2dxj0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782001351;\n\tbh=gRlSLhz/FUmkmd9f1DoYgigUOm4rFF5B4LHC0MVmD5c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sxX2dxj05MduNlGKU/dKatRyeE5yBWE4CT4TrBy7AjWzaYn1sDLeOuzX+utiF2lGI\n\t6Y51vQDFvzBErSkCF+mtcJitI7XrI1g608gj8BOeQYDfyLezVYH7FCRmPdUviFyZXQ\n\tJpFY7ya7iuDnSKtHOgzNsH3zss7/MFd7K6Qv8w6k=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 1/4] libcamera: vector: Replace class with typename", "Date": "Sun, 21 Jun 2026 03:23:02 +0300", "Message-ID": "<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260621002305.3763752-1-laurent.pinchart@ideasonboard.com>", "References": "<20260621002305.3763752-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera uses \"typename\" instead of \"class\" to denote template\nparameter types. The vector class uses the latter, replace them with\n\"typename\" for consistency.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/vector.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h\nindex 093efafa8982..04ba5d847b7d 100644\n--- a/include/libcamera/internal/vector.h\n+++ b/include/libcamera/internal/vector.h\n@@ -263,7 +263,7 @@ public:\n \t}\n \n private:\n-\ttemplate<class BinaryOp>\n+\ttemplate<typename BinaryOp>\n \tstatic constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op)\n \t{\n \t\tVector result;\n@@ -274,7 +274,7 @@ private:\n \t\treturn result;\n \t}\n \n-\ttemplate<class U, class BinaryOp>\n+\ttemplate<typename U, typename BinaryOp>\n \tstatic constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op)\n \t{\n \t\tVector result;\n@@ -285,7 +285,7 @@ private:\n \t\treturn result;\n \t}\n \n-\ttemplate<class BinaryOp>\n+\ttemplate<typename BinaryOp>\n \tVector &apply(const Vector &other, BinaryOp op)\n \t{\n \t\tauto itOther = other.data_.begin();\n@@ -295,7 +295,7 @@ private:\n \t\treturn *this;\n \t}\n \n-\ttemplate<class U, class BinaryOp>\n+\ttemplate<typename U, typename BinaryOp>\n \tVector &apply(U scalar, BinaryOp op)\n \t{\n \t\tstd::for_each(data_.begin(), data_.end(),\n", "prefixes": [ "1/4" ] }