[{"id":39205,"web_url":"https://patchwork.libcamera.org/comment/39205/","msgid":"<178204414640.1686300.9690304758256516431@ping.linuxembedded.co.uk>","date":"2026-06-21T12:15:46","subject":"Re: [PATCH 1/4] libcamera: vector: Replace class with typename","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-06-21 01:23:02)\n> libcamera uses \"typename\" instead of \"class\" to denote template\n> parameter types. The vector class uses the latter, replace them with\n> \"typename\" for consistency.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/vector.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h\n> index 093efafa8982..04ba5d847b7d 100644\n> --- a/include/libcamera/internal/vector.h\n> +++ b/include/libcamera/internal/vector.h\n> @@ -263,7 +263,7 @@ public:\n> }\n> \n> private:\n> - template\n> + template\n> static constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op)\n> {\n> Vector result;\n> @@ -274,7 +274,7 @@ private:\n> return result;\n> }\n> \n> - template\n> + template\n> static constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op)\n> {\n> Vector result;\n> @@ -285,7 +285,7 @@ private:\n> return result;\n> }\n> \n> - template\n> + template\n> Vector &apply(const Vector &other, BinaryOp op)\n> {\n> auto itOther = other.data_.begin();\n> @@ -295,7 +295,7 @@ private:\n> return *this;\n> }\n> \n> - template\n> + template\n> Vector &apply(U scalar, BinaryOp op)\n> {\n> std::for_each(data_.begin(), data_.end(),\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD90BC3261\n\tfor ;\n\tSun, 21 Jun 2026 12:15:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8AAC656EE;\n\tSun, 21 Jun 2026 14:15:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5DA261F3F\n\tfor ;\n\tSun, 21 Jun 2026 14:15:49 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8348C236;\n\tSun, 21 Jun 2026 14:15:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yo6P+RkI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782044112;\n\tbh=bPABoXZGBobFPofe0yXSw4UX7jY+bEGEPqIjSg+VX/o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Yo6P+RkIzDL8MTgXOJ1q7tL7ag+fX06WE3ZwLcEBx7P1b5MN+GBfiovfgxZeEqhlP\n\tPtUPNusKvNm5Hq9VujvVOZEncVk/haVe/aQVv+UorW+4sfdJBhL1zIAG+UFGbT7kqJ\n\tdI2vTvBkUdwLMwy8zWBtRsdVMjHm7kjfT+6IBjfg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>","References":"<20260621002305.3763752-1-laurent.pinchart@ideasonboard.com>\n\t<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/4] libcamera: vector: Replace class with typename","From":"Kieran Bingham ","Cc":"","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 21 Jun 2026 13:15:46 +0100","Message-ID":"<178204414640.1686300.9690304758256516431@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39212,"web_url":"https://patchwork.libcamera.org/comment/39212/","msgid":"","date":"2026-06-22T07:53:57","subject":"Re: [PATCH 1/4] libcamera: vector: Replace class with typename","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 21. 2:23 keltezéssel, Laurent Pinchart írta:\n> libcamera uses \"typename\" instead of \"class\" to denote template\n> parameter types. The vector class uses the latter, replace them with\n> \"typename\" for consistency.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/vector.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h\n> index 093efafa8982..04ba5d847b7d 100644\n> --- a/include/libcamera/internal/vector.h\n> +++ b/include/libcamera/internal/vector.h\n> @@ -263,7 +263,7 @@ public:\n> \t}\n> \n> private:\n> -\ttemplate\n> +\ttemplate\n> \tstatic constexpr Vector apply(const Vector &lhs, const Vector &rhs, BinaryOp op)\n> \t{\n> \t\tVector result;\n> @@ -274,7 +274,7 @@ private:\n> \t\treturn result;\n> \t}\n> \n> -\ttemplate\n> +\ttemplate\n> \tstatic constexpr Vector apply(const Vector &lhs, U rhs, BinaryOp op)\n> \t{\n> \t\tVector result;\n> @@ -285,7 +285,7 @@ private:\n> \t\treturn result;\n> \t}\n> \n> -\ttemplate\n> +\ttemplate\n> \tVector &apply(const Vector &other, BinaryOp op)\n> \t{\n> \t\tauto itOther = other.data_.begin();\n> @@ -295,7 +295,7 @@ private:\n> \t\treturn *this;\n> \t}\n> \n> -\ttemplate\n> +\ttemplate\n> \tVector &apply(U scalar, BinaryOp op)\n> \t{\n> \t\tstd::for_each(data_.begin(), data_.end(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D372C3303\n\tfor ;\n\tMon, 22 Jun 2026 07:54:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 055216570E;\n\tMon, 22 Jun 2026 09:54:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB3E3656EE\n\tfor ;\n\tMon, 22 Jun 2026 09:53:58 +0200 (CEST)","from [192.168.33.39] (185.221.141.133.nat.pool.zt.hu\n\t[185.221.141.133])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5AB5E91;\n\tMon, 22 Jun 2026 09:53:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YcKG1WqR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782114801;\n\tbh=l+FDeUMJ6bpP7VvswbHYnYg52iWP043CwfNeoBIk2Gg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=YcKG1WqRLXSgaNVHm87e+ev3GCl0K5lTEcdQozgszVUVMF3SftdiUcDGxlUPtLJgN\n\t4sMIaEIW7qiq0ZYfXTe5eTzoIGgZYr8+Rs6r99xl32RgGlvWjVEJxH8VRLsoBYsbeF\n\t5sEZ11gnC+pezi8TY5+ZouW3fLUlb9bjcWdvLWig=","Message-ID":"","Date":"Mon, 22 Jun 2026 09:53:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/4] libcamera: vector: Replace class with typename","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","References":"<20260621002305.3763752-1-laurent.pinchart@ideasonboard.com>\n\t<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260621002305.3763752-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]