Patch Detail
Show a patch.
GET /api/1.1/patches/26979/?format=api
{ "id": 26979, "url": "https://patchwork.libcamera.org/api/1.1/patches/26979/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26979/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-17-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:33", "name": "[RFC,v1,16/27] libcamera: pipeline_handler: completeBuffer(): Inline and `static`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5ac935592f132e7473c954913e7c02b05d91a94f", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26979/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/1.1/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26979/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26979/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1F2DC330A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 657B965719;\n\tThu, 18 Jun 2026 14:39:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88A5C629E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:51 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A04771894\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rLU528l0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786296;\n\tbh=u5Bzr+zTn6uTqpAfQHEARolODp7/ssqvNRWMyaWTmNE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rLU528l0zQ0Ji7SRLygrwO/Jw6p8T5CnFmKipSNGyRl1W6sD1cKNGkMSDLv/G+ZyU\n\tz7RYOLYzPUcpMKbkoyST/0lCTCd55yCIyQZHSU/7xa+eSCb9IqjUTThGTl2cLFd4XM\n\tEhNUpu7NQp4herEPGHeLTDH6xqZxAlcHWS5ieUQI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 16/27] libcamera: pipeline_handler: completeBuffer():\n\tInline and `static`", "Date": "Thu, 18 Jun 2026 14:38:33 +0200", "Message-ID": "<20260618123844.656396-17-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The function now only calls a method in `Request::Private`, so inline\nit, and also make it `static` since it needs no access to the pipeline\nhandler members.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 7 ++++++-\n src/libcamera/pipeline_handler.cpp | 5 +----\n 2 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 6922ce18ec..cc52c6b045 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -19,6 +19,7 @@\n \n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n+#include \"libcamera/internal/request.h\"\n \n namespace libcamera {\n \n@@ -60,7 +61,11 @@ public:\n \tvoid registerRequest(Request *request);\n \tvoid queueRequest(Request *request);\n \n-\tbool completeBuffer(Request *request, FrameBuffer *buffer);\n+\tstatic bool completeBuffer(Request *request, FrameBuffer *buffer)\n+\t{\n+\t\treturn request->_d()->completeBuffer(buffer);\n+\t}\n+\n \tvoid completeRequest(Request *request);\n \tvoid cancelRequest(Request *request);\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 3d49f85cfa..99f35d1e42 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -544,6 +544,7 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n */\n \n /**\n+ * \\fn PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n * \\brief Complete a buffer for a request\n * \\param[in] request The request the buffer belongs to\n * \\param[in] buffer The buffer that has completed\n@@ -560,10 +561,6 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n * \\return True if all buffers contained in the request have completed, false\n * otherwise\n */\n-bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n-{\n-\treturn request->_d()->completeBuffer(buffer);\n-}\n \n /**\n * \\brief Signal request completion\n", "prefixes": [ "RFC", "v1", "16/27" ] }