From patchwork Thu Jun 18 12:38:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26979 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1F2DC330A for ; Thu, 18 Jun 2026 12:39:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 657B965719; Thu, 18 Jun 2026 14:39:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rLU528l0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 88A5C629E3 for ; Thu, 18 Jun 2026 14:38:51 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A04771894 for ; Thu, 18 Jun 2026 14:38:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786296; bh=u5Bzr+zTn6uTqpAfQHEARolODp7/ssqvNRWMyaWTmNE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=rLU528l0zQ0Ji7SRLygrwO/Jw6p8T5CnFmKipSNGyRl1W6sD1cKNGkMSDLv/G+ZyU z7RYOLYzPUcpMKbkoyST/0lCTCd55yCIyQZHSU/7xa+eSCb9IqjUTThGTl2cLFd4XM EhNUpu7NQp4herEPGHeLTDH6xqZxAlcHWS5ieUQI= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 16/27] libcamera: pipeline_handler: completeBuffer(): Inline and `static` Date: Thu, 18 Jun 2026 14:38:33 +0200 Message-ID: <20260618123844.656396-17-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The function now only calls a method in `Request::Private`, so inline it, and also make it `static` since it needs no access to the pipeline handler members. Signed-off-by: Barnabás Pőcze --- include/libcamera/internal/pipeline_handler.h | 7 ++++++- src/libcamera/pipeline_handler.cpp | 5 +---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index 6922ce18ec..cc52c6b045 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -19,6 +19,7 @@ #include "libcamera/internal/camera_manager.h" #include "libcamera/internal/ipa_manager.h" +#include "libcamera/internal/request.h" namespace libcamera { @@ -60,7 +61,11 @@ public: void registerRequest(Request *request); void queueRequest(Request *request); - bool completeBuffer(Request *request, FrameBuffer *buffer); + static bool completeBuffer(Request *request, FrameBuffer *buffer) + { + return request->_d()->completeBuffer(buffer); + } + void completeRequest(Request *request); void cancelRequest(Request *request); diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 3d49f85cfa..99f35d1e42 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -544,6 +544,7 @@ void PipelineHandler::doQueueRequests(Camera *camera) */ /** + * \fn PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer) * \brief Complete a buffer for a request * \param[in] request The request the buffer belongs to * \param[in] buffer The buffer that has completed @@ -560,10 +561,6 @@ void PipelineHandler::doQueueRequests(Camera *camera) * \return True if all buffers contained in the request have completed, false * otherwise */ -bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer) -{ - return request->_d()->completeBuffer(buffer); -} /** * \brief Signal request completion