Patch Detail
Show a patch.
GET /api/1.1/patches/25618/?format=api
{ "id": 25618, "url": "https://patchwork.libcamera.org/api/1.1/patches/25618/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25618/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251227054042.3836430-1-johannes.schneider@leica-geosystems.com>", "date": "2025-12-27T05:40:40", "name": "fix clang warnings/errors", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "141d74ac8082061ecd79ac9ca86afa0abc8071cd", "submitter": { "id": 254, "url": "https://patchwork.libcamera.org/api/1.1/people/254/?format=api", "name": "SCHNEIDER Johannes", "email": "johannes.schneider@leica-geosystems.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25618/mbox/", "series": [ { "id": 5677, "url": "https://patchwork.libcamera.org/api/1.1/series/5677/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5677", "date": "2025-12-27T05:40:40", "name": "fix clang warnings/errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5677/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25618/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25618/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62045BDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 27 Dec 2025 05:40:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A06DE61F9B;\n\tSat, 27 Dec 2025 06:40:50 +0100 (CET)", "from AS8PR04CU009.outbound.protection.outlook.com\n\t(mail-westeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c201::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6854C61F84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Dec 2025 06:40:49 +0100 (CET)", "from DB3PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:8::30) by\n\tPA1PR06MB9094.eurprd06.prod.outlook.com (2603:10a6:102:45b::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11;\n\tSat, 27 Dec 2025 05:40:45 +0000", "from DB1PEPF0003922F.eurprd03.prod.outlook.com\n\t(2603:10a6:8:0:cafe::78) by DB3PR08CA0017.outlook.office365.com\n\t(2603:10a6:8::30) with Microsoft SMTP Server (version=TLS1_3,\n\tcipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.12 via Frontend\n\tTransport; Sat, 27 Dec 2025 05:40:27 +0000", "from hexagon.com (193.8.40.99) by\n\tDB1PEPF0003922F.mail.protection.outlook.com (10.167.8.102) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.9456.9 via Frontend Transport; Sat, 27 Dec 2025 05:40:44 +0000", "from GEO-H84s5E2W8Pk.lgs-net.com ([10.60.34.93]) by hexagon.com\n\twith\n\tMicrosoft SMTPSVC(10.0.17763.1697); Sat, 27 Dec 2025 06:40:44 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=leica-geosystems.com\n\theader.i=@leica-geosystems.com header.b=\"V3u2imt1\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=FfrR+8PXruvEkY0CLaNjmjCVdPqG/iUItXFoMx8BiJcLmjwAZvQhjKzAu8sy2ZPnItP/zwfOWC/kdbIcd2O0xWgzio22fSYKxVQwKlhI2IDsSelMf6PXtjigv24Re/9KwwykP9iqHdPYluB/E1rWyyUjheDFDyOK0/iIfoHSXw6r9ErNjT0akzK/81kujyQE+NKvyGzD9k9F5lEFq/VtMpXLdm926qY/Kx/jvmntoRT++6wYWeGoleLN3DnHUsH4Zj+31G/4ADPMVYBEqAaomRuJZKeGSMYdWwSuybVjmc5ZHaCTiv5CoBMt19tKNuysRgmC9yIbiDmRUcOjunRZ0w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=GUHHijY0qBtwWobKjsu/um37wU7W7qL/AiVDCkOMnaU=;\n\tb=Iuyov7MT65dMihIsmSt/CMu2BDTpfRMEwPCQwpaXIIHvTLrZ/LnPLJVJUBvwzrurjy0MfE0M0mBsO7kxIK4teMJSUvh4/oPjYyhGfkNA030Vuy6nWIXt0gY6NCeLvFescEEuvl9WiT7PoGWusI5GDFCDxEmYeE0q335KcCcXL1YgAspqD4wh7RxK3rqAC37k2soMsaH0Y80XiZCNwJ+8vg/yCbs1naHkxkfg/Otb/5y6IB1vOkzHfiViare5xmn6EwQatD7obru/9PBTnRsID3bI7RWKMSEmwCnZsr6z+62eseLF8f/g+q0h+8COcYLoAJkyx5UYKXj0mngyEgdsOQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n\t193.8.40.99)\n\tsmtp.rcpttodomain=lists.libcamera.org\n\tsmtp.mailfrom=leica-geosystems.com;\n\tdmarc=pass (p=reject sp=reject pct=100)\n\taction=none header.from=leica-geosystems.com;\n\tdkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=leica-geosystems.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=GUHHijY0qBtwWobKjsu/um37wU7W7qL/AiVDCkOMnaU=;\n\tb=V3u2imt1PlrUJpjyhbvgE/8S2kgVbx7FPoG6riG3HMzlaawqB3d2lYEGPQnGxHcuUwbjIasHM+6l+RHuAVozIMSAglMvYrlGrwYBiQomCe/9Pdvu16J2sdWx2SL8s1dN7SNY5oYJlX8WurFcho/muoZAiBk0rUtT/VqxQ2DnpV0=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 193.8.40.99)\n\tsmtp.mailfrom=leica-geosystems.com; dkim=none (message not signed)\n\theader.d=none; dmarc=pass action=none header.from=leica-geosystems.com;", "Received-SPF": "Pass (protection.outlook.com: domain of leica-geosystems.com\n\tdesignates 193.8.40.99 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=193.8.40.99; helo=hexagon.com; pr=C", "From": "Johannes Schneider <johannes.schneider@leica-geosystems.com>", "To": "libcamera-devel@lists.libcamera.org, stefan.klug@ideasonboard.com,\n\tkieran.bingham@ideasonboard.com", "Cc": "Johannes Schneider <johannes.schneider@leica-geosystems.com>", "Subject": "[PATCH] fix clang warnings/errors", "Date": "Sat, 27 Dec 2025 06:40:40 +0100", "Message-ID": "<20251227054042.3836430-1-johannes.schneider@leica-geosystems.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-OriginalArrivalTime": "27 Dec 2025 05:40:44.0271 (UTC)\n\tFILETIME=[582C6FF0:01DC76F3]", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB1PEPF0003922F:EE_|PA1PR06MB9094:EE_", "X-MS-Office365-Filtering-Correlation-Id": "646baf96-b14a-4329-ffc8-08de450a7ad7", "X-SET-LOWER-SCL-SCANNER": "YES", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|36860700013|82310400026|376014|1800799024; ", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?UFTpqGxZhczYCjl6sdR24pYre/2m?=\n\t=?utf-8?q?1XYP1s/e3dNa44kfJoeZoMVYme/fMUo0LdwvLbjM8UWAw1ooHr3iRkdi?=\n\t=?utf-8?q?cCLH/xcohfUPwJj6p/wruelgRPmxuFk+Swr0B3m3dZjaZ67fsfNuLMBW?=\n\t=?utf-8?q?iVXbCxEwX2hDVNRqwaoJWHJaIuDWqTMpJ9QIZatxR9bGcllvLEmE5cHJ?=\n\t=?utf-8?q?Cj74LplzptETBf6KDVCKxS4rDip1lgx8e+k9LuHkE3WKTiMLwDzHoZ7e?=\n\t=?utf-8?q?nWgya+tnPGzU8ykWeyy4fdgED57T6Ezhp8znY5b8Bo03L1Rbqm7PX9Zo?=\n\t=?utf-8?q?CRciLzpwVOFP4ZhNJdU8QTG+Q7Tn+N6ARhWbUwd82sexegPmp1U0OF+V?=\n\t=?utf-8?q?Hp0kQl/TK02HoRoyaQPoWvsK9+iQk31G/x+ddtddalyhIHaQXxXOGsMS?=\n\t=?utf-8?q?VwuK3VewlWw+hYZDypYKLd5B9aAPsGUZaSCvR8MoY1htq1lG0QXO4OPS?=\n\t=?utf-8?q?AulEEyPWP1hiHffXEszoFXvqt9dKd5aCnHClcJbbhSKMgmvKZrHt2WdJ?=\n\t=?utf-8?q?tcP6VIhDrt45LOqGt2DAFVkqIEiRZSRRAB7Pl4ahNM8+WibiFA7B1/7o?=\n\t=?utf-8?q?iHgT43Xa+AOWjACJJRbF4hrDdj02StdiPsloWmJ8LxXLPdg5ZL1pA1Tp?=\n\t=?utf-8?q?BLR1MwO6eXer1sY0ZVpytIZx+RhTXA67rN4+0WeDUrmpK/kuhoki560o?=\n\t=?utf-8?q?HoKbDJrystZw+A+8CkEqocrSxaJRsfa8+Ms5Q0CAuKJEjtNA6jThujD3?=\n\t=?utf-8?q?L3tq2u/o73LYXBN71DI2HHshowBCaLJexAOK1s9Zwj1m0WvHXiSZFkH9?=\n\t=?utf-8?q?ueEKP5HGO01XaP1Z6TEVjlpyROz2j2eedJQ4IrfbXOo+hbg1n8Cm7Hd7?=\n\t=?utf-8?q?1pzhrIl+rTnIOBrefK6+fLUWgGGrdaDonBhNmdmLc7jxEx5I/F4hEfSz?=\n\t=?utf-8?q?n8ucBgRkTf8Qcfvdfz/NtOqNI6/L6e3vGsiep75+wHdSTlALZNOy1Peg?=\n\t=?utf-8?q?TGZxolDOz+/SUF1hFkhqxTfQwtFPnls3eJBHc6cP5PDSaXdsKmurspuz?=\n\t=?utf-8?q?qPVlKri2zuV39nZHarChOyZq7kIizvam0iHLWTExuY9u1EYvxEtftWm4?=\n\t=?utf-8?q?53/jF0dQN+8LXxUgZB08jZOALO9c1kv9zKemjkLEXg1cuAc5s25+SE03?=\n\t=?utf-8?q?0R47bbSmmALVRbpirbNwgLBE5BKM4Bl7D6guZ3YJZTjwE4NRQengikIX?=\n\t=?utf-8?q?IZ2ezt9dfNziK8DKbjbGQaF+OhWUqkfQ0cLih1nMqtAieKE37VTO/4rz?=\n\t=?utf-8?q?fH1BDHSG88/z3zKb4amPAqkY4RcIANCWPak9K0Uth03TUZA3hkcjUYPy?=\n\t=?utf-8?q?EqfHRgdlBLSj/2sAv99cX8SBNahDx9wOqaEgSp488zerYHLJTmAMJ/iH?=\n\t=?utf-8?q?8biLL2Ohu1u2l+60IB34NBK+Bz+zzFCt8cG17rO4gHyIPUKqGH2ULTXE?=\n\t=?utf-8?q?w4AsdY8hTd3FsIhHKZM/X5XjleBZ0oa5DcZ7hftfLRn25NRljGBgpZzz?=\n\t=?utf-8?q?62kOKGLqMtXHYUcFS1+2X2Wq2xbf+YmJ+mEC9q1GiWSWHRJberSE4pR4?=\n\t=?utf-8?q?ycps3BgO9aZIVUuLS2eopY+QOxjOaZojsQKydQ0=3D?=", "X-Forefront-Antispam-Report": "CIP:193.8.40.99; CTRY:CH; LANG:en; SCL:1; SRV:; \n\tIPV:CAL; SFV:NSPM; H:hexagon.com;\n\tPTR:ahersrvdom51.leica-geosystems.com; \n\tCAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);\n\tDIR:OUT; SFP:1101; ", "X-OriginatorOrg": "leica-geosystems.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Dec 2025 05:40:44.5508\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "646baf96-b14a-4329-ffc8-08de450a7ad7", "X-MS-Exchange-CrossTenant-Id": "1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a;\n\tIp=[193.8.40.99]; \n\tHelo=[hexagon.com]", "X-MS-Exchange-CrossTenant-AuthSource": "DB1PEPF0003922F.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA1PR06MB9094", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Building libcamera with clang raises some warnings-as-errors.\n\nSigned-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>\n---\n\nHoi,\n\nyou could/should consider compiling with clang too ;-)\n\ngruß\nJohannes\n\n---\n include/libcamera/internal/camera_sensor_helper.h | 2 +-\n src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n 3 files changed, 2 insertions(+), 3 deletions(-)\n\n--\n2.43.0", "diff": "diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h\nindex 1e1e479..1b3217b 100644\n--- a/include/libcamera/internal/camera_sensor_helper.h\n+++ b/include/libcamera/internal/camera_sensor_helper.h\n@@ -61,7 +61,7 @@ public:\n\n \tstatic std::vector<CameraSensorHelperFactoryBase *> &factories();\n\n-\tconst std::string &name() const { return name_; };\n+\tconst std::string &name() const { return name_; }\n\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex d6b95fb..368320f 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls,\n \t\t\t\t\t\t const V4L2Request *request)\n {\n \treturn m2m_->capture()->setControls(&ctrls, request);\n-};\n+}\n\n /* -----------------------------------------------------------------------------\n * V4L2M2MConverter\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ca9e850..1437318 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path)\n \t\t\tconst auto ¶ms = algo[\"Dewarp\"];\n\n \t\t\tcanUseDewarper_ = true;\n-\t\t\tMatrix<double, 3, 3> m;\n \t\t\tDewarpParms dp;\n \t\t\tif (params[\"cm\"]) {\n \t\t\t\tconst auto &cm = params[\"cm\"].get<Matrix<double, 3, 3>>();\n", "prefixes": [] }