Patch Detail
Show a patch.
GET /api/1.1/patches/25463/?format=api
{ "id": 25463, "url": "https://patchwork.libcamera.org/api/1.1/patches/25463/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25463/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com>", "date": "2025-12-10T14:39:22", "name": "[v2,6/7] libcamera: mali-c55: Fix sensor size computation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c316a80ebcbf0901c3362311a408f227862c38e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25463/mbox/", "series": [ { "id": 5649, "url": "https://patchwork.libcamera.org/api/1.1/series/5649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5649", "date": "2025-12-10T14:39:16", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25463/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25463/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C456FC326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 14:39:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 208BD61494;\n\tWed, 10 Dec 2025 15:39:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F97D6149E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 15:39:34 +0100 (CET)", "from [192.168.1.106] (mob-5-90-55-146.net.vodafone.it\n\t[5.90.55.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0B3A6DC;\n\tWed, 10 Dec 2025 15:39:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dyz1AhzO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765377573;\n\tbh=WoGI79+nMuTORLewcim5V0njAoU+C2eBVttHuEH4EG0=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=dyz1AhzOugqiHBeqbPh1HF04NzEGNZn8KZGD2K0qV0Y+945TerHrVpBcnuXeRbzKB\n\txAp7bRCNyx1LoPZtKxubsOT83CvmEIdQa1N0hydLmjHOF3/QVHsmDwXlVsqjAH+CcQ\n\t+Z/8RkA1YqGkHjy4qp+kUgnlcPIO47uHJmO5hoNg=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 10 Dec 2025 15:39:22 +0100", "Subject": "[PATCH v2 6/7] libcamera: mali-c55: Fix sensor size computation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com>", "References": "<20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com>", "In-Reply-To": "<20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1118;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=WoGI79+nMuTORLewcim5V0njAoU+C2eBVttHuEH4EG0=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpOYYjhOg7MYF+hyMeDSFRST0bp3YOrVqlSB6+O\n\tgXZshVX+7+JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTmGIwAKCRByNAaPFqFW\n\tPBqBD/95nAnDni1LmH8tfmGjLdGL3qb/phph27MLuZNazeC0BBvjW60hW0pyoEgE6tPDdLBzHNi\n\tP1jhqLOpQ9DGw9YIdrlnQi2Fxq8a0yhoErh/JKc4HX2IBwlWSgp/qF/ULPcGS43mlTFfJLtCy8f\n\tshBqMfIlV1YTPrQZ+8GQsyORoApBFvXnQH2Ji70YyhZskTb4k6Js0a5Cs7rER5jFafvY1373IMV\n\tNQg7mI8s1EleTeaxsT92EKhswtxPSNiQPu+ViV5uewb+vuyFjjLh+SdHy680SfUvHGfs3HyHlDY\n\tnfQda9P0i2rMqxGOdJS7P25NfUMY0ySbX0wmQaT+KeYsCDSt8mRv+degw3Ckb3YLWgE4+CUWbh6\n\t53WnlSfj+cNDESr46jL/6tSHNKkQjqNL68f4oBdPKr0/Uu8ZkSIn4VKONoDuSs1n4xcpeoNGHUy\n\tZstyQCuGKWIhHysS+/kCfUyUSeX1ncdsY108zd68acR362UxchHFCA5fdx8emg+6NhGQEv1B8lv\n\tiipDtc6anLZ8D0GrBVZ+WtgMmCW+6q63md0+C4/nON07oQD/73CJKmnRELx7bWPdgiOF8863WSd\n\tDW+wdKBFOePOqgPNgLCYNOgT2fKeZYjlGmY1utXeZJdfhFUdLB4hH4id+vWks0q4KkYToDCu/nM\n\t2Hv/ZoLLrQ4FLoQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensor size computation routine doesn't work well. Even if a\nmore appriate size for a sensor is available, the largest one is\nalways selected.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nTested-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 83cb10af5d3c0588b25e4a3190f561f09627d239..24369a341db567bc431a4bd2aecfd6865c676347 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -749,7 +749,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast<int>(minSensorSize.height) -\n \t\t\t\t\t static_cast<int>(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n", "prefixes": [ "v2", "6/7" ] }