Patch Detail
Show a patch.
GET /api/1.1/patches/25340/?format=api
{ "id": 25340, "url": "https://patchwork.libcamera.org/api/1.1/patches/25340/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25340/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202-cam-control-override-v3-3-eacab052798d@ideasonboard.com>", "date": "2025-12-02T14:49:28", "name": "[v3,3/5] libcamera: request: Make metadata_ a class instance", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53e0d2fa2a9feb10e4fa6cd92a1e2eb4c7dd9138", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25340/mbox/", "series": [ { "id": 5633, "url": "https://patchwork.libcamera.org/api/1.1/series/5633/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5633", "date": "2025-12-02T14:49:25", "name": "libcamera: ipc: ControlLists without valid idmap break IPC", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5633/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25340/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25340/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C1D5BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 14:49:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0649660C92;\n\tTue, 2 Dec 2025 15:49:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2BDC60C92\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 15:49:36 +0100 (CET)", "from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6907B6DC;\n\tTue, 2 Dec 2025 15:47:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NTQw+vM3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764686842;\n\tbh=IkgEXBKlqck2eAqwvx7gGB84F3eYcFxd62i3UJZmIjM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=NTQw+vM3QY19fMJ15XGnbBpZfTzX9uR5Kix2aEJMZNsJkGGrJTP8OJDT4zsO+f9Zm\n\tfF3qOmZXnNSqSsfZhhThmtHGZL2hEWhX/Ak+CCEQ5afi8lL2j9dYOoMyQrSGa3ba1C\n\tMXog81IAospwhMJJ7/3QMm24KSG0zrxLZZcpiEg4=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 02 Dec 2025 15:49:28 +0100", "Subject": "[PATCH v3 3/5] libcamera: request: Make metadata_ a class instance", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20251202-cam-control-override-v3-3-eacab052798d@ideasonboard.com>", "References": "<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>", "In-Reply-To": "<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, =?utf-8?b?QmFybmFiw6Fz?=\n\t=?utf-8?q?_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2423;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=IkgEXBKlqck2eAqwvx7gGB84F3eYcFxd62i3UJZmIjM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpLvx+rHcDF6RCevOHDUQFHswt8NlAM+YHzqgmE\n\t0prkf+NDPeJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaS78fgAKCRByNAaPFqFW\n\tPItsD/9s/LyhnTQvBKqq+vwN+EU3jJAkxelhOn3TdXbXpk6AKwUWJ9Vo97vR5LH7VhegVqRMI/M\n\tuPE5tpA78YzDljh2XdMLt9sUtmYvunWaEiuJ6HwNzc8iEeGbWyYg/0Ssz063XkGXwVMifyjZg9t\n\tbCdm/K+gB2pXAyyKme4gU3N/jW4Py/ufRya0iQTNzSlOEs6Mv4w0aZES09yBwlFfkWUNfrSCU3N\n\tTwmOj30ovwrmmr3RP+fzYuzhxcpdVSKTXxP1EM4DPND+EqyGy9PdvzRR8yFGxlZ93tfLrB4SXtB\n\taF0Kelx0dUK3AUk2yoJdUsPcxsKOKfpSTH/1ZN0pMIvxdX+u5ttPjaIkwKzm2Y5Yan1/qaoovVq\n\td0nQ9qjKryv6nyaoy3ptaXc23TB4rUYY3jWjTswqAy+zCpNvrlIksfZwZU2b0dCm1ehFB5ytacC\n\twOIvfeqBde7qp41XEqgxxES91S+umlv4HgvNGTaaAzc3Io8GmILg57n1gDyb1uCTNoZdfBF3Cet\n\teUS5f6Zr+KMa2bwk33CkdIBZMnSLF7yM5LPYL+rvxMumSuKd8YuKqyCnr3aN5EKs5tf1DSutHRX\n\t7X12cYEsEpb570EzFLZZY0C2gmqsxQxfistHzBQ7erDQnsRE8HKIWZysKrg/jHE/zoIyLJBgWJm\n\tLnCDEWZdIErvYpg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The metadata_ member variable is a pointer, for no specific reason.\nMake it an instance and simplify the class destructor.\n\nSuggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/request.h | 4 ++--\n src/libcamera/request.cpp | 13 +++++--------\n 2 files changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 643f67cabf5778f7515c0117d06d4e0a3fdec4f8..693097ee9a263be5b4217d5e5393ea93cc30a239 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -36,7 +36,7 @@ public:\n \tCamera *camera() const { return camera_; }\n \tbool hasPendingBuffers() const;\n \n-\tControlList &metadata() { return *metadata_; }\n+\tControlList &metadata() { return metadata_; }\n \n \tbool completeBuffer(FrameBuffer *buffer);\n \tvoid complete();\n@@ -63,7 +63,7 @@ private:\n \tstd::unordered_set<FrameBuffer *> pending_;\n \tstd::map<FrameBuffer *, EventNotifier> notifiers_;\n \tstd::unique_ptr<Timer> timer_;\n-\tControlList *metadata_;\n+\tControlList metadata_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex a661b2f5c8ae9ae2bcbab2dcdceeef7dcb8d0930..0d6c4a0ce9aec5f328c1f66cea43abb37c82544a 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -53,20 +53,17 @@ LOG_DEFINE_CATEGORY(Request)\n /**\n * \\brief Create a Request::Private\n * \\param camera The Camera that creates the request\n+ *\n+ * \\todo Add a validator for metadata controls.\n */\n Request::Private::Private(Camera *camera)\n-\t: camera_(camera), cancelled_(false)\n+\t: camera_(camera), cancelled_(false), metadata_(controls::controls)\n {\n-\t/**\n-\t * \\todo Add a validator for metadata controls.\n-\t */\n-\tmetadata_ = new ControlList(controls::controls);\n }\n \n Request::Private::~Private()\n {\n \tdoCancelRequest();\n-\tdelete metadata_;\n }\n \n /**\n@@ -410,7 +407,7 @@ void Request::reuse(ReuseFlag flags)\n \tstatus_ = RequestPending;\n \n \tcontrols_->clear();\n-\t_d()->metadata_->clear();\n+\t_d()->metadata_.clear();\n }\n \n /**\n@@ -435,7 +432,7 @@ void Request::reuse(ReuseFlag flags)\n */\n const ControlList &Request::metadata() const\n {\n-\treturn *_d()->metadata_;\n+\treturn _d()->metadata_;\n }\n \n /**\n", "prefixes": [ "v3", "3/5" ] }