Patch Detail
Show a patch.
GET /api/1.1/patches/25129/?format=api
{ "id": 25129, "url": "https://patchwork.libcamera.org/api/1.1/patches/25129/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25129/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120233347.5046-6-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:33:29", "name": "[v4,05/23] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dc97ff110d1bd4a28ed89752f81742ba2939ed68", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25129/mbox/", "series": [ { "id": 5600, "url": "https://patchwork.libcamera.org/api/1.1/series/5600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5600", "date": "2025-11-20T23:33:24", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25129/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25129/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 483E5BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:34:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1078C60AA8;\n\tFri, 21 Nov 2025 00:34:05 +0100 (CET)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A82E60A80\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:34:02 +0100 (CET)", "by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-42b3b0d76fcso786271f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:34:02 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:01 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"IAExF8gt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681642; x=1764286442;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=buEiyoEdUhxS/yYb2bTkOxK93yYKxPrmnkJn21GpZJI=;\n\tb=IAExF8gtuOGXKkRgYMSupBcCrq+yf71bbBvgkPXdGNHYAmlILOnhMEUXnHaR/eAftE\n\taV5SRdHLgPZN693tLCGrYMdNdh5Zx2SxqM5c3Jk1tDZmWpyij43ComSc1Mrqw0uoeYOr\n\tVRafTToH0Jmp+GsCPu90Fc2mLP70iYHQ0nzsZM6JRQbu7aNyB2BjMEK48fDC6hffHVg/\n\tJxrdgjc2yt3neTHiuuw7kiCH0PMtBPYQbSOl8a9Se981mFixQioSPcSegBFugOVovKkE\n\tZom0aFlon8NtMzq2mftKEWY99KvA2CpTRoH2CuZGA4za2VBvRa1HOoMSOWQqcTLWuSxu\n\t4RWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681642; x=1764286442;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=buEiyoEdUhxS/yYb2bTkOxK93yYKxPrmnkJn21GpZJI=;\n\tb=AbRYWPrmGJOgxd4NCLiQXl8asrPuNZq1JTOYQiejyTkBZtV4sEh850b3MDdKSWb63t\n\tG50yzVwxhlZXROeOgma5mVp6E4WJRnxE4UfqgH9PzIq4wnHPBQKeGZHeeGLKXHuKW1rE\n\tRe7PDRmScA8B/uAWCDOmK58/jFcJGYYmk+HH67v8Ht+vZw1DnxOIIOTBdwVu3YIEooM2\n\tx0RTDQ47MoxaPu4lxWiAPpd+D6pK/sDEpdXF0f2XZoGfGYMHwko2q24eNB5LAjQKkciD\n\tkw0MqTpvXR/seg8wojcARp2N5UP0PN+3B2gul3KBAxSSF2f/tnfJvaH2XA/8VAbBIZ+R\n\taV6Q==", "X-Gm-Message-State": "AOJu0Ywp4ivU46cs/BD1qfY//jC1goGZUQzUVsXRwuI+9Bvtkpl7NejZ\n\tJqYyfXmiQ79sP09y10uPlppkm1e2hvOYIYEM0whID0Q8hTSbvOO+4pr0OAHS0TWtNFVm6GAxAeC\n\tyArFGnEo=", "X-Gm-Gg": "ASbGnctcBmaPpZVCHSiuLtJENGILGA2bviacW4vI1QSz46zygrHupmy2/TiwyJNl8oD\n\t2Q00Vb05BqYwcmnSj+z0zPKXKqvAhVLBRmMS3x7v2OWWc8xGYNf7VzCIGnAcHLPa8oKqNZB/Pus\n\t1/1+hcjWsKa35anL9bCU+6hbbqt8LbURPFnOnkwx9R6+YNAYobBO2AY73HDRrMaygMxUZencR/J\n\tiFZ5/2Z+F0FF8l/2U4phmLDYb6fbN736HeXRitOCzfEyUE0eo5T3tUSkUkdZe0qmnzkKGQsNSm9\n\tuXj6pnS5e4zc3huEHGfyyRHbC5Z1L5XlGyC3UU8XsUfgTxIGKr2i3jlfh09PgPeNXhKvi5TzZO4\n\t2R07j6AicpC+z7TFKamML+p07jp1bxQbRCAOGonjBDUAOYGaglCGfcSRA6q0ZVG9340Scf0NEzL\n\tlQDFQQMaH9T1XZR4dkrlKo3197jT8yPS4eQZ99k8QVtwJJH6r5/SN87tcja3Lm4qXIm5Q=", "X-Google-Smtp-Source": "AGHT+IHOSsRxc6ytA8Wsy9C3fCVJir6A66FnKF0qRVez7q7V63jqqJ8OS4tq1d/fPHwmBW4bYyi+Hw==", "X-Received": "by 2002:a05:6000:26cb:b0:429:d186:8c49 with SMTP id\n\tffacd0b85a97d-42cc1d526b1mr74872f8f.56.1763681641859; \n\tThu, 20 Nov 2025 15:34:01 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 05/23] libcamera: shaders: Use highp not mediump for float\n\tprecision", "Date": "Thu, 20 Nov 2025 23:33:29 +0000", "Message-ID": "<20251120233347.5046-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "References": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We get better sample resolution with highp instead of mediump.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/RGB.frag | 2 +-\n include/libcamera/internal/shaders/YUV_2_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_3_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag\nindex 4c374ac98..724395894 100644\n--- a/include/libcamera/internal/shaders/RGB.frag\n+++ b/include/libcamera/internal/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag\nindex 1d5d12062..d286f1179 100644\n--- a/include/libcamera/internal/shaders/YUV_2_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag\nindex 8f788e90a..8e3e0b4a5 100644\n--- a/include/libcamera/internal/shaders/YUV_3_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag\nindex b9ef9d41b..3c9e3e397 100644\n--- a/include/libcamera/internal/shaders/YUV_packed.frag\n+++ b/include/libcamera/internal/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex f53f55758..19b13ad08 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nindex 7e35ca88e..aa7a1b004 100644\n--- a/include/libcamera/internal/shaders/bayer_unpacked.frag\n+++ b/include/libcamera/internal/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "v4", "05/23" ] }