Patch Detail
Show a patch.
GET /api/1.1/patches/24872/?format=api
{ "id": 24872, "url": "https://patchwork.libcamera.org/api/1.1/patches/24872/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24872/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028211751.2761420-2-rui.wang@ideasonboard.com>", "date": "2025-10-28T21:17:35", "name": "[v1,02/17] ipa: rkisp1: algorithms: add Denoise ISO helpers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f1cf43e77c90efb5cc8e2c318542276cde57790", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24872/mbox/", "series": [ { "id": 5542, "url": "https://patchwork.libcamera.org/api/1.1/series/5542/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5542", "date": "2025-10-28T21:17:34", "name": "[v1,01/17] ipa: rkisp1: algorithms: add Denoise base class shell", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5542/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24872/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24872/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35946BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 21:18:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E00896082E;\n\tTue, 28 Oct 2025 22:18:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50560606DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 22:18:15 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18820AD0;\n\tTue, 28 Oct 2025 22:16:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NBeQiBAJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761686186;\n\tbh=c4T8Q10S0W1EbJ7ObczOLcOiIE/Idualcu82YoHQtPk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NBeQiBAJO6Ytb3WEYwhV0O/0b93Odjw44AI3KmGtobj1KmUmyWDNky+MuSxKeoym9\n\tvqOi0T5Wvv3BCJhjpsUAYWBzisyWKkiZj+x6XOFx+9sUT24WR/XtYXmGBSkhflKWJB\n\tALDCUGIoM8DKTK+MSs+Umtsu9G8ybyJfotdRKbgw=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 02/17] ipa: rkisp1: algorithms: add Denoise ISO helpers", "Date": "Tue, 28 Oct 2025 17:17:35 -0400", "Message-ID": "<20251028211751.2761420-2-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251028211751.2761420-1-rui.wang@ideasonboard.com>", "References": "<20251028211751.2761420-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide reusable ISO computation and band selection helpers. computeIso\nderives an effective ISO value from the AGC gain (approx ISO = gain * 100).\nselectIsoBand searches the tuning ISO level table for the appropriate band\ngiven the current ISO, falling back to the last band if ISO exceeds all\ndefined ranges.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/denoise.h | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex 8f109db4..d97301f0 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -7,6 +7,8 @@\n \n #pragma once\n \n+#include \"../ipa_context.h\"\n+\n #include \"algorithm.h\"\n \n namespace libcamera {\n@@ -27,8 +29,34 @@ class DenoiseBaseAlgorithm : public ipa::rkisp1::Algorithm\n protected:\n \tDenoiseBaseAlgorithm() = default;\n \t~DenoiseBaseAlgorithm() = default;\n+\n+\tunsigned computeIso(const IPAContext &context,\n+\t\t\t const IPAFrameContext &frameContext) const;\n+\ttemplate<typename LevelContainer>\n+\tint selectIsoBand(unsigned iso, const LevelContainer &levels) const;\n };\n \n+inline unsigned DenoiseBaseAlgorithm::computeIso(const IPAContext &context,\n+\t\t\t\t\t\t const IPAFrameContext &frameContext) const\n+{\n+\tdouble ag = frameContext.agc.gain ? frameContext.agc.gain\n+\t\t\t\t\t : context.activeState.agc.automatic.gain;\n+\treturn static_cast<unsigned>(ag * 100.0 + 0.5);\n+}\n+\n+template<typename LevelContainer>\n+int DenoiseBaseAlgorithm::selectIsoBand(unsigned iso, const LevelContainer &levels) const\n+{\n+\tif (levels.empty())\n+\t\treturn -1;\n+\tint idx = 0;\n+\twhile (idx < static_cast<int>(levels.size()) && iso > levels[idx].maxIso)\n+\t\t++idx;\n+\tif (idx >= static_cast<int>(levels.size()))\n+\t\tidx = static_cast<int>(levels.size()) - 1;\n+\treturn idx;\n+}\n+\n } /* namespace ipa::rkisp1::algorithms */\n \n } /* namespace libcamera */\n", "prefixes": [ "v1", "02/17" ] }