Patch Detail
Show a patch.
GET /api/1.1/patches/22926/?format=api
{ "id": 22926, "url": "https://patchwork.libcamera.org/api/1.1/patches/22926/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22926/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250305135256.801351-2-stanislaw.gruszka@linux.intel.com>", "date": "2025-03-05T13:52:52", "name": "[v6,1/5] libcamera: v4l2_device: add frame start event helpers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1351e769c398557a8b99a452a5d0225895199aa1", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22926/mbox/", "series": [ { "id": 5046, "url": "https://patchwork.libcamera.org/api/1.1/series/5046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5046", "date": "2025-03-05T13:52:51", "name": "libcamera: start frame events changes", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22926/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22926/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54037C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Mar 2025 13:53:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB3096882A;\n\tWed, 5 Mar 2025 14:53:09 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EAFA68778\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Mar 2025 14:53:06 +0100 (CET)", "from orviesa004.jf.intel.com ([10.64.159.144])\n\tby orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t05 Mar 2025 05:53:07 -0800", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.97]) by orviesa004-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:04 -0800" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"R+t6O4OY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1741182788; x=1772718788;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=nPBqYe39DSbUhGu8/lTzGS3nK3uxuajGUEnAh74+aSI=;\n\tb=R+t6O4OYNGVyATXVW+d6CSzXmfwed0nJnNNAnhONjlNzlzl+xPh8STvI\n\tQKObRRvcHjBF500TimhkqSig9ApUoMSNGEyAmwsS/Cf+S3mi7DCnFn0o7\n\t2yjmbCqiRHlErgXu5bYne5/LK715l3i+HwGAFMq7zkAtIsmp1RXuPaq+W\n\tc92OUFAE3ZEbp66tswjVjhHTURgw4koNXBhKbrSkKXCSqKBmygSss8oqY\n\tJk/XXpGNqaqyVGQ/Vd4/V2HCVhfSe+GnngPj3MptoW4DeA7SIhh8vJ53D\n\tpPp97rOlNd/GsoTxxWkLwAHFTJa/VqxozIdglERLH2AYWVoMLARhQcubT Q==;", "X-CSE-ConnectionGUID": [ "wgjlZ5l9RW2k63891m2nVw==", "j+ve62gPQPS1q4neK5ENYQ==" ], "X-CSE-MsgGUID": [ "f1wjlfgCT/eAJLXbzMOK7g==", "qq20bN+LRuqfnxO/i94l5w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11363\"; a=\"53134759\"", "E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"53134759\"", "E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"123735769\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tHans de Goede <hdegoede@redhat.com>", "Subject": "[PATCH v6 1/5] libcamera: v4l2_device: add frame start event helpers", "Date": "Wed, 5 Mar 2025 14:52:52 +0100", "Message-Id": "<20250305135256.801351-2-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add helper to check if frame start event are supported by subdevice.\nSince kernel does not have interface to query supported events\nuse subscribe interface.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> # v3\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # v5\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n include/libcamera/internal/v4l2_device.h | 1 +\n src/libcamera/v4l2_device.cpp | 18 ++++++++++++++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex affe52c2..a647c96a 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -45,6 +45,7 @@ public:\n \tconst std::string &deviceNode() const { return deviceNode_; }\n \tstd::string devicePath() const;\n \n+\tbool supportsFrameStartEvent();\n \tint setFrameStartEnabled(bool enable);\n \tSignal<uint32_t> frameStart;\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 2f65a43a..c3e9cd4a 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -449,6 +449,24 @@ std::string V4L2Device::devicePath() const\n \treturn path;\n }\n \n+/**\n+ * \\brief Check if frame start event is supported\n+ * \\return True if frame start event is supported, false otherwise\n+ */\n+\n+bool V4L2Device::supportsFrameStartEvent()\n+{\n+\tstruct v4l2_event_subscription event{};\n+\tevent.type = V4L2_EVENT_FRAME_SYNC;\n+\n+\tint ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);\n+\tif (ret)\n+\t\treturn false;\n+\n+\tioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);\n+\treturn true;\n+}\n+\n /**\n * \\brief Enable or disable frame start event notification\n * \\param[in] enable True to enable frame start events, false to disable them\n", "prefixes": [ "v6", "1/5" ] }