Patch Detail
Show a patch.
GET /api/1.1/patches/20053/?format=api
{ "id": 20053, "url": "https://patchwork.libcamera.org/api/1.1/patches/20053/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20053/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240517075751.3866269-3-paul.elder@ideasonboard.com>", "date": "2024-05-17T07:57:48", "name": "[v2,2/5] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1 tuning script", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a59e89371d7d295424e4f2bd1d4c2adaa947ebee", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20053/mbox/", "series": [ { "id": 4311, "url": "https://patchwork.libcamera.org/api/1.1/series/4311/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4311", "date": "2024-05-17T07:57:46", "name": "utils: tuning: Add AGC and CCM", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4311/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20053/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20053/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A4E0C322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 May 2024 07:58:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA6EA63486;\n\tFri, 17 May 2024 09:58:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EE7E63481\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 May 2024 09:58:05 +0200 (CEST)", "from neptunite.hamster-moth.ts.net\n\t(h175-177-049-156.catv02.itscom.jp [175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10899475;\n\tFri, 17 May 2024 09:57:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wSP2XI6w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715932676;\n\tbh=T97LdGVMZ9OESu/nLT5DV6BQWH9FEe5lA+L+7R7oqzQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wSP2XI6wd94NmHA3dVx0fEWTl/MQkWXZdY8KX8vonsa4rjx40IEHw8+epNvvM9V5E\n\txzLqk93BX8kA47sUpyKKLSBgHEr4+dEMAWps5jRitXRevh0M/eL9OuDJbxmBJmRitz\n\t3SjbHfRByflMKNDESwiP9b3gdBInIr4d57MDrMdo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 2/5] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1\n\ttuning script", "Date": "Fri, 17 May 2024 16:57:48 +0900", "Message-Id": "<20240517075751.3866269-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240517075751.3866269-1-paul.elder@ideasonboard.com>", "References": "<20240517075751.3866269-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the skeletal AGC module to the rkisp1 tuning script. For now it just\nspits out hardcoded values.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\nChanges in v2:\n- remove hw_rev parameter from the rkisp1 agc tuning module, as the\n tuning file should support both hardware revisions simultaneously\n---\n utils/tuning/rkisp1.py | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex 1cea6ddb5..d216967a8 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -11,6 +11,7 @@ import libtuning as lt\n from libtuning.parsers import YamlParser\n from libtuning.generators import YamlOutput\n from libtuning.modules.lsc import LSCRkISP1\n+from libtuning.modules.agc import AGCRkISP1\n \n tuner = lt.Tuner('RkISP1')\n tuner.add(LSCRkISP1(\n@@ -32,9 +33,10 @@ tuner.add(LSCRkISP1(\n # values. This can also be a custom function.\n smoothing_function=lt.smoothing.MedianBlur(3),\n ))\n+tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n-tuner.set_output_order([LSCRkISP1])\n+tuner.set_output_order([AGCRkISP1, LSCRkISP1])\n \n if __name__ == '__main__':\n sys.exit(tuner.run(sys.argv))\n", "prefixes": [ "v2", "2/5" ] }