[v2,2/5] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1 tuning script
diff mbox series

Message ID 20240517075751.3866269-3-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • utils: tuning: Add AGC and CCM
Related show

Commit Message

Paul Elder May 17, 2024, 7:57 a.m. UTC 
Add the skeletal AGC module to the rkisp1 tuning script. For now it just
spits out hardcoded values.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>

---
Changes in v2:
- remove hw_rev parameter from the rkisp1 agc tuning module, as the
  tuning file should support both hardware revisions simultaneously
---
 utils/tuning/rkisp1.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Dan Scally May 20, 2024, 1:19 p.m. UTC | #1 
Hi Paul

On 17/05/2024 08:57, Paul Elder wrote:
> Add the skeletal AGC module to the rkisp1 tuning script. For now it just
> spits out hardcoded values.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>
> ---
> Changes in v2:
> - remove hw_rev parameter from the rkisp1 agc tuning module, as the
>    tuning file should support both hardware revisions simultaneously
> ---
>   utils/tuning/rkisp1.py | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index 1cea6ddb5..d216967a8 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -11,6 +11,7 @@ import libtuning as lt
>   from libtuning.parsers import YamlParser
>   from libtuning.generators import YamlOutput
>   from libtuning.modules.lsc import LSCRkISP1
> +from libtuning.modules.agc import AGCRkISP1
>   
>   tuner = lt.Tuner('RkISP1')
>   tuner.add(LSCRkISP1(
> @@ -32,9 +33,10 @@ tuner.add(LSCRkISP1(
>             # values.  This can also be a custom function.
>             smoothing_function=lt.smoothing.MedianBlur(3),
>             ))
> +tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))
>   tuner.set_input_parser(YamlParser())
>   tuner.set_output_formatter(YamlOutput())
> -tuner.set_output_order([LSCRkISP1])
> +tuner.set_output_order([AGCRkISP1, LSCRkISP1])
>   
>   if __name__ == '__main__':
>       sys.exit(tuner.run(sys.argv))

Patch
diff mbox series 

diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
index 1cea6ddb5..d216967a8 100755
--- a/utils/tuning/rkisp1.py
+++ b/utils/tuning/rkisp1.py
@@ -11,6 +11,7 @@  import libtuning as lt
 from libtuning.parsers import YamlParser
 from libtuning.generators import YamlOutput
 from libtuning.modules.lsc import LSCRkISP1
+from libtuning.modules.agc import AGCRkISP1
 
 tuner = lt.Tuner('RkISP1')
 tuner.add(LSCRkISP1(
@@ -32,9 +33,10 @@  tuner.add(LSCRkISP1(
           # values.  This can also be a custom function.
           smoothing_function=lt.smoothing.MedianBlur(3),
           ))
+tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))
 tuner.set_input_parser(YamlParser())
 tuner.set_output_formatter(YamlOutput())
-tuner.set_output_order([LSCRkISP1])
+tuner.set_output_order([AGCRkISP1, LSCRkISP1])
 
 if __name__ == '__main__':
     sys.exit(tuner.run(sys.argv))