Patch Detail
Show a patch.
GET /api/1.1/patches/19700/?format=api
{ "id": 19700, "url": "https://patchwork.libcamera.org/api/1.1/patches/19700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240313105645.120317-12-stefan.klug@ideasonboard.com>", "date": "2024-03-13T10:56:43", "name": "[10/12] pipeline: rkisp1: Add more debug logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "017324b6b2f923faa8e29ebda4962c889396ad8e", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19700/mbox/", "series": [ { "id": 4219, "url": "https://patchwork.libcamera.org/api/1.1/series/4219/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4219", "date": "2024-03-13T10:56:32", "name": "Preparation for per-frame-controls and initial tests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4219/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19700/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3385CC32C6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Mar 2024 10:57:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5722C62CAB;\n\tWed, 13 Mar 2024 11:57:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F9CB62C94\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Mar 2024 11:56:55 +0100 (CET)", "from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4422899;\n\tWed, 13 Mar 2024 11:56:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KyQTjJv9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710327392;\n\tbh=uwdYweTAVk/pjADVJ+6SbeTfJDMs2NY3YLaQ6nke5M4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KyQTjJv9ngEUdM/snTKCpkyJvs3lJ8v2I5xo7fJiOeiUGhTOviJoZRbFCyhhUnkiE\n\tubnH4UI7jck75EgtGvt+D6rj6b3qa/eVS9AEstXzn25DiZbwwMUMWOH3oTxyP+iFW7\n\tYZAbouNU3RBtcCMmUj4KDTjANcJOKalhDzfHD/N0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 10/12] pipeline: rkisp1: Add more debug logging", "Date": "Wed, 13 Mar 2024 11:56:43 +0100", "Message-Id": "<20240313105645.120317-12-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240313105645.120317-1-stefan.klug@ideasonboard.com>", "References": "<20240313105645.120317-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n src/ipa/rkisp1/rkisp1.cpp | 2 ++\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 47a6f7b2..f737ba92 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -125,14 +125,14 @@ void Agc::queueRequest(IPAContext &context,\n \t\t\t\t / context.configuration.sensor.lineDuration;\n \n \t\tLOG(RkISP1Agc, Debug)\n-\t\t\t<< \"Set exposure to \" << agc.manual.exposure;\n+\t\t\t<< \"Set manual exposure to \" << agc.manual.exposure;\n \t}\n \n \tconst auto &gain = controls.get(controls::AnalogueGain);\n \tif (gain && !agc.autoEnabled) {\n \t\tagc.manual.gain = *gain;\n \n-\t\tLOG(RkISP1Agc, Debug) << \"Set gain to \" << agc.manual.gain;\n+\t\tLOG(RkISP1Agc, Debug) << \"Set manual gain to \" << agc.manual.gain;\n \t}\n \n \tframeContext.agc.autoEnabled = agc.autoEnabled;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7f8d3bc1..71db2ae7 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -313,6 +313,7 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)\n void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n+\tLOG(IPARkISP1, Debug) << \"queueRequest: \" << frame;\n \n \tfor (auto const &a : algorithms()) {\n \t\tAlgorithm *algo = static_cast<Algorithm *>(a.get());\n@@ -353,6 +354,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n \t\tstats = reinterpret_cast<rkisp1_stat_buffer *>(\n \t\t\tmappedBuffers_.at(bufferId).planes()[0].data());\n \n+\tLOG(IPARkISP1, Debug) << \"processStatsBuffer for frame \" << frame;\n \tframeContext.sensor.exposure =\n \t\tsensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n \tframeContext.sensor.gain =\n", "prefixes": [ "10/12" ] }