From patchwork Wed Mar 13 10:56:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 19700 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3385CC32C6 for ; Wed, 13 Mar 2024 10:57:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5722C62CAB; Wed, 13 Mar 2024 11:57:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KyQTjJv9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F9CB62C94 for ; Wed, 13 Mar 2024 11:56:55 +0100 (CET) Received: from jasper.fritz.box (unknown [IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A4422899; Wed, 13 Mar 2024 11:56:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710327392; bh=uwdYweTAVk/pjADVJ+6SbeTfJDMs2NY3YLaQ6nke5M4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KyQTjJv9ngEUdM/snTKCpkyJvs3lJ8v2I5xo7fJiOeiUGhTOviJoZRbFCyhhUnkiE ubnH4UI7jck75EgtGvt+D6rj6b3qa/eVS9AEstXzn25DiZbwwMUMWOH3oTxyP+iFW7 YZAbouNU3RBtcCMmUj4KDTjANcJOKalhDzfHD/N0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Subject: [PATCH 10/12] pipeline: rkisp1: Add more debug logging Date: Wed, 13 Mar 2024 11:56:43 +0100 Message-Id: <20240313105645.120317-12-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240313105645.120317-1-stefan.klug@ideasonboard.com> References: <20240313105645.120317-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Stefan Klug --- src/ipa/rkisp1/algorithms/agc.cpp | 4 ++-- src/ipa/rkisp1/rkisp1.cpp | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 47a6f7b2..f737ba92 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -125,14 +125,14 @@ void Agc::queueRequest(IPAContext &context, / context.configuration.sensor.lineDuration; LOG(RkISP1Agc, Debug) - << "Set exposure to " << agc.manual.exposure; + << "Set manual exposure to " << agc.manual.exposure; } const auto &gain = controls.get(controls::AnalogueGain); if (gain && !agc.autoEnabled) { agc.manual.gain = *gain; - LOG(RkISP1Agc, Debug) << "Set gain to " << agc.manual.gain; + LOG(RkISP1Agc, Debug) << "Set manual gain to " << agc.manual.gain; } frameContext.agc.autoEnabled = agc.autoEnabled; diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 7f8d3bc1..71db2ae7 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -313,6 +313,7 @@ void IPARkISP1::unmapBuffers(const std::vector &ids) void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls) { IPAFrameContext &frameContext = context_.frameContexts.alloc(frame); + LOG(IPARkISP1, Debug) << "queueRequest: " << frame; for (auto const &a : algorithms()) { Algorithm *algo = static_cast(a.get()); @@ -353,6 +354,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId stats = reinterpret_cast( mappedBuffers_.at(bufferId).planes()[0].data()); + LOG(IPARkISP1, Debug) << "processStatsBuffer for frame " << frame; frameContext.sensor.exposure = sensorControls.get(V4L2_CID_EXPOSURE).get(); frameContext.sensor.gain =