Patch Detail
Show a patch.
GET /api/1.1/patches/1956/?format=api
{ "id": 1956, "url": "https://patchwork.libcamera.org/api/1.1/patches/1956/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1956/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190910090418.30502-3-kieran.bingham@ideasonboard.com>", "date": "2019-09-10T09:04:17", "name": "[libcamera-devel,2/3] test: process: Initialise member variables", "commit_ref": "122892d1bccf0495579918a4fcdf74a793e9fb36", "pull_url": null, "state": "accepted", "archived": false, "hash": "302da4f6569aebf9171d672f7b64f3cf1f116a74", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1956/mbox/", "series": [ { "id": 485, "url": "https://patchwork.libcamera.org/api/1.1/series/485/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=485", "date": "2019-09-10T09:04:15", "name": "test: process: Cleanup to process test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/485/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1956/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1956/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D45A60BCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Sep 2019 11:04:26 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6CDCBB9;\n\tTue, 10 Sep 2019 11:04:25 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568106266;\n\tbh=ngFkpqmcfqibqup+BaoOoYotHpofc0VDc/8GMef3HQ8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vGwUQ24eUIqLiTleRZfJxdESbHtF0gp2Z4YzV4fouNy9uyzH1SD2wjQ7+Lv/PSY3e\n\tZHxLE+BocYe0EC57yGhARfTt6KI758ufZ+GFWgTTWdftqrv1sE3UWci5a+JFIGjK2y\n\tkhAtgxUG0dsxuW+7vJi84DYi2tmmT+lir1/QgYWg=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 10 Sep 2019 10:04:17 +0100", "Message-Id": "<20190910090418.30502-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190910090418.30502-1-kieran.bingham@ideasonboard.com>", "References": "<20190910090418.30502-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] test: process: Initialise member\n\tvariables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 10 Sep 2019 09:04:26 -0000" }, "content": "The ProcessTest() declares member variables but leaves them unitialised.\nSet them appropriately from the constructor.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/process/process_test.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\nindex 701f156b5053..f3cabe0a36c7 100644\n--- a/test/process/process_test.cpp\n+++ b/test/process/process_test.cpp\n@@ -35,6 +35,7 @@ class ProcessTest : public Test\n {\n public:\n \tProcessTest()\n+\t\t: exitStatus_(Process::NotExited), exitCode_(-1)\n \t{\n \t}\n \n", "prefixes": [ "libcamera-devel", "2/3" ] }