Patch Detail
Show a patch.
GET /api/1.1/patches/19282/?format=api
{ "id": 19282, "url": "https://patchwork.libcamera.org/api/1.1/patches/19282/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19282/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231206004425.18189-1-laurent.pinchart@ideasonboard.com>", "date": "2023-12-06T00:44:25", "name": "[libcamera-devel] test: gstreamer: Fix indentation in comments", "commit_ref": "d61104fa7b50d6421109d302ead08c0af62c73df", "pull_url": null, "state": "accepted", "archived": false, "hash": "833b671f5403b3018f1f4caf2bde3468d3c9d2c0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19282/mbox/", "series": [ { "id": 4103, "url": "https://patchwork.libcamera.org/api/1.1/series/4103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4103", "date": "2023-12-06T00:44:25", "name": "[libcamera-devel] test: gstreamer: Fix indentation in comments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19282/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19282/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6ED98C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Dec 2023 00:44:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88561629DF;\n\tWed, 6 Dec 2023 01:44:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34F0C61D9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Dec 2023 01:44:19 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A010D14DC;\n\tWed, 6 Dec 2023 01:43:38 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701823461;\n\tbh=8zOYB9Hwz6hQpcIuv+vR0cXrmD7dT0iMiTrBlt8s16A=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=q27q84wQDPPozBm0X22l8XbDR2jHaNLMjfXi5gwCML00s7fifLeEYx66UIIkUE3Wj\n\tljMwCR32cGhO0j2bYPh06kWTIV0q4s1WzX0iOOC7YHUMs4jAedlVyqAY5VeYIdTYvU\n\tN55NTZBGFXgmNxadiS7EwzMy+bk4ri2bFYpIHzCgofrb8oeuzMktRqpcTUk5zAEvdh\n\tMyXhiTw8t4LaiEmMngRsxENZoKMG6qNdaoZWqlq6+l17qPMDeljwu6Tlh1I7gtAwh+\n\tEU28qE7pXqhxFPK06drtm2D4RCyLpnhLd9gFYUlfgwx01LKGAYLcyUOOtvlkyNZAFW\n\tjod52L2PD2GHA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701823418;\n\tbh=8zOYB9Hwz6hQpcIuv+vR0cXrmD7dT0iMiTrBlt8s16A=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=D+58pYrXT9rY8K0PeS0XLm058ECn6s/TU4GVTdt9tsIE6SclcqhGDiqnp4QJsqST1\n\t57+Y6IT59gTCJfdY2s8qRNszshT/N4qsODhA0VRUaun8fGuUV5dcvztd4+7Lj5WvDR\n\t4sqoHO8ttnUrgw+wA/Pns4CeUJur3zUI+Ad3WMPc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"D+58pYrX\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Dec 2023 02:44:25 +0200", "Message-ID": "<20231206004425.18189-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] test: gstreamer: Fix indentation in\n\tcomments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A couple of comments are mis-indented in the gstreamer unit test. Fix\nthem, and reflow the text while at it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/gstreamer/gstreamer_test.cpp | 23 +++++++++++------------\n 1 file changed, 11 insertions(+), 12 deletions(-)\n\n\nbase-commit: 4eba2dc73c096d037a8a6390ff4a91ebbf1cedd4", "diff": "diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\nindex 6ad0c15cd0e2..091f7bf70288 100644\n--- a/test/gstreamer/gstreamer_test.cpp\n+++ b/test/gstreamer/gstreamer_test.cpp\n@@ -31,15 +31,14 @@ GstreamerTest::GstreamerTest(unsigned int numStreams)\n \t: pipeline_(nullptr), libcameraSrc_(nullptr)\n {\n \t/*\n-\t* GStreamer by default spawns a process to run the\n-\t* gst-plugin-scanner helper. If libcamera is compiled with ASan\n-\t* enabled, and as GStreamer is most likely not, this causes the\n-\t* ASan link order check to fail when gst-plugin-scanner\n-\t* dlopen()s the plugin as many libraries will have already been\n-\t* loaded by then. Fix this issue by disabling spawning of a\n-\t* child helper process when scanning the build directory for\n-\t* plugins.\n-\t*/\n+\t * GStreamer by default spawns a process to run the gst-plugin-scanner\n+\t * helper. If libcamera is compiled with ASan enabled, and as GStreamer\n+\t * is most likely not, this causes the ASan link order check to fail\n+\t * when gst-plugin-scanner dlopen()s the plugin as many libraries will\n+\t * have already been loaded by then. Fix this issue by disabling\n+\t * spawning of a child helper process when scanning the build directory\n+\t * for plugins.\n+\t */\n \tgst_registry_fork_set_enabled(false);\n \n \t/* Initialize GStreamer */\n@@ -53,9 +52,9 @@ GstreamerTest::GstreamerTest(unsigned int numStreams)\n \t}\n \n \t/*\n-\t* Remove the system libcamera plugin, if any, and add the\n-\t* plugin from the build directory.\n-\t*/\n+\t * Remove the system libcamera plugin, if any, and add the plugin from\n+\t * the build directory.\n+\t */\n \tGstRegistry *registry = gst_registry_get();\n \tg_autoptr(GstPlugin) plugin = gst_registry_lookup(registry, \"libgstlibcamera.so\");\n \tif (plugin)\n", "prefixes": [ "libcamera-devel" ] }