From patchwork Wed Dec 6 00:44:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 19282 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6ED98C31E9 for ; Wed, 6 Dec 2023 00:44:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 88561629DF; Wed, 6 Dec 2023 01:44:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1701823461; bh=8zOYB9Hwz6hQpcIuv+vR0cXrmD7dT0iMiTrBlt8s16A=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=q27q84wQDPPozBm0X22l8XbDR2jHaNLMjfXi5gwCML00s7fifLeEYx66UIIkUE3Wj ljMwCR32cGhO0j2bYPh06kWTIV0q4s1WzX0iOOC7YHUMs4jAedlVyqAY5VeYIdTYvU N55NTZBGFXgmNxadiS7EwzMy+bk4ri2bFYpIHzCgofrb8oeuzMktRqpcTUk5zAEvdh MyXhiTw8t4LaiEmMngRsxENZoKMG6qNdaoZWqlq6+l17qPMDeljwu6Tlh1I7gtAwh+ EU28qE7pXqhxFPK06drtm2D4RCyLpnhLd9gFYUlfgwx01LKGAYLcyUOOtvlkyNZAFW jod52L2PD2GHA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 34F0C61D9C for ; Wed, 6 Dec 2023 01:44:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D+58pYrX"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A010D14DC; Wed, 6 Dec 2023 01:43:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701823418; bh=8zOYB9Hwz6hQpcIuv+vR0cXrmD7dT0iMiTrBlt8s16A=; h=From:To:Cc:Subject:Date:From; b=D+58pYrXT9rY8K0PeS0XLm058ECn6s/TU4GVTdt9tsIE6SclcqhGDiqnp4QJsqST1 57+Y6IT59gTCJfdY2s8qRNszshT/N4qsODhA0VRUaun8fGuUV5dcvztd4+7Lj5WvDR 4sqoHO8ttnUrgw+wA/Pns4CeUJur3zUI+Ad3WMPc= To: libcamera-devel@lists.libcamera.org Date: Wed, 6 Dec 2023 02:44:25 +0200 Message-ID: <20231206004425.18189-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] test: gstreamer: Fix indentation in comments X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A couple of comments are mis-indented in the gstreamer unit test. Fix them, and reflow the text while at it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- test/gstreamer/gstreamer_test.cpp | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) base-commit: 4eba2dc73c096d037a8a6390ff4a91ebbf1cedd4 diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp index 6ad0c15cd0e2..091f7bf70288 100644 --- a/test/gstreamer/gstreamer_test.cpp +++ b/test/gstreamer/gstreamer_test.cpp @@ -31,15 +31,14 @@ GstreamerTest::GstreamerTest(unsigned int numStreams) : pipeline_(nullptr), libcameraSrc_(nullptr) { /* - * GStreamer by default spawns a process to run the - * gst-plugin-scanner helper. If libcamera is compiled with ASan - * enabled, and as GStreamer is most likely not, this causes the - * ASan link order check to fail when gst-plugin-scanner - * dlopen()s the plugin as many libraries will have already been - * loaded by then. Fix this issue by disabling spawning of a - * child helper process when scanning the build directory for - * plugins. - */ + * GStreamer by default spawns a process to run the gst-plugin-scanner + * helper. If libcamera is compiled with ASan enabled, and as GStreamer + * is most likely not, this causes the ASan link order check to fail + * when gst-plugin-scanner dlopen()s the plugin as many libraries will + * have already been loaded by then. Fix this issue by disabling + * spawning of a child helper process when scanning the build directory + * for plugins. + */ gst_registry_fork_set_enabled(false); /* Initialize GStreamer */ @@ -53,9 +52,9 @@ GstreamerTest::GstreamerTest(unsigned int numStreams) } /* - * Remove the system libcamera plugin, if any, and add the - * plugin from the build directory. - */ + * Remove the system libcamera plugin, if any, and add the plugin from + * the build directory. + */ GstRegistry *registry = gst_registry_get(); g_autoptr(GstPlugin) plugin = gst_registry_lookup(registry, "libgstlibcamera.so"); if (plugin)