Patch Detail
Show a patch.
GET /api/1.1/patches/18897/?format=api
{ "id": 18897, "url": "https://patchwork.libcamera.org/api/1.1/patches/18897/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18897/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230728124907.3113-1-david.plowman@raspberrypi.com>", "date": "2023-07-28T12:49:07", "name": "[libcamera-devel] ipa: rpi: vc4: Make the StatisticsPtr construction clearer", "commit_ref": "58e501c71c47e57f02afde1bd296a037038cd6d5", "pull_url": null, "state": "accepted", "archived": false, "hash": "6f581221a8b90eb416e7921b04bb31831403f779", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18897/mbox/", "series": [ { "id": 3992, "url": "https://patchwork.libcamera.org/api/1.1/series/3992/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3992", "date": "2023-07-28T12:49:07", "name": "[libcamera-devel] ipa: rpi: vc4: Make the StatisticsPtr construction clearer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3992/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18897/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18897/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 925CCBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jul 2023 12:49:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17C12627E7;\n\tFri, 28 Jul 2023 14:49:12 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C427627E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jul 2023 14:49:10 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-3fbc6ab5ff5so21472445e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jul 2023 05:49:10 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:2bce:64d6:1a5c:49a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10-20020a7bca4a000000b003fbc0a49b57sm4172430wml.6.2023.07.28.05.49.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 28 Jul 2023 05:49:09 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690548552;\n\tbh=1QXIx9FP1MWCbdfHuDhzCu8895bNXH46pqHI5chDZDY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=T6+gwqE6BeJq+gmYWaa+UpMG1RghBuRWVhogIBoopD6Y4pOadMV1B/TMuSabgp87e\n\t+CqYbOWc3u1dwXTQcRWNHmjKYrh5yIn2fBpGEo7Oasv/Ts+AQMgK/APexEYBPflod8\n\tqkim8ms4IF8CfeV4VIxbuXPR4bmTzcpwmKl5nlTvbfxjV+9ugKjR6AoxjlmWq9xMqu\n\tDDPzHeMdFF3jbn24LhWTeq3gP0EE9N0fPxKWpDMo/eHvoYooh4b6BHIrXBCFXdhCu3\n\tgTjsOh8Eq+vHdTEXeLLoyyjY8jXHhTM7MnGAr1R9LgfOu7eeUn6+bLjPl2hDs36jlO\n\tYVFwr9qtqzctw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1690548549; x=1691153349;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=d3cbvxALgbn6iZkOYzCdFl4NX2MrJHJdAtD2Z9Bz8rU=;\n\tb=Idu08aOj3uT36IKoh4161/CzXqn2es+KwJbGeVZ6Hq1UM3TSKytISauvj+rsfnp5Nn\n\taS/l2lYzW6NiKjXOaWVHovU1rTZK1DK/XIgmtsNnRN5tGGDVTpZ8hpU+VP1/xc77MkxF\n\ttNhTIjIaweqqvxy/XLDbmC42SR+V0e3KnjZV1tjt1slH1etu8jpYPafMEC35NGo0DYkA\n\t/qUTyzjIIM0g//hQN9zFezn37ZOKoJ8MHu6o3SiWit351D1F16++Au7WeT3lFy4w9Xdi\n\t96c/1w9DYpuwXQazFXeayv3pZxLHhDrXhLdtMHFW+b5Jm9FVcGlP96sLjNBX1AJ3WWFU\n\tZrAA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Idu08aOj\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1690548549; x=1691153349;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=d3cbvxALgbn6iZkOYzCdFl4NX2MrJHJdAtD2Z9Bz8rU=;\n\tb=ZDy2BTMzAOKoQBMBzIqnAKb73rOZL/amrhgJmcp5Sux+rtqTUJ5hmRpjNKEiuTWJN6\n\tAJmOjTw/XupYe4H7wOHz/aCGYthfGA1MMSX9chL/adGnKvDrbmZgzBggh6ud4Cq5ySpn\n\twv8eq+xifw3q9vV93bzO15c+fxh78uOArW1xTaaKPR+52ckiLo5N5ohDFtKl8l1zhubX\n\te30wKtTbPIEQ6JV45gD1QxSV5iUE9syZ5mbrGtg77z8vlHJlA8c+w58kQSvmxi8FwOJf\n\teh6K8D11C5jgcwBxPo7fR6rkVlM8glT+uLeLqUJqJVDHN7y7ZCmL5pVpOPXv7QRZesED\n\t//eA==", "X-Gm-Message-State": "ABy/qLZEG6nC8mGMuKBLlLEOby0PWHHg3fwSBxM/x7ydmW+hpxEXDrjJ\n\tuSiJbUP+fwgf5fyCNTXDHqVZY6XNSH5HOWFafD4=", "X-Google-Smtp-Source": "APBJJlEX4dwwmv7mp45ZlPQknhdP/k+FU0oudZRmQ/IQoHG3KW1OGDBYAEgjrtJIOJ7XWlvw4lOigw==", "X-Received": "by 2002:a1c:cc08:0:b0:3fb:adc0:609b with SMTP id\n\th8-20020a1ccc08000000b003fbadc0609bmr1761352wmb.13.1690548549572; \n\tFri, 28 Jul 2023 05:49:09 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 28 Jul 2023 13:49:07 +0100", "Message-Id": "<20230728124907.3113-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: rpi: vc4: Make the StatisticsPtr\n\tconstruction clearer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "StatisticsPtr is a shared pointer, so the use of std::make_unique to\ncreate it was a bit confusing. Use std::make_shared instead.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/vc4/vc4.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex 789a345f..3eea40a6 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -191,7 +191,7 @@ RPiController::StatisticsPtr IpaVc4::platformProcessStats(Span<uint8_t> mem)\n \tusing namespace RPiController;\n \n \tconst bcm2835_isp_stats *stats = reinterpret_cast<bcm2835_isp_stats *>(mem.data());\n-\tStatisticsPtr statistics = std::make_unique<Statistics>(Statistics::AgcStatsPos::PreWb,\n+\tStatisticsPtr statistics = std::make_shared<Statistics>(Statistics::AgcStatsPos::PreWb,\n \t\t\t\t\t\t\t\tStatistics::ColourStatsPos::PostLsc);\n \tconst Controller::HardwareConfig &hw = controller_.getHardwareConfig();\n \tunsigned int i;\n", "prefixes": [ "libcamera-devel" ] }