From patchwork Fri Jul 28 12:49:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 18897 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 925CCBDC71 for ; Fri, 28 Jul 2023 12:49:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 17C12627E7; Fri, 28 Jul 2023 14:49:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1690548552; bh=1QXIx9FP1MWCbdfHuDhzCu8895bNXH46pqHI5chDZDY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=T6+gwqE6BeJq+gmYWaa+UpMG1RghBuRWVhogIBoopD6Y4pOadMV1B/TMuSabgp87e +CqYbOWc3u1dwXTQcRWNHmjKYrh5yIn2fBpGEo7Oasv/Ts+AQMgK/APexEYBPflod8 qkim8ms4IF8CfeV4VIxbuXPR4bmTzcpwmKl5nlTvbfxjV+9ugKjR6AoxjlmWq9xMqu DDPzHeMdFF3jbn24LhWTeq3gP0EE9N0fPxKWpDMo/eHvoYooh4b6BHIrXBCFXdhCu3 gTjsOh8Eq+vHdTEXeLLoyyjY8jXHhTM7MnGAr1R9LgfOu7eeUn6+bLjPl2hDs36jlO YVFwr9qtqzctw== Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C427627E6 for ; Fri, 28 Jul 2023 14:49:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Idu08aOj"; dkim-atps=neutral Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fbc6ab5ff5so21472445e9.1 for ; Fri, 28 Jul 2023 05:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1690548549; x=1691153349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d3cbvxALgbn6iZkOYzCdFl4NX2MrJHJdAtD2Z9Bz8rU=; b=Idu08aOj3uT36IKoh4161/CzXqn2es+KwJbGeVZ6Hq1UM3TSKytISauvj+rsfnp5Nn aS/l2lYzW6NiKjXOaWVHovU1rTZK1DK/XIgmtsNnRN5tGGDVTpZ8hpU+VP1/xc77MkxF tNhTIjIaweqqvxy/XLDbmC42SR+V0e3KnjZV1tjt1slH1etu8jpYPafMEC35NGo0DYkA /qUTyzjIIM0g//hQN9zFezn37ZOKoJ8MHu6o3SiWit351D1F16++Au7WeT3lFy4w9Xdi 96c/1w9DYpuwXQazFXeayv3pZxLHhDrXhLdtMHFW+b5Jm9FVcGlP96sLjNBX1AJ3WWFU ZrAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690548549; x=1691153349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d3cbvxALgbn6iZkOYzCdFl4NX2MrJHJdAtD2Z9Bz8rU=; b=ZDy2BTMzAOKoQBMBzIqnAKb73rOZL/amrhgJmcp5Sux+rtqTUJ5hmRpjNKEiuTWJN6 AJmOjTw/XupYe4H7wOHz/aCGYthfGA1MMSX9chL/adGnKvDrbmZgzBggh6ud4Cq5ySpn wv8eq+xifw3q9vV93bzO15c+fxh78uOArW1xTaaKPR+52ckiLo5N5ohDFtKl8l1zhubX e30wKtTbPIEQ6JV45gD1QxSV5iUE9syZ5mbrGtg77z8vlHJlA8c+w58kQSvmxi8FwOJf eh6K8D11C5jgcwBxPo7fR6rkVlM8glT+uLeLqUJqJVDHN7y7ZCmL5pVpOPXv7QRZesED //eA== X-Gm-Message-State: ABy/qLZEG6nC8mGMuKBLlLEOby0PWHHg3fwSBxM/x7ydmW+hpxEXDrjJ uSiJbUP+fwgf5fyCNTXDHqVZY6XNSH5HOWFafD4= X-Google-Smtp-Source: APBJJlEX4dwwmv7mp45ZlPQknhdP/k+FU0oudZRmQ/IQoHG3KW1OGDBYAEgjrtJIOJ7XWlvw4lOigw== X-Received: by 2002:a1c:cc08:0:b0:3fb:adc0:609b with SMTP id h8-20020a1ccc08000000b003fbadc0609bmr1761352wmb.13.1690548549572; Fri, 28 Jul 2023 05:49:09 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:2bce:64d6:1a5c:49a2]) by smtp.gmail.com with ESMTPSA id m10-20020a7bca4a000000b003fbc0a49b57sm4172430wml.6.2023.07.28.05.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 05:49:09 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Fri, 28 Jul 2023 13:49:07 +0100 Message-Id: <20230728124907.3113-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: rpi: vc4: Make the StatisticsPtr construction clearer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" StatisticsPtr is a shared pointer, so the use of std::make_unique to create it was a bit confusing. Use std::make_shared instead. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Kieran Bingham --- src/ipa/rpi/vc4/vc4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index 789a345f..3eea40a6 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -191,7 +191,7 @@ RPiController::StatisticsPtr IpaVc4::platformProcessStats(Span mem) using namespace RPiController; const bcm2835_isp_stats *stats = reinterpret_cast(mem.data()); - StatisticsPtr statistics = std::make_unique(Statistics::AgcStatsPos::PreWb, + StatisticsPtr statistics = std::make_shared(Statistics::AgcStatsPos::PreWb, Statistics::ColourStatsPos::PostLsc); const Controller::HardwareConfig &hw = controller_.getHardwareConfig(); unsigned int i;