Patch Detail
Show a patch.
GET /api/1.1/patches/18713/?format=api
{ "id": 18713, "url": "https://patchwork.libcamera.org/api/1.1/patches/18713/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18713/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230606-alphabetical-order-v1-1-3c9c12a1a332@skidata.com>", "date": "2023-06-06T14:18:05", "name": "[libcamera-devel] libipa: camera_sensor_helper: restore alphabetical order", "commit_ref": "0a37c203da58b3c23c011d8233c16c6063e3cb86", "pull_url": null, "state": "accepted", "archived": false, "hash": "07760777185aa2444e57c1d54e9b3ea1665fed12", "submitter": { "id": 163, "url": "https://patchwork.libcamera.org/api/1.1/people/163/?format=api", "name": "Benjamin Bara", "email": "bbara93@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18713/mbox/", "series": [ { "id": 3910, "url": "https://patchwork.libcamera.org/api/1.1/series/3910/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3910", "date": "2023-06-06T14:18:05", "name": "[libcamera-devel] libipa: camera_sensor_helper: restore alphabetical order", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3910/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18713/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18713/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C4DBC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jun 2023 14:18:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 583C362892;\n\tTue, 6 Jun 2023 16:18:33 +0200 (CEST)", "from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n\t[IPv6:2a00:1450:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 374A362709\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jun 2023 16:18:32 +0200 (CEST)", "by mail-ej1-x62d.google.com with SMTP id\n\ta640c23a62f3a-9745baf7c13so769625366b.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jun 2023 07:18:32 -0700 (PDT)", "from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id\n\ty11-20020a17090629cb00b009660e775691sm5584983eje.151.2023.06.06.07.18.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jun 2023 07:18:31 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686061113;\n\tbh=6kjYPFWDqu0qWLzGs7fTYChKouJpCyqsTx2sLHMIss4=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=23WF/YY/Fe3/uA3eyJuxhYamBYSadJ5JoLr9d8DyQcQvaOC04RTj9PFLIG1LTvJxe\n\tnjtMBJa+GcLlQQMB/AgSZQjwuoEj1XR/mhOVe9Rw/rKMU0M2qZ96cO109ZUTtbykms\n\tif35zQoeSIULoGw4mYxe/YUx0iwwcgeZ9MpeburAmUI65THrdqGjdlZJy0e+CbGib2\n\tmdWV2oQBSxvtCkNAZUfxxfSd695qH+CazmcJnJ1V11sXhucFULBhxlT/IcxP65pij9\n\tsQ+13H5L9gdDEwu6nNrRUEeXKAhdrKIQ6NB1vxntjl/u9v4AlcRB4bw0fLXsUl3AXd\n\toPuLwPwNd5c5A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20221208; t=1686061111; x=1688653111;\n\th=cc:to:message-id:content-transfer-encoding:mime-version:subject\n\t:date:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8DzEek0auqhjI79qj8Pv42RS2ixBpOMVzaEJgX0rlLM=;\n\tb=F7nWr/Judu1eKl+pHhpld4cjJUfK+G1MsRp7ysuWqPBdDe/A/s717s2ZirfqS07B4B\n\tvySEsYF+KAZRlN3fB/xEzQqmzj8BGXQXKq5P7f0fP5UEGOflpk2IXAM6teJsYQ3QyBjU\n\tXkDk9GLYqArN5P7KTmGYk7b48NOKMg6akC8Wn64+I3rzdbuPhga57rk7UrfYrqAteEvj\n\trFHDRyjKR7Rleysa70XmElmMqGnh19rabli+D+OdBp9rnmnQyUqinkkjfvOaAts7sHK0\n\tNXglgzdMXp1zNdoGG4GItDRblwu6IA2qUxKdizxwj/y6Hiql8cbdmJgVHetyZGcZrfZn\n\tkKcw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"F7nWr/Ju\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686061111; x=1688653111;\n\th=cc:to:message-id:content-transfer-encoding:mime-version:subject\n\t:date:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=8DzEek0auqhjI79qj8Pv42RS2ixBpOMVzaEJgX0rlLM=;\n\tb=OjJRlPsFEADzbjd6v/JnnImBxIUqKHJB7s+M5+Wv7nffrWdzK41Tvvw5pdNIqdAY3d\n\t6h/20jW3i+jsXjWroPSFIfr7pfGFBLwmflI6P6c6PdABgaTPrT7slxN+sOulvXMbfbOA\n\tNxnLgGKTVrUaKlF8J209SypKOi+bxzI6ozJ0i4X3jTG8un0qWRBbFBBsLbsuGIl8rk3U\n\ty8eDb4XOZuMjaF0jC64eZjvhizNWWzjYNV+rF0d5eYjlI6zjaYQG7dQEEbZzpmZw95UK\n\twKNkrzSMtLR5GxabHROC4uB4pSxtUQW1wnwz3/h9oX7HM/UjlLnCfCVfYDEhlKb2Xkmg\n\tVEiA==", "X-Gm-Message-State": "AC+VfDzqRxnw+8PZRDIykvF1zYgwn+grr7kMe0X3XnvXljzzgi66baha\n\td/pAeopkgyFvSSK03N4QCFw=", "X-Google-Smtp-Source": "ACHHUZ5o7hswgb6Ozi6YoZlMmAMlnyUBYzv32nX99qGBO+YBwwqRjkI/7FSMF+j60W+oHVjUKpWztg==", "X-Received": "by 2002:a17:907:7b88:b0:94e:cf72:8147 with SMTP id\n\tne8-20020a1709077b8800b0094ecf728147mr3082228ejc.48.1686061111260; \n\tTue, 06 Jun 2023 07:18:31 -0700 (PDT)", "Date": "Tue, 06 Jun 2023 16:18:05 +0200", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20230606-alphabetical-order-v1-1-3c9c12a1a332@skidata.com>", "X-B4-Tracking": "v=1; b=H4sIABxAf2QC/x2NwQqDMBAFf0X23IVEqbT9ldLDJj6bBRtlI1IQ/\n\t72xx2EYZqcCUxR6NDsZNi065wr+0lBMkt9gHSpT69rO9a5nmZYkAatGmXi2AcYQ34Ub7tfRg2o\n\tYpICDSY7pTD9SVtgpFsOo3//t+TqOH9Xwycl9AAAA", "To": "libcamera-devel@lists.libcamera.org", "X-Mailer": "b4 0.12.2", "Subject": "[libcamera-devel] [PATCH] libipa: camera_sensor_helper: restore\n\talphabetical order", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Benjamin Bara via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Benjamin Bara <bbara93@gmail.com>", "Cc": "Benjamin Bara <benjamin.bara@skidata.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Benjamin Bara <benjamin.bara@skidata.com>\n\nFixes: 7d5b38e2ef41 (\"libipa: camera_sensor_helper: Add IMX327 helper\")\nReported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Benjamin Bara <benjamin.bara@skidata.com>\n---\nUnfortunately missed to keep the alphabetical order as mentioned by\nLaurent.\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\n\n---\nbase-commit: a0271e72a86da5796891795565f43f20f7024a8d\nchange-id: 20230606-alphabetical-order-ea13b8e95f1e\n\nBest regards,", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 2eebd7ab..f0ecc383 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -428,11 +428,6 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n \n-class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n-{\n-};\n-REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n-\n class CameraSensorHelperImx296 : public CameraSensorHelper\n {\n public:\n@@ -444,6 +439,11 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n \n+class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\n", "prefixes": [ "libcamera-devel" ] }