Patch Detail
Show a patch.
GET /api/1.1/patches/1848/?format=api
{ "id": 1848, "url": "https://patchwork.libcamera.org/api/1.1/patches/1848/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1848/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190818011329.14499-12-laurent.pinchart@ideasonboard.com>", "date": "2019-08-18T01:13:26", "name": "[libcamera-devel,11/14] android: camera_hal_manager: Remove unused close() method", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b9b1a63d90d349ce5ffea665747d6fb2a2140c2d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1848/mbox/", "series": [ { "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/series/464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=464", "date": "2019-08-18T01:13:15", "name": "Assorted fixes for Android camera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1848/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1848/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD1CC61E16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:44 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E2C151C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:44 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566090824;\n\tbh=2D6Je0AOyo9melpLTWk7Ye1dlCCxtrM+8W6fKGrzoa0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tiOq+0iie2K9sQ1gSfs8ek3ocRcxBScqi42rG3LfGs0Vuvy7cl0GpoCu0zmr6OLLh\n\tUHJdwxg5f/vTGwsSDVzWE2qFRv8ioGFIFotHdPl2tHR3RA30wxnFTbwrzlXUjP2Qeo\n\tuXH/7MTm8d0OAeaWPRq8CY1+gIJRk5eeHMHcA0Eg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Aug 2019 04:13:26 +0300", "Message-Id": "<20190818011329.14499-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "References": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 11/14] android: camera_hal_manager: Remove\n\tunused close() method", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 18 Aug 2019 01:13:46 -0000" }, "content": "The CameraHalManager::close() method isn't used, remove it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_hal_manager.cpp | 10 +---------\n src/android/camera_hal_manager.h | 1 -\n 2 files changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 063080a0746b..a1ffb3713d7e 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -25,7 +25,7 @@ LOG_DECLARE_CATEGORY(HAL);\n * and spawns its own thread where libcamera related events are dispatched to.\n * It wraps the libcamera CameraManager operations and provides helpers for the\n * camera_module_t operations, to retrieve the number of cameras in the system,\n- * their static information and to open and close camera devices.\n+ * their static information and to open camera devices.\n */\n \n CameraHalManager::~CameraHalManager()\n@@ -109,14 +109,6 @@ CameraProxy *CameraHalManager::open(unsigned int id,\n \treturn proxy;\n }\n \n-int CameraHalManager::close(CameraProxy *proxy)\n-{\n-\tproxy->close();\n-\tLOG(HAL, Info) << \"Close camera '\" << proxy->id() << \"'\";\n-\n-\treturn 0;\n-}\n-\n unsigned int CameraHalManager::numCameras() const\n {\n \treturn cameraManager_->cameras().size();\ndiff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 502115cf056f..c23abd1c00af 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -29,7 +29,6 @@ public:\n \tint init();\n \n \tCameraProxy *open(unsigned int id, const hw_module_t *module);\n-\tint close(CameraProxy *proxy);\n \n \tunsigned int numCameras() const;\n \tint getCameraInfo(unsigned int id, struct camera_info *info);\n", "prefixes": [ "libcamera-devel", "11/14" ] }