From patchwork Sun Aug 18 01:13:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1848 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AD1CC61E16 for ; Sun, 18 Aug 2019 03:13:44 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E2C151C for ; Sun, 18 Aug 2019 03:13:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566090824; bh=2D6Je0AOyo9melpLTWk7Ye1dlCCxtrM+8W6fKGrzoa0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tiOq+0iie2K9sQ1gSfs8ek3ocRcxBScqi42rG3LfGs0Vuvy7cl0GpoCu0zmr6OLLh UHJdwxg5f/vTGwsSDVzWE2qFRv8ioGFIFotHdPl2tHR3RA30wxnFTbwrzlXUjP2Qeo uXH/7MTm8d0OAeaWPRq8CY1+gIJRk5eeHMHcA0Eg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sun, 18 Aug 2019 04:13:26 +0300 Message-Id: <20190818011329.14499-12-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> References: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 11/14] android: camera_hal_manager: Remove unused close() method X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2019 01:13:46 -0000 The CameraHalManager::close() method isn't used, remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/android/camera_hal_manager.cpp | 10 +--------- src/android/camera_hal_manager.h | 1 - 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp index 063080a0746b..a1ffb3713d7e 100644 --- a/src/android/camera_hal_manager.cpp +++ b/src/android/camera_hal_manager.cpp @@ -25,7 +25,7 @@ LOG_DECLARE_CATEGORY(HAL); * and spawns its own thread where libcamera related events are dispatched to. * It wraps the libcamera CameraManager operations and provides helpers for the * camera_module_t operations, to retrieve the number of cameras in the system, - * their static information and to open and close camera devices. + * their static information and to open camera devices. */ CameraHalManager::~CameraHalManager() @@ -109,14 +109,6 @@ CameraProxy *CameraHalManager::open(unsigned int id, return proxy; } -int CameraHalManager::close(CameraProxy *proxy) -{ - proxy->close(); - LOG(HAL, Info) << "Close camera '" << proxy->id() << "'"; - - return 0; -} - unsigned int CameraHalManager::numCameras() const { return cameraManager_->cameras().size(); diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h index 502115cf056f..c23abd1c00af 100644 --- a/src/android/camera_hal_manager.h +++ b/src/android/camera_hal_manager.h @@ -29,7 +29,6 @@ public: int init(); CameraProxy *open(unsigned int id, const hw_module_t *module); - int close(CameraProxy *proxy); unsigned int numCameras() const; int getCameraInfo(unsigned int id, struct camera_info *info);