Patch Detail
Show a patch.
GET /api/1.1/patches/1840/?format=api
{ "id": 1840, "url": "https://patchwork.libcamera.org/api/1.1/patches/1840/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1840/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190818011329.14499-4-laurent.pinchart@ideasonboard.com>", "date": "2019-08-18T01:13:18", "name": "[libcamera-devel,03/14] qcam: Remove double stop of the camera manager", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c29c11e76f2c70b1959791f09d1de45195b68963", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1840/mbox/", "series": [ { "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/series/464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=464", "date": "2019-08-18T01:13:15", "name": "Assorted fixes for Android camera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1840/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1840/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5058761927\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:41 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E967951C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:40 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566090821;\n\tbh=n8k4rxyGHyNhVlMeZCxR/E2C+eK05yCYzNFBEdQIJf0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=C5v9FjmU80qrkKIeCmlbJO185obXeQTyulgFJTN3ApglfjDPeRC4K5PXE/9vVO6Ym\n\tya5chm3e00QTYwz7zLyJBNK3vNACjvgAXAuVDvGzHuX1Witx/QAq2138REnWVNGHjY\n\t0woPVP7fF6zTt2osx8FRwQdj6jA3Kqr/274BLdeM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Aug 2019 04:13:18 +0300", "Message-Id": "<20190818011329.14499-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "References": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/14] qcam: Remove double stop of the\n\tcamera manager", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 18 Aug 2019 01:13:41 -0000" }, "content": "The camera manager is stopped both in the destructor of the MainWindow\nclass and in the main() function. This double stop isn't needed, remove\nthe former and keep the latter as the manager is started in the main()\nfunction.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex dcb653e81a29..33fde8b10fd8 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -51,8 +51,6 @@ MainWindow::~MainWindow()\n \t\tcamera_->release();\n \t\tcamera_.reset();\n \t}\n-\n-\tCameraManager::instance()->stop();\n }\n \n void MainWindow::updateTitle()\n", "prefixes": [ "libcamera-devel", "03/14" ] }