From patchwork Sun Aug 18 01:13:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1840 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5058761927 for ; Sun, 18 Aug 2019 03:13:41 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E967951C for ; Sun, 18 Aug 2019 03:13:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566090821; bh=n8k4rxyGHyNhVlMeZCxR/E2C+eK05yCYzNFBEdQIJf0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=C5v9FjmU80qrkKIeCmlbJO185obXeQTyulgFJTN3ApglfjDPeRC4K5PXE/9vVO6Ym ya5chm3e00QTYwz7zLyJBNK3vNACjvgAXAuVDvGzHuX1Witx/QAq2138REnWVNGHjY 0woPVP7fF6zTt2osx8FRwQdj6jA3Kqr/274BLdeM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sun, 18 Aug 2019 04:13:18 +0300 Message-Id: <20190818011329.14499-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> References: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 03/14] qcam: Remove double stop of the camera manager X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2019 01:13:41 -0000 The camera manager is stopped both in the destructor of the MainWindow class and in the main() function. This double stop isn't needed, remove the former and keep the latter as the manager is started in the main() function. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/qcam/main_window.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp index dcb653e81a29..33fde8b10fd8 100644 --- a/src/qcam/main_window.cpp +++ b/src/qcam/main_window.cpp @@ -51,8 +51,6 @@ MainWindow::~MainWindow() camera_->release(); camera_.reset(); } - - CameraManager::instance()->stop(); } void MainWindow::updateTitle()