Patch Detail
Show a patch.
GET /api/1.1/patches/1838/?format=api
{ "id": 1838, "url": "https://patchwork.libcamera.org/api/1.1/patches/1838/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1838/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190818011329.14499-2-laurent.pinchart@ideasonboard.com>", "date": "2019-08-18T01:13:16", "name": "[libcamera-devel,01/14] libcamera: device_enumerator: Print media device name in error message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a766c98692006b87ee2634248aae83458860bda0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1838/mbox/", "series": [ { "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/series/464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=464", "date": "2019-08-18T01:13:15", "name": "Assorted fixes for Android camera HAL", "version": 1, "mbox": "https://patchwork.libcamera.org/series/464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1838/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1838/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DA3560BE5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:40 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FE3151C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Aug 2019 03:13:40 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566090820;\n\tbh=EtA2zifYgF6BN90UB7nIsX8Hx2plVerw6hPUqCtqL1Y=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=upve5TIHRU6XOifIKfA/zJnWwryR8gBhuzSdCqw6kPQnn/1fCZVtQNXnirDy71Z8N\n\tBqotifBL5980koZEzI8hCVsIEMxTUzgeivRxWS98+GCa42HoiucFdQFcbiQpWTEn7q\n\tXIuD/8SXdbW3LkFZvdRqcpOW9CkrCwVFHBlj+I3w=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Aug 2019 04:13:16 +0300", "Message-Id": "<20190818011329.14499-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "References": "<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 01/14] libcamera: device_enumerator: Print\n\tmedia device name in error message", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 18 Aug 2019 01:13:40 -0000" }, "content": "The device enumerator logs an error message when a media device is\nremoved while still in use. Add the device name to the message to help\ndebugging.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 6fcbae76b64e..60c918f0e26f 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -166,7 +166,8 @@ DeviceEnumerator::~DeviceEnumerator()\n \tfor (std::shared_ptr<MediaDevice> media : devices_) {\n \t\tif (media->busy())\n \t\t\tLOG(DeviceEnumerator, Error)\n-\t\t\t\t<< \"Removing media device while still in use\";\n+\t\t\t\t<< \"Removing media device \" << media->deviceNode()\n+\t\t\t\t<< \" while still in use\";\n \t}\n }\n \n", "prefixes": [ "libcamera-devel", "01/14" ] }