From patchwork Sun Aug 18 01:13:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1838 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DA3560BE5 for ; Sun, 18 Aug 2019 03:13:40 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FE3151C for ; Sun, 18 Aug 2019 03:13:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566090820; bh=EtA2zifYgF6BN90UB7nIsX8Hx2plVerw6hPUqCtqL1Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=upve5TIHRU6XOifIKfA/zJnWwryR8gBhuzSdCqw6kPQnn/1fCZVtQNXnirDy71Z8N BqotifBL5980koZEzI8hCVsIEMxTUzgeivRxWS98+GCa42HoiucFdQFcbiQpWTEn7q XIuD/8SXdbW3LkFZvdRqcpOW9CkrCwVFHBlj+I3w= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sun, 18 Aug 2019 04:13:16 +0300 Message-Id: <20190818011329.14499-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> References: <20190818011329.14499-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 01/14] libcamera: device_enumerator: Print media device name in error message X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2019 01:13:40 -0000 The device enumerator logs an error message when a media device is removed while still in use. Add the device name to the message to help debugging. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/libcamera/device_enumerator.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index 6fcbae76b64e..60c918f0e26f 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -166,7 +166,8 @@ DeviceEnumerator::~DeviceEnumerator() for (std::shared_ptr media : devices_) { if (media->busy()) LOG(DeviceEnumerator, Error) - << "Removing media device while still in use"; + << "Removing media device " << media->deviceNode() + << " while still in use"; } }