Patch Detail
Show a patch.
GET /api/1.1/patches/18255/?format=api
{ "id": 18255, "url": "https://patchwork.libcamera.org/api/1.1/patches/18255/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18255/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230206170356.20340-2-laurent.pinchart@ideasonboard.com>", "date": "2023-02-06T17:03:53", "name": "[libcamera-devel,v1,1/4] libcamera: camera_sensor: Demote flip support message to Debug", "commit_ref": "fb344abda93cdf6f459a71d9829fcf4777a1284a", "pull_url": null, "state": "accepted", "archived": false, "hash": "4f21dbcd85e3b63a92f27f00fb9b38303bfcad56", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18255/mbox/", "series": [ { "id": 3740, "url": "https://patchwork.libcamera.org/api/1.1/series/3740/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3740", "date": "2023-02-06T17:03:52", "name": "Misc fixes for transformation handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3740/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18255/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18255/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 200B8C324D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Feb 2023 17:04:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B74E5625F8;\n\tMon, 6 Feb 2023 18:04:01 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B828E61EF4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Feb 2023 18:03:59 +0100 (CET)", "from pendragon.ideasonboard.com (unknown [109.136.43.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60B674DA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Feb 2023 18:03:59 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675703041;\n\tbh=3zkbHBkMwNqbmBaUC3eizRzKB3rzKck0Um3MDuTgJpA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jVpExFO5w7vtiBXD51xVKQve8q5wBfVyaT016pFeCgV/GNreVfIebahgspe6q+CQN\n\thTZ0y3wW+Cva1142ubCkqHxCiZvTSTcvjyxZPQydy8h2byR96O03nOHDCd3S+khE6k\n\t4sZ3gzuqOAXR0aQUc6xdASVt1Bn9Bh5jo/FM+AI0ii8oLGJWvAxYMM8axUOqYGBBHv\n\tOKsiUH7ykZGyeIJ5CwZoW1YCLc8v/shtsHwgFT5XEcxn8kB6/d/+dc5QvDt6IGdM6L\n\teAI+1efyEooMexS/GXvl772/F/FwNjbiS14+2zVEI+BN73COH5oyaMusKXOVEgEjx6\n\t7Ys70F6z85n0A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675703039;\n\tbh=3zkbHBkMwNqbmBaUC3eizRzKB3rzKck0Um3MDuTgJpA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=R36MTtk+K4JIdJDT3WYIqiAgf31V8nOJCqxu+feqbNH0tmzq5uEgVas15NHmCNoSl\n\tNYrdhKemzTID3jthkBWibMgPFf+MYPItCiE9gsVGYae7LlvOqx3xddItHruIjkv1CH\n\t8E+8SS7snYMexwERwzwuzkPIe1Ys9kU/io1GQp8Y=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R36MTtk+\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 6 Feb 2023 19:03:53 +0200", "Message-Id": "<20230206170356.20340-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>", "References": "<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/4] libcamera: camera_sensor: Demote\n\tflip support message to Debug", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CameraSensor::validateSensorDriver() function prints a Warning\nmessage when the camera sensor doesn't support flips. We don't mandate\nflip support and can run without it without any problem, so a warning is\ntoo harsh. Demote it to a Debug message.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_sensor.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex b772337eb44a..11117502d817 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -261,7 +261,7 @@ int CameraSensor::validateSensorDriver()\n \t\tsupportFlips_ = true;\n \n \tif (!supportFlips_)\n-\t\tLOG(CameraSensor, Warning)\n+\t\tLOG(CameraSensor, Debug)\n \t\t\t<< \"Camera sensor does not support horizontal/vertical flip\";\n \n \t/*\n", "prefixes": [ "libcamera-devel", "v1", "1/4" ] }