Patch Detail
Show a patch.
GET /api/1.1/patches/18048/?format=api
{ "id": 18048, "url": "https://patchwork.libcamera.org/api/1.1/patches/18048/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18048/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>", "date": "2022-12-22T01:01:29", "name": "[libcamera-devel,v1,1/4] test: v4l2_compat: Reduce indentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f5ae1440264689ec2d38e44afc9ebad0851416b6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18048/mbox/", "series": [ { "id": 3686, "url": "https://patchwork.libcamera.org/api/1.1/series/3686/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3686", "date": "2022-12-22T01:01:28", "name": "test: Various unit test cleanups", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3686/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18048/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18048/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CE30C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Dec 2022 01:01:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAF79633B6;\n\tThu, 22 Dec 2022 02:01:42 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 332F5633AC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Dec 2022 02:01:40 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B2281471\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Dec 2022 02:01:39 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671670902;\n\tbh=cz9wHI+yo2zWjHitCzRiAj7jAhnBsbvYQ2VlKET/cA8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=W3ze2myVTQQuh86byCkR82Gxi85QQGKPROrYDG95o8Y94cnxdVtASWdoFOeAAZWAZ\n\t+U9RKlfq2eIVQn7+4A0aWMPNsd20IF3L9JclwHF3TLvo5b9vOpMx+B0QXa9b2ujl+L\n\tryJipkrDPGsIsNftxQrccjgBBmx1CqtcnBmtojhGQP2ZukaWpemZ3xHBGppCfSikGK\n\tplTG5lD/q+QcInaNmIc+woVNscECWsh6vE0DknIOBa+DsQPCca2KflUGtSIkRVpJmY\n\tERR96xUeQA4SshsM2qO3ilPMIrjx4MzH6h54avG0jvwghTKCashuTcYVxg1gp5AxFY\n\tOGQk6YMMAca7Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671670899;\n\tbh=cz9wHI+yo2zWjHitCzRiAj7jAhnBsbvYQ2VlKET/cA8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CG6t0sRx/2tC28Kgx3k+uYjyapvYGHLQ5RGzP31+YM3+v8eqMW6vMPuNz+7qzjpZp\n\tcszatB9Yz7lLw6A1qEtlDYm5qIHCz5Qp0x1lcin+YNQYP/pflKufDeRNpPtNmgFgF0\n\tQGipgiZhk9DCczvyX66Rlw162BZ3er0vhTAtxbCo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CG6t0sRx\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Dec 2022 03:01:29 +0200", "Message-Id": "<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.38.2", "In-Reply-To": "<20221222010132.22177-1-laurent.pinchart@ideasonboard.com>", "References": "<20221222010132.22177-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce\n\tindentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Return early with subdir_done() to reduce indentation in case the\nv4l2_compat layer is not enabled. This matches our usual code patterns\nin meson.build files, and prepares for enabling the v4l2_compat test\nwith ASan.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_compat/meson.build | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/test/v4l2_compat/meson.build b/test/v4l2_compat/meson.build\nindex 878095892679..10c4675286b3 100644\n--- a/test/v4l2_compat/meson.build\n+++ b/test/v4l2_compat/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+if not is_variable('v4l2_compat')\n+ subdir_done()\n+endif\n+\n # If ASan is enabled, the link order runtime check will fail as v4l2-ctl and\n # v4l2-compliance are not linked to ASan. Skip the test in that case.\n #\n@@ -10,11 +14,9 @@ if get_option('b_sanitize').contains('address')\n subdir_done()\n endif\n \n-if is_variable('v4l2_compat')\n- v4l2_compat_test = files('v4l2_compat_test.py')\n+v4l2_compat_test = files('v4l2_compat_test.py')\n \n- test('v4l2_compat_test', v4l2_compat_test,\n- args : v4l2_compat,\n- suite : 'v4l2_compat',\n- timeout : 60)\n-endif\n+test('v4l2_compat_test', v4l2_compat_test,\n+ args : v4l2_compat,\n+ suite : 'v4l2_compat',\n+ timeout : 60)\n", "prefixes": [ "libcamera-devel", "v1", "1/4" ] }