From patchwork Thu Dec 22 01:01:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18048 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3CE30C3213 for ; Thu, 22 Dec 2022 01:01:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CAF79633B6; Thu, 22 Dec 2022 02:01:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1671670902; bh=cz9wHI+yo2zWjHitCzRiAj7jAhnBsbvYQ2VlKET/cA8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=W3ze2myVTQQuh86byCkR82Gxi85QQGKPROrYDG95o8Y94cnxdVtASWdoFOeAAZWAZ +U9RKlfq2eIVQn7+4A0aWMPNsd20IF3L9JclwHF3TLvo5b9vOpMx+B0QXa9b2ujl+L ryJipkrDPGsIsNftxQrccjgBBmx1CqtcnBmtojhGQP2ZukaWpemZ3xHBGppCfSikGK plTG5lD/q+QcInaNmIc+woVNscECWsh6vE0DknIOBa+DsQPCca2KflUGtSIkRVpJmY ERR96xUeQA4SshsM2qO3ilPMIrjx4MzH6h54avG0jvwghTKCashuTcYVxg1gp5AxFY OGQk6YMMAca7Q== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 332F5633AC for ; Thu, 22 Dec 2022 02:01:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CG6t0sRx"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2281471 for ; Thu, 22 Dec 2022 02:01:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671670899; bh=cz9wHI+yo2zWjHitCzRiAj7jAhnBsbvYQ2VlKET/cA8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CG6t0sRx/2tC28Kgx3k+uYjyapvYGHLQ5RGzP31+YM3+v8eqMW6vMPuNz+7qzjpZp cszatB9Yz7lLw6A1qEtlDYm5qIHCz5Qp0x1lcin+YNQYP/pflKufDeRNpPtNmgFgF0 QGipgiZhk9DCczvyX66Rlw162BZ3er0vhTAtxbCo= To: libcamera-devel@lists.libcamera.org Date: Thu, 22 Dec 2022 03:01:29 +0200 Message-Id: <20221222010132.22177-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.38.2 In-Reply-To: <20221222010132.22177-1-laurent.pinchart@ideasonboard.com> References: <20221222010132.22177-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce indentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Return early with subdir_done() to reduce indentation in case the v4l2_compat layer is not enabled. This matches our usual code patterns in meson.build files, and prepares for enabling the v4l2_compat test with ASan. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Paul Elder --- test/v4l2_compat/meson.build | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/test/v4l2_compat/meson.build b/test/v4l2_compat/meson.build index 878095892679..10c4675286b3 100644 --- a/test/v4l2_compat/meson.build +++ b/test/v4l2_compat/meson.build @@ -1,5 +1,9 @@ # SPDX-License-Identifier: CC0-1.0 +if not is_variable('v4l2_compat') + subdir_done() +endif + # If ASan is enabled, the link order runtime check will fail as v4l2-ctl and # v4l2-compliance are not linked to ASan. Skip the test in that case. # @@ -10,11 +14,9 @@ if get_option('b_sanitize').contains('address') subdir_done() endif -if is_variable('v4l2_compat') - v4l2_compat_test = files('v4l2_compat_test.py') +v4l2_compat_test = files('v4l2_compat_test.py') - test('v4l2_compat_test', v4l2_compat_test, - args : v4l2_compat, - suite : 'v4l2_compat', - timeout : 60) -endif +test('v4l2_compat_test', v4l2_compat_test, + args : v4l2_compat, + suite : 'v4l2_compat', + timeout : 60)