Patch Detail
Show a patch.
GET /api/1.1/patches/17986/?format=api
{ "id": 17986, "url": "https://patchwork.libcamera.org/api/1.1/patches/17986/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17986/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221213091558.621950-4-paul.elder@ideasonboard.com>", "date": "2022-12-13T09:15:54", "name": "[libcamera-devel,v2,3/7] tracepoints: request: Add tracepoint for addBuffer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f9f0a4b81982cc3d9e5f325bb258b603685e6406", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17986/mbox/", "series": [ { "id": 3668, "url": "https://patchwork.libcamera.org/api/1.1/series/3668/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3668", "date": "2022-12-13T09:15:51", "name": "tracepoints: request: Improve request tracepoints", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3668/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17986/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17986/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3FF1C328D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Dec 2022 09:16:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BE3163368;\n\tTue, 13 Dec 2022 10:16:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F0FE63361\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 10:16:16 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA1E3AFC;\n\tTue, 13 Dec 2022 10:16:14 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670922978;\n\tbh=lfft24zg/Os7CpJbn9HlIhwaI0PWX2xuE9iJsGAKZHw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ITn5ula7ELXJpukO+wbI1gS1q22jR+ChtJQeolrOBwfirLfkJ7mxsyqilFN8DDdrF\n\tbfI0ECX4G8PqsqkcgGAjGdIPBipbIJfWuMJkd7j8Szz8E9TzAV+34J+QHYjphlJ3Bh\n\tCqmjCWZ0GWyxOv3oOsQgsXY/GW0dAWiQn3o3Xyravi+tespHWrsQvgp9oWcXldkD09\n\t3WdabWB4sX9CS/Pidp4LACx8KHBPdKFwZghmP00SFuWRQGm0mFPTphrrFpyDgIQK41\n\tFzp5ulCxoDTApA5x9UQga88fNcZAhAslbNOh5BZElaImnoZ+VoAVCxJsTAuFONj4DH\n\tUKEbzNu/RrFOQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670922975;\n\tbh=lfft24zg/Os7CpJbn9HlIhwaI0PWX2xuE9iJsGAKZHw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qXB9jcxgZrTsdrxRAIZVIcN/jJ23GWWdytZAVEbpTHjTvTWdL2c+mWVBlarrZ5jrb\n\tCrJP0bfUZov9jDvTZuNFI034aSWooYOlfjjA1hnhykmHucQtZ17pEwS0F4lp3NLQ0a\n\t1LAR2zFKPPD6x+IFEoe72xcOA64Jd1cf4vThH2+4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qXB9jcxg\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Dec 2022 18:15:54 +0900", "Message-Id": "<20221213091558.621950-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "References": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/7] tracepoints: request: Add\n\ttracepoint for addBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a tracepoint event request_add_buffer for tracing\nRequest::addBuffer().\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- Change arg from private to public Request pointer\n---\n include/libcamera/internal/tracepoints/request.tp | 10 ++++++++++\n src/libcamera/request.cpp | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex b295b44f..e0ac45ac 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -100,6 +100,16 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n+TRACEPOINT_EVENT_INSTANCE(\n+\tlibcamera,\n+\trequest_with_buffer,\n+\trequest_add_buffer,\n+\tTP_ARGS(\n+\t\tlibcamera::Request *, req,\n+\t\tlibcamera::FrameBuffer *, buf\n+\t)\n+)\n+\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest_with_buffer,\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 652b7b70..226c26b7 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -463,6 +463,8 @@ void Request::reuse(ReuseFlag flags)\n int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr<Fence> fence)\n {\n+\tLIBCAMERA_TRACEPOINT(request_add_buffer, this, buffer);\n+\n \tif (!stream) {\n \t\tLOG(Request, Error) << \"Invalid stream reference\";\n \t\treturn -EINVAL;\n", "prefixes": [ "libcamera-devel", "v2", "3/7" ] }