Patch Detail
Show a patch.
GET /api/1.1/patches/17985/?format=api
{ "id": 17985, "url": "https://patchwork.libcamera.org/api/1.1/patches/17985/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17985/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221213091558.621950-3-paul.elder@ideasonboard.com>", "date": "2022-12-13T09:15:53", "name": "[libcamera-devel,v2,2/7] tracepoints: request: Add event class for request and buffer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "84c555890a967bfe3ef338b1a561132d6a1307d9", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17985/mbox/", "series": [ { "id": 3668, "url": "https://patchwork.libcamera.org/api/1.1/series/3668/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3668", "date": "2022-12-13T09:15:51", "name": "tracepoints: request: Improve request tracepoints", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3668/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17985/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17985/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8BC3BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Dec 2022 09:16:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F5E563365;\n\tTue, 13 Dec 2022 10:16:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78FAC63362\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 10:16:14 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 406904A7;\n\tTue, 13 Dec 2022 10:16:13 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670922977;\n\tbh=LdQhdsnyjvNC3yubUJqkWKOK9I0vrWbE5UsIW42V+g0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hthZk1xa5Ubrcb5V/Y/cwqtYK4n21X2onYraiAk5qUCUWFTDKlnlDiHpKXnVmqE8F\n\tXw1/k3Ekr+gzNRWGB6UCksY9dBFOZvEGMRy9cWs4/N8V3xphIDMxhaHzDbmPlTi2gv\n\t3kUtRUMc/9ckJfY/zwWcOSuqkGw91wlxANsvLxxiht3hyNtyHoUWEMatGcdrqYEtZb\n\ty4KV0v9GrwLyEj804ggPODQnzHRC+2G9T2bbYK1OrTIXNJ8pq9SgatzQEalZaFHcx+\n\tVmJfK1o/Yrhr6HNGc+Z1iQuPzDyE0OJD2HCHBUG3xNptPMAr3GJMEeIgw8nWU3eRXt\n\tk76HIz2sj1h2w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670922974;\n\tbh=LdQhdsnyjvNC3yubUJqkWKOK9I0vrWbE5UsIW42V+g0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PA2iXPHvQS/un3N5ty3cRK9C3uvpYRaDalQJdLeqyrz0tHVUXJEhff6cuIH+9Dk2B\n\tmhNX6dAeq3t7avp+Dp6aO7MfI9byBS9n5Cf/pYTOnRQ0exuPXrVBUETZ7X8coD/7xK\n\tEsHIw1oLk1cIuZ6Ika4P6/RPWHDCnoiZO0VFSPN4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PA2iXPHv\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Dec 2022 18:15:53 +0900", "Message-Id": "<20221213091558.621950-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "References": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/7] tracepoints: request: Add event\n\tclass for request and buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently there is one tracepoint event request_complete_buffer that\noutputs information on both the request and its buffer. We want to add\nanother event for add_buffer. Add an event class to cover this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- Change arg from private to public Request pointer\n---\n .../libcamera/internal/tracepoints/request.tp | 28 +++++++++++++------\n src/libcamera/request.cpp | 2 +-\n 2 files changed, 20 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex 9d0bcbfa..b295b44f 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -21,6 +21,22 @@ TRACEPOINT_EVENT_CLASS(\n \t)\n )\n \n+TRACEPOINT_EVENT_CLASS(\n+\tlibcamera,\n+\trequest_with_buffer,\n+\tTP_ARGS(\n+\t\tlibcamera::Request*, req,\n+\t\tlibcamera::FrameBuffer *, buf\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast<uintptr_t>(req))\n+\t\tctf_integer(uint64_t, cookie, req->cookie())\n+\t\tctf_integer(int, status, req->status())\n+\t\tctf_integer_hex(uintptr_t, buffer, reinterpret_cast<uintptr_t>(buf))\n+\t\tctf_enum(libcamera, buffer_status, uint32_t, buf_status, buf->metadata().status)\n+\t)\n+)\n+\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest,\n@@ -84,18 +100,12 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n-TRACEPOINT_EVENT(\n+TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n+\trequest_with_buffer,\n \trequest_complete_buffer,\n \tTP_ARGS(\n-\t\tlibcamera::Request::Private *, req,\n+\t\tlibcamera::Request *, req,\n \t\tlibcamera::FrameBuffer *, buf\n-\t),\n-\tTP_FIELDS(\n-\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast<uintptr_t>(req))\n-\t\tctf_integer(uint64_t, cookie, req->_o<libcamera::Request>()->cookie())\n-\t\tctf_integer(int, status, req->_o<libcamera::Request>()->status())\n-\t\tctf_integer_hex(uintptr_t, buffer, reinterpret_cast<uintptr_t>(buf))\n-\t\tctf_enum(libcamera, buffer_status, uint32_t, buf_status, buf->metadata().status)\n \t)\n )\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 1dedc26e..652b7b70 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -90,7 +90,7 @@ bool Request::Private::hasPendingBuffers() const\n */\n bool Request::Private::completeBuffer(FrameBuffer *buffer)\n {\n-\tLIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer);\n+\tLIBCAMERA_TRACEPOINT(request_complete_buffer, _o<Request>(), buffer);\n \n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n", "prefixes": [ "libcamera-devel", "v2", "2/7" ] }