Patch Detail
Show a patch.
GET /api/1.1/patches/17804/?format=api
{ "id": 17804, "url": "https://patchwork.libcamera.org/api/1.1/patches/17804/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17804/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221115131226.2063586-1-xavier.roumegue@oss.nxp.com>", "date": "2022-11-15T13:12:26", "name": "[libcamera-devel] libcamera: yaml_parser: Increase sentinel to 100k", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a20d4dc1d5b637d8f608612ebe7c4fba953bced5", "submitter": { "id": 107, "url": "https://patchwork.libcamera.org/api/1.1/people/107/?format=api", "name": "Xavier Roumegue", "email": "xavier.roumegue@oss.nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17804/mbox/", "series": [ { "id": 3612, "url": "https://patchwork.libcamera.org/api/1.1/series/3612/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3612", "date": "2022-11-15T13:12:26", "name": "[libcamera-devel] libcamera: yaml_parser: Increase sentinel to 100k", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3612/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17804/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17804/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 482EEBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Nov 2022 13:12:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C54FA63088;\n\tTue, 15 Nov 2022 14:12:58 +0100 (CET)", "from EUR03-DBA-obe.outbound.protection.outlook.com\n\t(mail-dbaeur03on2062c.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f400:fe1a::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE3B763079\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Nov 2022 14:12:57 +0100 (CET)", "from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)\n\tby PAXPR04MB8460.eurprd04.prod.outlook.com (2603:10a6:102:1db::13)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13;\n\tTue, 15 Nov 2022 13:12:55 +0000", "from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::14d3:8e4:cf07:810d]) by\n\tPAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::14d3:8e4:cf07:810d%3]) with mapi id 15.20.5813.018;\n\tTue, 15 Nov 2022 13:12:55 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668517978;\n\tbh=62/5KkeEkM9i2SIi5hgcW8M3ccT+3Ld7sHQF3polkLc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W1a2Y0NUXJ+zkbNCMI37HWloRrCc/TDNamPYuNABtXemEDw+jCsxaU7+UTCxU4h/V\n\tEe9Qv1QbID6VuC/h/QeiSX2UMqjZpDLcQeWhBnsGYInhDD2xnSxFNIfSJpR8VC2+6J\n\tk7MrUbqPGfL45nuvx+zwCupSTOdmH3oe1RTt+Pph2GDGE/Hm6hZpjKaSzW/xDJHkej\n\tig3DwplTGhlG+iz6DoMzM1qCHPLyyIw51Q+HTlVybIYnOGbFxgguHqKxaxQeZbj3Vk\n\tGLabS+JPVxRNTknFePd/u6bvoQo4QV+Tm2JYGkfTtjdFkg+b/DRTTd72+K1RgSHryB\n\tA+ChxwvtHnMyw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n\ts=selector2-NXP1-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=9Lee7jCOdHxAIQFPYv0tBWGW2EGeVytWDbDj8loR+SI=;\n\tb=k9iACLuGcz+TXSyq3uHTUPQUzn7YIKFxTRbkOnW43fhpS/jwfXZx9IzSQDGpykKHVwUhURz6Uq1f60/S6vDwsByaDanf6J2M9cBCadI4JEBWtcqaEEhiaB2pcUiphsTTVxViry5edoTPlLONlVu4elhp7ohmOmcYOHQDMKbDn4A=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=NXP1.onmicrosoft.com\n\theader.i=@NXP1.onmicrosoft.com\n\theader.b=\"k9iACLuG\"; dkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=oss.nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=TBM6OaFfiA+BK8XVw1zuTrtqsIwLkUID4ReYpEufVfTwGMf2jUdxf+FSrnFFexES9MCXcGfr7hGU0wK0vDrW5ytWbqeDzWUu/QMUgdyW2NP/DY8MdWVxcITFDVkElmgnUu7ll7G8iUghhYkdY64TT3t0gsC6Wlm02MhploCMvPumAd8vLNsETsGljtFBa9zWHskqP8gIMLl4RFoPIEVpweVIQf/PhkZqfQFfrWbvF4p9xP2IP/P2g7ANTDLGqxj2h7HQ6EjDxU8rYx21x1RfR3riH0ffz84GW2zHedXyEyO61vatxYYaQ6W/x2Oo9pimFS4U+OqvRE13IqPlhGt2eQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=9Lee7jCOdHxAIQFPYv0tBWGW2EGeVytWDbDj8loR+SI=;\n\tb=fdxK9ZfTjpjWx4aTncrAcTHX1LvNk7/DqPaKtmpCWaliTrS6ZMOs+gyLVx1/kQObNZbZATrMg9p2i9GnvWOvgMSYA5Iv8bak64xP/T4DcWryqYsMtwMUW847hvu741hHb7NbSh/daaS655s80bNHmKMuEfdzTUqHH/+8N8E6o1zYx9OfWRa9qq9ycbOzcbr1bpW99qy6UUCLpqETYnejACo0m3IU7x4ktJBO5cHlwv9A1rCbun8pmxs8wq+sq6nmtoshP4wYrAQBvX70PmtZrvArXCwfxPQ+DA/rnDNojZzcqos2V3Lf80CXv947Pb5l4zCEL82Nv8QqaBCe2krRgg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=oss.nxp.com;\n\tdmarc=pass action=none header.from=oss.nxp.com; \n\tdkim=pass header.d=oss.nxp.com; arc=none", "To": "laurent.pinchart@ideasonboard.com", "Date": "Tue, 15 Nov 2022 14:12:26 +0100", "Message-Id": "<20221115131226.2063586-1-xavier.roumegue@oss.nxp.com>", "X-Mailer": "git-send-email 2.38.1", "In-Reply-To": "<YztfKn5WcONK7sBy@pendragon.ideasonboard.com>", "References": "<YztfKn5WcONK7sBy@pendragon.ideasonboard.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "PR1P264CA0133.FRAP264.PROD.OUTLOOK.COM\n\t(2603:10a6:102:2ce::18) To PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8703:EE_|PAXPR04MB8460:EE_", "X-MS-Office365-Filtering-Correlation-Id": "59d13dbf-8e0e-4dc7-5084-08dac70b1b99", "X-MS-Exchange-SharedMailbox-RoutingAgent-Processed": "True", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "Z5FzSFtplPnP7bKb1IAMoM2pNzhWUcLNqGU7V+y5zaWzTmt9CMjFOC26Ex+zV9XsaGCz+gTFeU5rI63gMf2fivO3nr8GI86R2rekv9xwEOdZerr5utvdwhJwbfAhwFFabZ80XWlgYQHZLI9IAziUA9dTGlwrhcjx39sfIfrHWsoHfdgcep9+gMj2X1ToMcoQ9Gq1ry8HPnfjDY5VHQfAZnGrb0WWrd74V7KjWLv0/2gxTUKpnoBDYIk5tWAqho1KC1gpfhvswaaipKIz2mG0Q1jsmuD9uVI2fRVHbOZS+rlNo42lM4jUfDSr4RiXnY3n10Sz2Pd9c3sajRPgp+riq/knlzvKOxgdL0Li20yniwMU+7eOeg5KjwpNObZng2r2TzBlxc1HX831u0MW/PV4XQgZMa0kUt4G8e5JXwf31oGQre2V9DgnrQYYMfpb2PtVn63GkcLyyLVPKOcK3BoBVw8iqfUklsIZx0zZo3aNnBMkgIhp4Fvrr5eBPzVbpa2o75QV+++G0eQNQzitK/jUwa/k1eTLsGsprHLfKLEVz34owwKTJe/fl++wVBaeLTnwcF2DUUrAtJQpnkqgMlxtEr2GtOiYiqwc9o4pjrzuEQHdSPB5b7iK1lGFAkNutdtiOS5bOzAFTJDS3dUoqv4uSlwWwZ65VkPGBH+hOn0YKdjm59CyPTSpVK9ie96bilDB9YpXmaQA6AMxgLo3Cp8AHg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(451199015)(38100700002)(4326008)(44832011)(316002)(6916009)(2906002)(8936002)(66946007)(66556008)(66476007)(8676002)(5660300002)(478600001)(1076003)(186003)(6486002)(2616005)(83380400001)(86362001)(6506007)(41300700001)(52116002)(6512007)(6666004);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "24nJ5NRzhn3DFs4veJnbWj5wy0Zc3FH1sWZ1lVbda/CYdTOBhJ0BqJTd7BqO7Y1Db/Fd6EvRzweFiM/mJTgiHM+kRbH9f3D89dRCxgXbxe1YUmF1XvAeOU2+9ju+cI+cgzBE9gAXJxuoWqvlUwph2PudlMUH4/CbDDoGOdStjAUC16FjNvtyACj/baH8UZFmA56KCxZxmtaG5fBbLjoHiHaSZjKyZZChB7TshA3UNBtp8C2jDfXX8sSe2G5qscs4QAXLuTORSMVtXiFgQfaV8/+rTIIm2nPNArQ2VgN6rxtXH2Ok8lSRxVyGDDGavnehipRa3jMgB04IGPvRwssQNzETVFQ8hSPO/g5p7oSTZ8ZQflS3sunZW3sxcvTKOV9SqQJXRyWiYWPqZkcy24veLZCx9ubHn8jKVcHEEp3USEiytzrKN6ENeIQbH/0m+dDRufuXmuFVTRiUEpYBmPUVgh6xLqsid1ziEhzELFAhAe6s/9fHJcxEHGip7C6LFGy9xuE58xF2wNvu2193FXpfqdGzUhXFnLIAJLZEfm4T7/f1QhsqPD2ntHCqBavVduffKQy0inRS5MZp0tQJVIPAp8TRyx1wfpGAWQw/pi+aA+M/qNI7gBFgn/Tv7/LctwGp9NfOCWQ17JWHjwE8kugUDPCeI/muwhj6gV6bjpkMKn+Pt6pG9x/aMtAmSGVl0TttESrWEfubqFTUV0YVPRGUU3luW+e4Yy7miGaweL3MCnj0Lj3Mj6QfznHoXgieCgNrPO6CNM5mltrRjEG4HCOPNJyLJVeDtULlNf8bTzvJBt9Vr0rG5NNk7Ku13vULUGQDy2cZAH4rxpZsFHcbWvJsVaLESF99MIYtm0mzd+P364lAatijIoFg/iv2gr9ZdIdn4T9OJs/89UoPZ0jH1mllmd5Njz8F+6EPHX0VZWrhr8IyLouKOnjinY8LpgzuZVkwnrsNOrLsI+wTXBVTVpvk8XMDAD23sN6iz68w6IOunkjrS3sOhAki+jBssIXUSDSY30dyLpt5493Tkjvt4urpR9K4p3A0QPoIpHlkOAmKcLebnZi1bBk6Xl78OY9yvJqHdxPfBXmlAaoNRNIyuIjX/KAYxK9roY2Lr/Snb6rRaeDfllbPVvR6eBV/lp+ylFIaQPfkH+equgsUMboPHH3DBClr7qO9DHmiDnqqC3chN5QRa5fFVZUq9jsnGbFPE9rWrWYOVUObAXJuiL9htKxwSmC8EzBR3Z5iGpYSd8igh4jxe6g28FMMbLurAyX4NZV9XMKh2rQ7VAY4d2err9oA9rX2A6MQLOezV3IKEY4WEHhLPWKzQ8QoT4i3bAoXByBHQfl3e8ri22NBCQO/Jt7Y0qkNa2rmvub4Q0KbcnOXffr6zZBYcHqTRH2JwkX2UFr8K7khofQxP/MwVBurhgu3lfMUZdQnV607BwI+2SVHTpLbazdH7Wt0rG143h33vwjaU8nPrRO04mFCD8g2KhrF2BDxz7jCV9ciihi+mt7SKndTqpVfdWBWjpftpONu/GW75VZBJqFSte2iA/AGjntY/65F4B0moy/iJ09J3T2MsZwxHz6d0mijqvY8BkBudgl1QLt34mjL7Z6FznppQPDV2z11zo26D02VfWpzZSaBMvBLxiEHQbmXXYFAZ264T8upinugZQaylJM0nIV1y1TdqA==", "X-OriginatorOrg": "oss.nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "59d13dbf-8e0e-4dc7-5084-08dac70b1b99", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB8703.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Nov 2022 13:12:54.9508\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "5Zq0tCEPsjjr9j3FFD0nFlwFDDxfbDh4EPpRp1nPOfOTeiojZWYw4sYH3D1I4B1MXj7J0W7KFXnSxuuMX9AUYg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAXPR04MB8460", "Subject": "[libcamera-devel] [PATCH] libcamera: yaml_parser: Increase sentinel\n\tto 100k", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Xavier Roumegue via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Xavier Roumegue <xavier.roumegue@oss.nxp.com>", "Cc": "libcamera-devel@lists.libcamera.org", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The original sentinel limit is reached with file holding dewarping\nmapping coordinates. A long term solution would be to use a binary file\nformat to store high density data file. But for now, simply increase the\nlimit to a high arbitrary value.\n\nSigned-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>\n---\n src/libcamera/yaml_parser.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex d8a7c2f9..8bd5eda3 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -668,6 +668,7 @@ void YamlParserContext::readValue(std::string &value, EventPtr event)\n int YamlParserContext::parseDictionaryOrList(YamlObject::Type type,\n \t\t\t\t\t const std::function<int(EventPtr event)> &parseItem)\n {\n+\tconstexpr unsigned int sentinelLimit = 100000;\n \tyaml_event_type_t endEventType = YAML_SEQUENCE_END_EVENT;\n \tif (type == YamlObject::Type::Dictionary)\n \t\tendEventType = YAML_MAPPING_END_EVENT;\n@@ -676,7 +677,7 @@ int YamlParserContext::parseDictionaryOrList(YamlObject::Type type,\n \t * Add a safety counter to make sure we don't loop indefinitely in case\n \t * the YAML file is malformed.\n \t */\n-\tfor (unsigned int sentinel = 1000; sentinel; sentinel--) {\n+\tfor (unsigned int sentinel = sentinelLimit; sentinel; sentinel--) {\n \t\tauto evt = nextEvent();\n \t\tif (!evt)\n \t\t\treturn -EINVAL;\n@@ -690,7 +691,8 @@ int YamlParserContext::parseDictionaryOrList(YamlObject::Type type,\n \t}\n \n \tLOG(YamlParser, Error) << \"The YAML file contains a List or Dictionary\"\n-\t\t\t\t \" whose size exceeds the parser's limit (1000)\";\n+\t\t\t\t \" whose size exceeds the parser's limit (\"\n+\t\t\t << sentinelLimit << \")\";\n \n \treturn -EINVAL;\n }\n", "prefixes": [ "libcamera-devel" ] }